You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/08 01:53:25 UTC
[GitHub] [dolphinscheduler] SbloodyS opened a new pull request #8747: [Fix-8744][standalone-server] start standalone server failed
SbloodyS opened a new pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
Fix #8744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #8747: [Fix-8744][standalone-server] start standalone server failed
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747#issuecomment-1062511000
I get your point and test build locally It just like your said in the issue https://github.com/apache/dolphinscheduler/issues/8744.
@kezhenxu94 I do not know why, but it seem our file mode change here do not work, do you have time to see it?
https://github.com/apache/dolphinscheduler/blob/d2a360480afdabfc918b7a1d9fd458645d7bf78a/dolphinscheduler-standalone-server/src/main/assembly/dolphinscheduler-standalone-server.xml#L80-L85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #8747: [Fix-8744][standalone-server] start standalone server failed
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747#issuecomment-1061336280
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8747&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8747&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #8747: [Fix-8744][standalone-server] start standalone server failed
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747#issuecomment-1062492044
> I found out we already change `start.sh` in
>
> https://github.com/apache/dolphinscheduler/blob/d2a360480afdabfc918b7a1d9fd458645d7bf78a/dolphinscheduler-standalone-server/src/main/assembly/dolphinscheduler-standalone-server.xml#L80-L85
>
> Do you test in the binary package? @SbloodyS
Yes. This is the bin folder in the ```dolphinscheduler_home``` directory. But the file in standalone-server/api-server/xxx's bin folder's permission was modified in ```dolphinscheduler-dist/src/main/assembly/dolphinscheduler-bin.xml``` which will cause insufficient permissions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #8747: [Fix-8744][standalone-server] start standalone server failed
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747#issuecomment-1062511959
> Yes. This is the bin folder in the dolphinscheduler_home directory.
@SbloodyS BTW, it not the bin directory in `Dolphinshceduler Home`, I think this config should change file `start.sh` in `standalone-server/bin`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on a change in pull request #8747: [Fix-8744][standalone-server] start standalone server failed
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747#discussion_r822269847
##########
File path: script/dolphinscheduler-daemon.sh
##########
@@ -71,7 +71,7 @@ fi
case $startStop in
(start)
echo starting $command, logging to $DOLPHINSCHEDULER_LOG_DIR
- nohup "$DOLPHINSCHEDULER_HOME/$command/bin/start.sh" > $log 2>&1 &
+ nohup /bin/bash "$DOLPHINSCHEDULER_HOME/$command/bin/start.sh" > $log 2>&1 &
Review comment:
As we're using this shebang `#!/bin/sh`, so it's better
```suggestion
nohup /bin/sh "$DOLPHINSCHEDULER_HOME/$command/bin/start.sh" > $log 2>&1 &
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #8747: [Fix-8744][standalone-server] start standalone server failed
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747#issuecomment-1062524033
> But the standalone-server folder and file permission was changed after final assemby in
Is there any setting to copy file follow previous file mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #8747: [Fix-8744][standalone-server] start standalone server failed
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747#issuecomment-1062489158
I found out we already change `start.sh` in
https://github.com/apache/dolphinscheduler/blob/d2a360480afdabfc918b7a1d9fd458645d7bf78a/dolphinscheduler-standalone-server/src/main/assembly/dolphinscheduler-standalone-server.xml#L80-L85
Do you test in the binary package? @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #8747: [Fix-8744][standalone-server] start standalone server failed
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747#issuecomment-1062525403
> > But the standalone-server folder and file permission was changed after final assemby in
>
> Is there any setting to copy file follow previous file mode?
I'm not familiar with this plugin. Is there anyone else familiar with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #8747: [Fix-8744][standalone-server] start standalone server failed
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747#issuecomment-1062557621
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8747&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8747&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #8747: [Fix-8744][standalone-server] start standalone server failed
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747#issuecomment-1062514735
> > Yes. This is the bin folder in the dolphinscheduler_home directory.
>
> @SbloodyS BTW, it not the bin directory in `Dolphinshceduler Home`, I think this config should change file `start.sh` in `standalone-server/bin`
The permissioin of ```standalone-server/bin/start.sh``` has benn changed in https://github.com/apache/dolphinscheduler/blob/d2a360480afdabfc918b7a1d9fd458645d7bf78a/dolphinscheduler-standalone-server/src/main/assembly/dolphinscheduler-standalone-server.xml#L80
And we can see the file permission is right in the ```dolphinscheduler-standalone-server/target/standalone-server``` after compiled.
But the ```standalone-server``` folder and file permission was changed after final assemby in
https://github.com/apache/dolphinscheduler/blob/d2a360480afdabfc918b7a1d9fd458645d7bf78a/dolphinscheduler-dist/src/main/assembly/dolphinscheduler-bin.xml#L58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 merged pull request #8747: [Fix-8744][standalone-server] start standalone server failed
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #8747: [Fix-8744][standalone-server] start standalone server failed
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747#issuecomment-1062533576
I look around and see this is indeed an issue, assembly plugin requires file permissions to be set explicitly, it won't retain the original permissions when assembly the tar, so we have to :
- Assembly the executable files and non-executable files separately, which requires more maintenance
- Do as this PR does, I prefer this one, it's just the style changed from `./xxx.sh` to `sh ./xxx.sh`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #8747: [Fix-8744][standalone-server] start standalone server failed
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747#issuecomment-1062553871
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/8747?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8747](https://codecov.io/gh/apache/dolphinscheduler/pull/8747?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (575bc6e) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/aa5392529bb8d2ba7b4b73a9527adf713f8884c8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa53925) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dolphinscheduler/pull/8747?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## dev #8747 +/- ##
============================================
- Coverage 45.32% 45.29% -0.04%
+ Complexity 4078 4075 -3
============================================
Files 702 702
Lines 27112 27112
Branches 2897 2897
============================================
- Hits 12289 12280 -9
- Misses 13667 13678 +11
+ Partials 1156 1154 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/8747?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/dolphinscheduler/common/enums/SqoopJobType.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8747/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1Nxb29wSm9iVHlwZS5qYXZh) | `0.00% <0.00%> (-88.89%)` | :arrow_down: |
| [...inscheduler/common/task/sqoop/SqoopParameters.java](https://codecov.io/gh/apache/dolphinscheduler/pull/8747/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvU3Fvb3BQYXJhbWV0ZXJzLmphdmE=) | `74.00% <0.00%> (-2.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/8747?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/8747?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aa53925...575bc6e](https://codecov.io/gh/apache/dolphinscheduler/pull/8747?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] removed a comment on pull request #8747: [Fix-8744][standalone-server] start standalone server failed
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747#issuecomment-1061336280
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8747&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8747&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8747&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #8747: [Fix-8744][standalone-server] start standalone server failed
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747#issuecomment-1062483166
Maybe we could change file mode in assemely process
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #8747: [Fix-8744][standalone-server] start standalone server failed
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747#issuecomment-1062488763
> Maybe we could change file mode in assemely process
The file is assemely in ```dolphinscheduler-dist/src/main/assembly/dolphinscheduler-bin.xml```. This is to move the whole folder. If permissions are set, the permissions of files in the whole folder will be modified. If files are disassembled by type, there will be a lot of repetitive maintenance work for subsequent additions and deletions. So I chose this relatively general way. @zhongjiajie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #8747: [Fix-8744][standalone-server] start standalone server failed
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747#issuecomment-1061339938
@zhongjiajie @caishunfeng Please review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS edited a comment on pull request #8747: [Fix-8744][standalone-server] start standalone server failed
Posted by GitBox <gi...@apache.org>.
SbloodyS edited a comment on pull request #8747:
URL: https://github.com/apache/dolphinscheduler/pull/8747#issuecomment-1062514735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org