You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/08 19:37:00 UTC
[GitHub] [tvm] tkonolige opened a new pull request #10531: [CMAKE] Add option to enable custom logging
tkonolige opened a new pull request #10531:
URL: https://github.com/apache/tvm/pull/10531
This option just passes -DTVM_LOG_CUSTOMIZE=1 to the compiler.
@areusch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #10531: [CMAKE] Add option to enable custom logging
Posted by GitBox <gi...@apache.org>.
areusch merged pull request #10531:
URL: https://github.com/apache/tvm/pull/10531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #10531: [CMAKE] Add option to enable custom logging
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #10531:
URL: https://github.com/apache/tvm/pull/10531#discussion_r823914397
##########
File path: cmake/modules/Logging.cmake
##########
@@ -17,6 +17,15 @@
# This script configures the logging module and dependency on libbacktrace
+if(USE_CUSTOM_LOGGING)
+ # Set and propogate TVM_LOG_CUSTOMIZE flag is custom logging has been requested
+ target_compile_definitions(tvm_objs PUBLIC TVM_LOG_CUSTOMIZE=1)
Review comment:
what about tvm_allvisible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #10531: [CMAKE] Add option to enable custom logging
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #10531:
URL: https://github.com/apache/tvm/pull/10531#discussion_r825073650
##########
File path: cmake/modules/Logging.cmake
##########
@@ -17,6 +17,15 @@
# This script configures the logging module and dependency on libbacktrace
+if(USE_CUSTOM_LOGGING)
+ # Set and propogate TVM_LOG_CUSTOMIZE flag is custom logging has been requested
+ target_compile_definitions(tvm_objs PUBLIC TVM_LOG_CUSTOMIZE=1)
Review comment:
🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on a change in pull request #10531: [CMAKE] Add option to enable custom logging
Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #10531:
URL: https://github.com/apache/tvm/pull/10531#discussion_r823929169
##########
File path: cmake/modules/Logging.cmake
##########
@@ -17,6 +17,15 @@
# This script configures the logging module and dependency on libbacktrace
+if(USE_CUSTOM_LOGGING)
+ # Set and propogate TVM_LOG_CUSTOMIZE flag is custom logging has been requested
+ target_compile_definitions(tvm_objs PUBLIC TVM_LOG_CUSTOMIZE=1)
Review comment:
I've added a change to propagate compile definitions from tvm to tvm_allvisible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org