You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/12 19:49:57 UTC
[GitHub] [pulsar] gaozhangmin opened a new pull request #11285: broker gc log
gaozhangmin opened a new pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285
It seems that, We configured params for broker gc log, but not used.
turn on broker gc log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-946669420
> > > Could you check my comments? It looks like `pulsar-client-cpp/pulsar-test-service-start.sh` cannot run successfully after this change.
> >
> >
> > @BewareMyPower Sure, I will check later.
>
> @BewareMyPower I tested locally `pulsar-client-cpp/pulsar-test-service-start.sh`, successfully run without error.
Did you use Java 11? The CI env is a docker container based on Ubuntu 16.04 and Java 11.
```bash
$ java -version
openjdk version "11.0.11" 2021-04-20
OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.16.04)
OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.16.04, mixed mode, sharing)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-926695912
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-947472770
> You can modify `pulsar-client-cpp/run-unit-tests.sh` line 26 from
>
> ```shell
> ./pulsar-test-service-start.sh
> ```
>
> to
>
> ```shell
> JAVA_HOME=/usr ./pulsar-test-service-start.sh
> ```
>
> Then `bin/pulsar` would choose `/usr/bin/java` rather than the original `$JAVA_HOME/bin/java`.
Thx. It worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin edited a comment on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
gaozhangmin edited a comment on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-927221731
test failed reason: Unrecognized option: -Xlog:gc:logs/pulsar_gc_%p.log:time,uptime:filecount=10,filesize=20M
I cannot figure out why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-947425907
You can modify `pulsar-client-cpp/run-unit-tests.sh` line 26 from
```bash
./pulsar-test-service-start.sh
```
to
```bash
JAVA_HOME=/usr ./pulsar-test-service-start.sh
```
Then `bin/pulsar` would choose `/usr/bin/java` rather than the original `$JAVA_HOME/bin/java`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-947454468
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-930687055
@gaozhangmin - I think you still need to update the documentation here: https://github.com/apache/pulsar/blob/master/site2/docs/reference-cli-tools.md.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-946689401
> > > > Could you check my comments? It looks like `pulsar-client-cpp/pulsar-test-service-start.sh` cannot run successfully after this change.
> > >
> > >
> > > @BewareMyPower Sure, I will check later.
> >
> >
> > @BewareMyPower I tested locally `pulsar-client-cpp/pulsar-test-service-start.sh`, successfully run without error.
>
> Did you use Java 11? The CI env is a docker container based on Ubuntu 16.04 and Java 11.
>
> ```shell
> $ java -version
> openjdk version "11.0.11" 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.16.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.16.04, mixed mode, sharing)
> ```
I tested without `PULSAR_GC_LO` successfully, I don't know why this jdk11 cannot recognize `xlog:gc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-946466726
> > Could you check my comments? It looks like `pulsar-client-cpp/pulsar-test-service-start.sh` cannot run successfully after this change.
>
> @BewareMyPower Sure, I will check later.
> > Could you check my comments? It looks like `pulsar-client-cpp/pulsar-test-service-start.sh` cannot run successfully after this change.
>
> @BewareMyPower Sure, I will check later.
@BewareMyPower I tested locally `pulsar-client-cpp/pulsar-test-service-start.sh`, successfully run without error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-878739446
> Thanks for your contribution. For this PR, do we need to update docs?
I think there is no need to update docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #11285: Fix broker gc log options
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#discussion_r758262301
##########
File path: conf/pulsar_env.sh
##########
@@ -54,11 +54,11 @@ if [[ -n $IS_JAVA_8 ]]; then
PULSAR_GC_LOG=${PULSAR_GC_LOG:-"-Xloggc:logs/pulsar_gc_%p.log -XX:+PrintGCDetails -XX:+PrintGCDateStamps -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=10 -XX:GCLogFileSize=20M"}
else
# After jdk 9, gc log param should config like this. Ignoring version less than jdk 8
- PULSAR_GC_LOG=${PULSAR_GC_LOG:-"-Xlog:gc:logs/pulsar_gc_%p.log:time,uptime:filecount=10,filesize=20M"}
+ PULSAR_GC_LOG=${PULSAR_GC_LOG:-"-Xlog:gc*:logs/pulsar_gc_%p.log:time,uptime:filecount=10,filesize=20M"}
fi
# Extra options to be passed to the jvm
-PULSAR_EXTRA_OPTS=${PULSAR_EXTRA_OPTS:-" -Dpulsar.allocator.exit_on_oom=true -Dio.netty.recycler.maxCapacity.default=1000 -Dio.netty.recycler.linkCapacity=1024"}
+PULSAR_EXTRA_OPTS="${PULSAR_EXTRA_OPTS:-" -Dpulsar.allocator.exit_on_oom=true -Dio.netty.recycler.maxCapacity.default=1000 -Dio.netty.recycler.linkCapacity=1024"} ${PULSAR_GC_LOG}"
Review comment:
I created #13022 with a minimal fix to the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on a change in pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on a change in pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#discussion_r716197064
##########
File path: bin/pulsar
##########
@@ -287,6 +288,9 @@ PULSAR_LOG_APPENDER=${PULSAR_LOG_APPENDER:-"RoutingAppender"}
PULSAR_LOG_ROOT_LEVEL=${PULSAR_LOG_ROOT_LEVEL:-"info"}
PULSAR_LOG_LEVEL=${PULSAR_LOG_LEVEL:-"info"}
PULSAR_ROUTING_APPENDER_DEFAULT=${PULSAR_ROUTING_APPENDER_DEFAULT:-"Console"}
+if [ ! -d "$PULSAR_LOG_DIR" ]; then
+ mkdir -p "$PULSAR_LOG_DIR"
Review comment:
Here, We should also create log dir if it doesn't exists, not only try create log dir in `pulsar-daemon.sh`,
Such as, If We try to `pulsar-current/bin/pulsar initialize-cluster-metadata`, we would fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-944301830
> Unrecognized option: -Xlog:gc:logs/pulsar_gc_%p.log:time,uptime:filecount=10,filesize=20M
It looks like some JVM params cannot be applied to the `apachepulsar/pulsar-build:ubuntu-16.04-pb3` image?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower edited a comment on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
BewareMyPower edited a comment on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-946317610
Could you check my comments? It looks like `pulsar-client-cpp/pulsar-test-service-start.sh` cannot run successfully after this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-946857706
I will take a look at this issue tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin edited a comment on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
gaozhangmin edited a comment on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-946466726
> > Could you check my comments? It looks like `pulsar-client-cpp/pulsar-test-service-start.sh` cannot run successfully after this change.
>
> @BewareMyPower Sure, I will check later.
@BewareMyPower I tested locally `pulsar-client-cpp/pulsar-test-service-start.sh`, successfully run without error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-878760016
Anyone can review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-947421580
I found the problem. It's because when the standalone starts, it chooses the `/usr/lib/jvm/java-1.8.0-openjdk-amd64/bin/java` rather than `/usr/bin/java`.
```bash
$ /usr/lib/jvm/java-1.8.0-openjdk-amd64/bin/java -version
openjdk version "1.8.0_292"
OpenJDK Runtime Environment (build 1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10)
OpenJDK 64-Bit Server VM (build 25.292-b10, mixed mode)
$ java -version
openjdk version "11.0.11" 2021-04-20
OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.16.04)
OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.16.04, mixed mode, sharing)
```
I think it's caused by wrong `JAVA_HOME` variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin edited a comment on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
gaozhangmin edited a comment on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-946689401
> > > > Could you check my comments? It looks like `pulsar-client-cpp/pulsar-test-service-start.sh` cannot run successfully after this change.
> > >
> > >
> > > @BewareMyPower Sure, I will check later.
> >
> >
> > @BewareMyPower I tested locally `pulsar-client-cpp/pulsar-test-service-start.sh`, successfully run without error.
>
> Did you use Java 11? The CI env is a docker container based on Ubuntu 16.04 and Java 11.
>
> ```shell
> $ java -version
> openjdk version "11.0.11" 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.16.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.16.04, mixed mode, sharing)
> ```
I tested without `PULSAR_GC_LOG` successfully, I don't know why this jdk11 cannot recognize `xlog:gc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-943133982
@michaeljmarshall Could you take a look again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#discussion_r715810211
##########
File path: conf/bkenv.sh
##########
@@ -30,16 +30,26 @@ BOOKIE_CONF=${BOOKIE_CONF:-"$BK_HOME/conf/bookkeeper.conf"}
# BOOKIE_LOG_CONF=
# Logs location
-# BOOKIE_LOG_DIR=
+BOOKIE_LOG_DIR=${BOOKIE_LOG_DIR:-"$BK_HOME/logs"}
+mkdir -p "$BOOKIE_LOG_DIR"
# Memory size options
BOOKIE_MEM=${BOOKIE_MEM:-${PULSAR_MEM:-"-Xms2g -Xmx2g -XX:MaxDirectMemorySize=2g"}}
# Garbage collection options
BOOKIE_GC=${BOOKIE_GC:-${PULSAR_GC:-"-XX:+UseG1GC -XX:MaxGCPauseMillis=10 -XX:+ParallelRefProcEnabled -XX:+UnlockExperimentalVMOptions -XX:+DoEscapeAnalysis -XX:ParallelGCThreads=32 -XX:ConcGCThreads=32 -XX:G1NewSizePercent=50 -XX:+DisableExplicitGC -XX:-ResizePLAB"}}
+IS_JAVA_8=`java -version 2>&1 |grep version|grep '"1\.8'`
+# java version has space, use [[ -n $PARAM ]] to judge if variable exists
+if [[ -n $IS_JAVA_8 ]]; then
+ Bookie_GC_LOG=${Bookie_GC_LOG:-"-Xloggc:logs/pulsar_bookie_gc_%p.log -XX:+PrintGCDetails -XX:+PrintGCDateStamps -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=10 -XX:GCLogFileSize=20M"}
Review comment:
Nit. I might be missing something, but I think this variable should be all caps.
```suggestion
BOOKIE_GC_LOG=${BOOKIE_GC_LOG:-"-Xloggc:logs/pulsar_bookie_gc_%p.log -XX:+PrintGCDetails -XX:+PrintGCDateStamps -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=10 -XX:GCLogFileSize=20M"}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-927221731
test failed reason: Unrecognized option: -Xlog:gc:logs/pulsar_gc_%p.log:time,uptime:filecount=10,filesize=20M
I cannot figure why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin edited a comment on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
gaozhangmin edited a comment on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-930852501
> @gaozhangmin - I think you still need to update the documentation here: https://github.com/apache/pulsar/blob/master/site2/docs/reference-cli-tools.md.
@michaeljmarshall DOCS added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-930852501
> @gaozhangmin - I think you still need to update the documentation here: https://github.com/apache/pulsar/blob/master/site2/docs/reference-cli-tools.md.
Docs added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-878717441
Thanks for your contribution. For this PR, do we need to update docs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-926316657
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-976109768
@codelipenghui PTAL again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #11285: Fix broker gc log options
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#discussion_r758242833
##########
File path: conf/pulsar_env.sh
##########
@@ -54,11 +54,11 @@ if [[ -n $IS_JAVA_8 ]]; then
PULSAR_GC_LOG=${PULSAR_GC_LOG:-"-Xloggc:logs/pulsar_gc_%p.log -XX:+PrintGCDetails -XX:+PrintGCDateStamps -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=10 -XX:GCLogFileSize=20M"}
else
# After jdk 9, gc log param should config like this. Ignoring version less than jdk 8
- PULSAR_GC_LOG=${PULSAR_GC_LOG:-"-Xlog:gc:logs/pulsar_gc_%p.log:time,uptime:filecount=10,filesize=20M"}
+ PULSAR_GC_LOG=${PULSAR_GC_LOG:-"-Xlog:gc*:logs/pulsar_gc_%p.log:time,uptime:filecount=10,filesize=20M"}
fi
# Extra options to be passed to the jvm
-PULSAR_EXTRA_OPTS=${PULSAR_EXTRA_OPTS:-" -Dpulsar.allocator.exit_on_oom=true -Dio.netty.recycler.maxCapacity.default=1000 -Dio.netty.recycler.linkCapacity=1024"}
+PULSAR_EXTRA_OPTS="${PULSAR_EXTRA_OPTS:-" -Dpulsar.allocator.exit_on_oom=true -Dio.netty.recycler.maxCapacity.default=1000 -Dio.netty.recycler.linkCapacity=1024"} ${PULSAR_GC_LOG}"
Review comment:
This change seems to break `pulsar-perf` when running it in the docker container.
example failure:
```
root@e187af4bc610:/pulsar# ./bin/pulsar-perf produce
[0.000s][error][logging] Error opening log file 'logs/pulsar_gc_119.log': No such file or directory
[0.000s][error][logging] Initialization of output 'file=logs/pulsar_gc_%p.log' using options 'filecount=10,filesize=20M' failed.
Invalid -Xlog option '-Xlog:gc*:logs/pulsar_gc_%p.log:time,uptime:filecount=10,filesize=20M', see error log for details.
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-946317610
Could you check my comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-946322512
> Could you check my comments? It looks like `pulsar-client-cpp/pulsar-test-service-start.sh` cannot run successfully after this change.
@BewareMyPower Sure, I will check later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #11285: broker gc log
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #11285:
URL: https://github.com/apache/pulsar/pull/11285#issuecomment-946469100
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org