[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6762: Refactor cdn_domains, cdnnotifications, cookie, logs, ping, traffic_vault_ping tests

[GitBox <gi...@apache.org>]

ocket8888 commented on code in PR #6762:
URL: https://github.com/apache/trafficcontrol/pull/6762#discussion_r870644307


##########
traffic_ops/testing/api/v4/cdnnotifications_test.go:
##########
@@ -53,26 +80,21 @@ func CreateTestCDNNotifications(t *testing.T) {
 	var opts client.RequestOptions
 	for _, cdn := range testData.CDNs {
 		resp, _, err := TOSession.CreateCDNNotification(tc.CDNNotificationRequest{CDN: cdn.Name, Notification: "test notification: " + cdn.Name}, opts)

Review Comment:
   This creates the new test notification using `cdn.Name`, but the above check is looking for a hard-coded CDN name. The test should either consistently use the same testing data CDN name, or just use a hard-coded notification text, preferably stored as a constant value so that it can be changed in one place if need be.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org