You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Brenden Deluna <bd...@confluent.io.INVALID> on 2024/07/24 21:55:03 UTC
[VOTE] KIP-1068: New metrics for the new KafkaConsumer
Hello everyone,
I would like to start the vote on KIP-1068:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1068%3A+New+metrics+for+the+new+KafkaConsumer
This KIP introduces new metrics for the new KafkaConsumer implementation
for broader metrics coverage.
Thanks,
Brenden
Re: [VOTE] KIP-1068: New metrics for the new KafkaConsumer
Posted by PoAn Yang <pa...@apache.org>.
Hi everyone,
During the implementation of KIP-1068, we add a new metric `application-events-expired-size`.
It helps to measure how many application events are expired.
Currently, we don't add a similar metric for background events.
The only background event with a result in the form of a future is `ConsumerRebalanceListenerCallbackNeededEvent`.
Its deadline is fixed to Long.MAX_VALUE, so there will not have any expired background event.
We can add it in the future if needed.
GitHub discussion thread: https://github.com/apache/kafka/pull/17199#discussion_r1854100729
Thanks,
PoAn
On 2024/07/26 17:59:56 Bill Bejeck wrote:
> Hi Brenden,
>
> Thanks for the KIP!
>
> +1(binding)
>
> -Bill
>
> On Fri, Jul 26, 2024 at 1:54 PM Matthias J. Sax <mj...@apache.org> wrote:
>
> > Thanks for the KIP Brenden.
> >
> > +1 (binding)
> >
> > On 7/26/24 1:16 AM, Andrew Schofield wrote:
> > > HI Brenden,
> > > Thanks for the KIP.
> > >
> > > +1 (non-binding)
> > >
> > > Thanks,
> > > Andrew
> > >
> > >> On 25 Jul 2024, at 23:26, Apoorv Mittal <ap...@gmail.com>
> > wrote:
> > >>
> > >> Hi Brenden,
> > >> The metrics look good. Thanks for the KIP.
> > >>
> > >> +1 (Non-Binding)
> > >>
> > >> Regards,
> > >> Apoorv Mittal
> > >>
> > >>
> > >> On Thu, Jul 25, 2024 at 5:04 PM Philip Nee <pn...@confluent.io.invalid>
> > >> wrote:
> > >>
> > >>> Hi Brenden,
> > >>>
> > >>> Thanks for the KIP. +1 (non-binding).
> > >>>
> > >>> P
> > >>>
> > >>> On Thu, Jul 25, 2024 at 6:25 AM Lianet M. <li...@gmail.com> wrote:
> > >>>
> > >>>> Hi Brenden,
> > >>>>
> > >>>> +1 (non-binding) from me.
> > >>>>
> > >>>> Thanks for the KIP!
> > >>>>
> > >>>> Lianet
> > >>>>
> > >>>> On Thu, Jul 25, 2024 at 3:18 AM Bruno Cadonna <ca...@apache.org>
> > >>> wrote:
> > >>>>
> > >>>>> Hi Brenden,
> > >>>>>
> > >>>>> Thanks for the KIP!
> > >>>>>
> > >>>>> +1 (binding)
> > >>>>>
> > >>>>> Best,
> > >>>>> Bruno
> > >>>>>
> > >>>>> On 7/24/24 11:55 PM, Brenden Deluna wrote:
> > >>>>>> Hello everyone,
> > >>>>>>
> > >>>>>> I would like to start the vote on KIP-1068:
> > >>>>>>
> > >>>>>
> > >>>>
> > >>>
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1068%3A+New+metrics+for+the+new+KafkaConsumer
> > >>>>>>
> > >>>>>> This KIP introduces new metrics for the new KafkaConsumer
> > >>>> implementation
> > >>>>>> for broader metrics coverage.
> > >>>>>>
> > >>>>>> Thanks,
> > >>>>>> Brenden
> > >>>>>>
> > >>>>>
> > >>>>
> > >>>
> > >
> >
>
Re: [VOTE] KIP-1068: New metrics for the new KafkaConsumer
Posted by Bill Bejeck <bb...@apache.org>.
Hi Brenden,
Thanks for the KIP!
+1(binding)
-Bill
On Fri, Jul 26, 2024 at 1:54 PM Matthias J. Sax <mj...@apache.org> wrote:
> Thanks for the KIP Brenden.
>
> +1 (binding)
>
> On 7/26/24 1:16 AM, Andrew Schofield wrote:
> > HI Brenden,
> > Thanks for the KIP.
> >
> > +1 (non-binding)
> >
> > Thanks,
> > Andrew
> >
> >> On 25 Jul 2024, at 23:26, Apoorv Mittal <ap...@gmail.com>
> wrote:
> >>
> >> Hi Brenden,
> >> The metrics look good. Thanks for the KIP.
> >>
> >> +1 (Non-Binding)
> >>
> >> Regards,
> >> Apoorv Mittal
> >>
> >>
> >> On Thu, Jul 25, 2024 at 5:04 PM Philip Nee <pn...@confluent.io.invalid>
> >> wrote:
> >>
> >>> Hi Brenden,
> >>>
> >>> Thanks for the KIP. +1 (non-binding).
> >>>
> >>> P
> >>>
> >>> On Thu, Jul 25, 2024 at 6:25 AM Lianet M. <li...@gmail.com> wrote:
> >>>
> >>>> Hi Brenden,
> >>>>
> >>>> +1 (non-binding) from me.
> >>>>
> >>>> Thanks for the KIP!
> >>>>
> >>>> Lianet
> >>>>
> >>>> On Thu, Jul 25, 2024 at 3:18 AM Bruno Cadonna <ca...@apache.org>
> >>> wrote:
> >>>>
> >>>>> Hi Brenden,
> >>>>>
> >>>>> Thanks for the KIP!
> >>>>>
> >>>>> +1 (binding)
> >>>>>
> >>>>> Best,
> >>>>> Bruno
> >>>>>
> >>>>> On 7/24/24 11:55 PM, Brenden Deluna wrote:
> >>>>>> Hello everyone,
> >>>>>>
> >>>>>> I would like to start the vote on KIP-1068:
> >>>>>>
> >>>>>
> >>>>
> >>>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1068%3A+New+metrics+for+the+new+KafkaConsumer
> >>>>>>
> >>>>>> This KIP introduces new metrics for the new KafkaConsumer
> >>>> implementation
> >>>>>> for broader metrics coverage.
> >>>>>>
> >>>>>> Thanks,
> >>>>>> Brenden
> >>>>>>
> >>>>>
> >>>>
> >>>
> >
>
Re: [VOTE] KIP-1068: New metrics for the new KafkaConsumer
Posted by "Matthias J. Sax" <mj...@apache.org>.
Thanks for the KIP Brenden.
+1 (binding)
On 7/26/24 1:16 AM, Andrew Schofield wrote:
> HI Brenden,
> Thanks for the KIP.
>
> +1 (non-binding)
>
> Thanks,
> Andrew
>
>> On 25 Jul 2024, at 23:26, Apoorv Mittal <ap...@gmail.com> wrote:
>>
>> Hi Brenden,
>> The metrics look good. Thanks for the KIP.
>>
>> +1 (Non-Binding)
>>
>> Regards,
>> Apoorv Mittal
>>
>>
>> On Thu, Jul 25, 2024 at 5:04 PM Philip Nee <pn...@confluent.io.invalid>
>> wrote:
>>
>>> Hi Brenden,
>>>
>>> Thanks for the KIP. +1 (non-binding).
>>>
>>> P
>>>
>>> On Thu, Jul 25, 2024 at 6:25 AM Lianet M. <li...@gmail.com> wrote:
>>>
>>>> Hi Brenden,
>>>>
>>>> +1 (non-binding) from me.
>>>>
>>>> Thanks for the KIP!
>>>>
>>>> Lianet
>>>>
>>>> On Thu, Jul 25, 2024 at 3:18 AM Bruno Cadonna <ca...@apache.org>
>>> wrote:
>>>>
>>>>> Hi Brenden,
>>>>>
>>>>> Thanks for the KIP!
>>>>>
>>>>> +1 (binding)
>>>>>
>>>>> Best,
>>>>> Bruno
>>>>>
>>>>> On 7/24/24 11:55 PM, Brenden Deluna wrote:
>>>>>> Hello everyone,
>>>>>>
>>>>>> I would like to start the vote on KIP-1068:
>>>>>>
>>>>>
>>>>
>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1068%3A+New+metrics+for+the+new+KafkaConsumer
>>>>>>
>>>>>> This KIP introduces new metrics for the new KafkaConsumer
>>>> implementation
>>>>>> for broader metrics coverage.
>>>>>>
>>>>>> Thanks,
>>>>>> Brenden
>>>>>>
>>>>>
>>>>
>>>
>
Re: [VOTE] KIP-1068: New metrics for the new KafkaConsumer
Posted by Andrew Schofield <an...@live.com>.
HI Brenden,
Thanks for the KIP.
+1 (non-binding)
Thanks,
Andrew
> On 25 Jul 2024, at 23:26, Apoorv Mittal <ap...@gmail.com> wrote:
>
> Hi Brenden,
> The metrics look good. Thanks for the KIP.
>
> +1 (Non-Binding)
>
> Regards,
> Apoorv Mittal
>
>
> On Thu, Jul 25, 2024 at 5:04 PM Philip Nee <pn...@confluent.io.invalid>
> wrote:
>
>> Hi Brenden,
>>
>> Thanks for the KIP. +1 (non-binding).
>>
>> P
>>
>> On Thu, Jul 25, 2024 at 6:25 AM Lianet M. <li...@gmail.com> wrote:
>>
>>> Hi Brenden,
>>>
>>> +1 (non-binding) from me.
>>>
>>> Thanks for the KIP!
>>>
>>> Lianet
>>>
>>> On Thu, Jul 25, 2024 at 3:18 AM Bruno Cadonna <ca...@apache.org>
>> wrote:
>>>
>>>> Hi Brenden,
>>>>
>>>> Thanks for the KIP!
>>>>
>>>> +1 (binding)
>>>>
>>>> Best,
>>>> Bruno
>>>>
>>>> On 7/24/24 11:55 PM, Brenden Deluna wrote:
>>>>> Hello everyone,
>>>>>
>>>>> I would like to start the vote on KIP-1068:
>>>>>
>>>>
>>>
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1068%3A+New+metrics+for+the+new+KafkaConsumer
>>>>>
>>>>> This KIP introduces new metrics for the new KafkaConsumer
>>> implementation
>>>>> for broader metrics coverage.
>>>>>
>>>>> Thanks,
>>>>> Brenden
>>>>>
>>>>
>>>
>>
Re: [VOTE] KIP-1068: New metrics for the new KafkaConsumer
Posted by Apoorv Mittal <ap...@gmail.com>.
Hi Brenden,
The metrics look good. Thanks for the KIP.
+1 (Non-Binding)
Regards,
Apoorv Mittal
On Thu, Jul 25, 2024 at 5:04 PM Philip Nee <pn...@confluent.io.invalid>
wrote:
> Hi Brenden,
>
> Thanks for the KIP. +1 (non-binding).
>
> P
>
> On Thu, Jul 25, 2024 at 6:25 AM Lianet M. <li...@gmail.com> wrote:
>
> > Hi Brenden,
> >
> > +1 (non-binding) from me.
> >
> > Thanks for the KIP!
> >
> > Lianet
> >
> > On Thu, Jul 25, 2024 at 3:18 AM Bruno Cadonna <ca...@apache.org>
> wrote:
> >
> > > Hi Brenden,
> > >
> > > Thanks for the KIP!
> > >
> > > +1 (binding)
> > >
> > > Best,
> > > Bruno
> > >
> > > On 7/24/24 11:55 PM, Brenden Deluna wrote:
> > > > Hello everyone,
> > > >
> > > > I would like to start the vote on KIP-1068:
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1068%3A+New+metrics+for+the+new+KafkaConsumer
> > > >
> > > > This KIP introduces new metrics for the new KafkaConsumer
> > implementation
> > > > for broader metrics coverage.
> > > >
> > > > Thanks,
> > > > Brenden
> > > >
> > >
> >
>
Re: [VOTE] KIP-1068: New metrics for the new KafkaConsumer
Posted by Philip Nee <pn...@confluent.io.INVALID>.
Hi Brenden,
Thanks for the KIP. +1 (non-binding).
P
On Thu, Jul 25, 2024 at 6:25 AM Lianet M. <li...@gmail.com> wrote:
> Hi Brenden,
>
> +1 (non-binding) from me.
>
> Thanks for the KIP!
>
> Lianet
>
> On Thu, Jul 25, 2024 at 3:18 AM Bruno Cadonna <ca...@apache.org> wrote:
>
> > Hi Brenden,
> >
> > Thanks for the KIP!
> >
> > +1 (binding)
> >
> > Best,
> > Bruno
> >
> > On 7/24/24 11:55 PM, Brenden Deluna wrote:
> > > Hello everyone,
> > >
> > > I would like to start the vote on KIP-1068:
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1068%3A+New+metrics+for+the+new+KafkaConsumer
> > >
> > > This KIP introduces new metrics for the new KafkaConsumer
> implementation
> > > for broader metrics coverage.
> > >
> > > Thanks,
> > > Brenden
> > >
> >
>
Re: [VOTE] KIP-1068: New metrics for the new KafkaConsumer
Posted by "Lianet M." <li...@gmail.com>.
Hi Brenden,
+1 (non-binding) from me.
Thanks for the KIP!
Lianet
On Thu, Jul 25, 2024 at 3:18 AM Bruno Cadonna <ca...@apache.org> wrote:
> Hi Brenden,
>
> Thanks for the KIP!
>
> +1 (binding)
>
> Best,
> Bruno
>
> On 7/24/24 11:55 PM, Brenden Deluna wrote:
> > Hello everyone,
> >
> > I would like to start the vote on KIP-1068:
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1068%3A+New+metrics+for+the+new+KafkaConsumer
> >
> > This KIP introduces new metrics for the new KafkaConsumer implementation
> > for broader metrics coverage.
> >
> > Thanks,
> > Brenden
> >
>
Re: [VOTE] KIP-1068: New metrics for the new KafkaConsumer
Posted by Bruno Cadonna <ca...@apache.org>.
Hi Brenden,
Thanks for the KIP!
+1 (binding)
Best,
Bruno
On 7/24/24 11:55 PM, Brenden Deluna wrote:
> Hello everyone,
>
> I would like to start the vote on KIP-1068:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1068%3A+New+metrics+for+the+new+KafkaConsumer
>
> This KIP introduces new metrics for the new KafkaConsumer implementation
> for broader metrics coverage.
>
> Thanks,
> Brenden
>