You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/13 10:49:50 UTC
[GitHub] [flink] fredia opened a new pull request, #21053: [FLINK-29157][doc] Clarify the contract between CompletedCheckpointStore and SharedStateRegistry
fredia opened a new pull request, #21053:
URL: https://github.com/apache/flink/pull/21053
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Improve logging in CompletedCheckpointStore
## Verifying this change
This change is a trivial rework without any (new) test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on pull request #21053: [FLINK-29157][doc] Clarify the contract between CompletedCheckpointStore and SharedStateRegistry
Posted by GitBox <gi...@apache.org>.
fredia commented on PR #21053:
URL: https://github.com/apache/flink/pull/21053#issuecomment-1288523183
Hi @klion26, could you please take a review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 merged pull request #21053: [FLINK-29157][doc] Clarify the contract between CompletedCheckpointStore and SharedStateRegistry
Posted by GitBox <gi...@apache.org>.
klion26 merged PR #21053:
URL: https://github.com/apache/flink/pull/21053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 commented on a diff in pull request #21053: [FLINK-29157][doc] Clarify the contract between CompletedCheckpointStore and SharedStateRegistry
Posted by GitBox <gi...@apache.org>.
klion26 commented on code in PR #21053:
URL: https://github.com/apache/flink/pull/21053#discussion_r1004561770
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpointStore.java:
##########
@@ -39,6 +40,16 @@ public interface CompletedCheckpointStore {
* <p>Only a bounded number of checkpoints is kept. When exceeding the maximum number of
* retained checkpoints, the oldest one will be discarded.
*
+ * <p>After <a href="https://issues.apache.org/jira/browse/FLINK-24611">FLINK-24611</a>, {@link
+ * SharedStateRegistry#unregisterUnusedState} should be called here to subsume unused state.
+ * <font color="#FF0000"><strong>Note</strong></font>, the {@link CompletedCheckpoint} passed to
+ * {@link SharedStateRegistry#registerAllAfterRestored} or {@link
+ * SharedStateRegistryFactory#create} must be the same object as the input parameter, otherwise
+ * the state may be deleted by mistake.
+ *
+ * <p>After <a href="https://issues.apache.org/jira/browse/FLINK-24611">FLINK-25872</a>, {@link
Review Comment:
https://issues.apache.org/jira/browse/FLINK-24611 -> https://issues.apache.org/jira/browse/FLINK-25872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21053: [FLINK-29157][doc] Clarify the contract between CompletedCheckpointStore and SharedStateRegistry
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21053:
URL: https://github.com/apache/flink/pull/21053#issuecomment-1277426877
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "23d414c3f8f5a9fc14444b7ac15e651d7c149107",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "23d414c3f8f5a9fc14444b7ac15e651d7c149107",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 23d414c3f8f5a9fc14444b7ac15e651d7c149107 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on pull request #21053: [FLINK-29157][doc] Clarify the contract between CompletedCheckpointStore and SharedStateRegistry
Posted by GitBox <gi...@apache.org>.
fredia commented on PR #21053:
URL: https://github.com/apache/flink/pull/21053#issuecomment-1292888602
Thanks a lot for reviewing. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] masteryhx commented on a diff in pull request #21053: [FLINK-29157][doc] Clarify the contract between CompletedCheckpointStore and SharedStateRegistry
Posted by GitBox <gi...@apache.org>.
masteryhx commented on code in PR #21053:
URL: https://github.com/apache/flink/pull/21053#discussion_r996601693
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpointStore.java:
##########
@@ -39,6 +41,15 @@ public interface CompletedCheckpointStore {
* <p>Only a bounded number of checkpoints is kept. When exceeding the maximum number of
* retained checkpoints, the oldest one will be discarded.
*
+ * <p>After <a href="https://issues.apache.org/jira/browse/FLINK-24611">FLINK-24611</a>, {@link
+ * SharedStateRegistry#unregisterUnusedState} should be called here to subsume unused state.
+ * <font color="#FF0000"><strong>Note</strong></font>, the {@link CompletedCheckpoint} passed to
+ * SharedStateRegistry must be the same object as the input parameter, otherwise the state may
Review Comment:
IIUC, the fallible place is SharedStateRegistryFactory#create where the same object should be passed.
So maybe specify it here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org