[GitHub] [druid] mghosh4 commented on a change in pull request #10373: Adding more dimensions to the audit log entry

[GitBox <gi...@apache.org>]

mghosh4 commented on a change in pull request #10373:
URL: https://github.com/apache/druid/pull/10373#discussion_r486618678



##########
File path: server/src/main/java/org/apache/druid/server/audit/SQLAuditManager.java
##########
@@ -98,6 +98,10 @@ public void doAudit(AuditEntry auditEntry, Handle handle) throws IOException
             .setDimension("key", auditEntry.getKey())
             .setDimension("type", auditEntry.getType())
             .setDimension("author", auditEntry.getAuditInfo().getAuthor())
+            .setDimension("comment", auditEntry.getAuditInfo().getComment())
+            .setDimension("remote_address", auditEntry.getAuditInfo().getIp())
+            .setDimension("created_date", auditEntry.getAuditTime().toString())
+            .setDimension("payload", auditEntry.getPayload())

Review comment:
       Typically `comment` tends to have the business reason for doing the change. So it is useful for auditing. I am on the fence about `payload`. I wasn't sure whether it has any extra information not covered by the other columns. So decided to add that one. I can remove it if that is not the case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org