You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2011/07/04 17:30:22 UTC

[jira] [Commented] (WICKET-3867) URIs should be used instead of URLs as Set or Map keys.

    [ https://issues.apache.org/jira/browse/WICKET-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059482#comment-13059482 ] 

Martin Grigorov commented on WICKET-3867:
-----------------------------------------

I'm not sure whether we need the API break here.
We can collect the URIs in the Set and return their .toURL() representation in #getResources().

> URIs should be used instead of URLs as Set or Map keys.
> -------------------------------------------------------
>
>                 Key: WICKET-3867
>                 URL: https://issues.apache.org/jira/browse/WICKET-3867
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC5.1
>            Reporter: Bertrand Guay-Paquet
>              Labels: classloader, url
>         Attachments: WICKET-3867-patch.patch
>
>
> URLs are not suitable for use as Set or Map keys because their equals() and hashCode() methods are not well defined. URIs should be used to identify the location and URLs to access the actual resources.
> See thread for http://mail-archives.apache.org/mod_mbox/wicket-users/201107.mbox/%3CCAPdiUN6CaH9rn4+tD9_hXP-dmBGn-SvFu=RvCMh8AYx5_1JkkA@mail.gmail.com%3E
> Specifically:
> [1] "More Joy of Sets" example with URL from Google Tech Talks:
> http://www.youtube.com/watch?v=wDN_EYUvUq0#t=9m58s

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira