You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/03 17:50:24 UTC
[GitHub] [kafka] tombentley opened a new pull request #9552: KAFKA-10656: Log the feature flags received by the client
tombentley opened a new pull request #9552:
URL: https://github.com/apache/kafka/pull/9552
Example log line:
[2020-11-03 17:47:17,076] DEBUG Node 0 has finalizedFeaturesEpoch: 42, finalizedFeatures: [FinalizedFeatureKey(name='feature_1', maxVersionLevel=2, minVersionLevel=1), FinalizedFeatureKey(name='feature_2', maxVersionLevel=4, minVersionLevel=3)], supportedFeatures: [SupportedFeatureKey(name='feature_1', minVersion=1, maxVersion=2), SupportedFeatureKey(name='feature_2', minVersion=3, maxVersion=4)] (org.apache.kafka.clients.NetworkClient:926)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tombentley commented on a change in pull request #9552: KAFKA-10656: Log the feature flags received by the client
Posted by GitBox <gi...@apache.org>.
tombentley commented on a change in pull request #9552:
URL: https://github.com/apache/kafka/pull/9552#discussion_r543183384
##########
File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
##########
@@ -917,7 +917,10 @@ private void handleApiVersionsResponse(List<ClientResponse> responses,
NodeApiVersions nodeVersionInfo = new NodeApiVersions(apiVersionsResponse.data.apiKeys());
apiVersions.update(node, nodeVersionInfo);
this.connectionStates.ready(node);
- log.debug("Recorded API versions for node {}: {}", node, nodeVersionInfo);
+ log.debug("Node {} has finalized features epoch: {}, finalized features: {}, supported features: {}, API versions: {}.",
+ node,
Review comment:
@chia7712 yeah, sorry about that, now done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #9552: KAFKA-10656: Log the feature flags received by the client
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #9552:
URL: https://github.com/apache/kafka/pull/9552#discussion_r542205763
##########
File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
##########
@@ -923,6 +923,10 @@ private void handleApiVersionsResponse(List<ClientResponse> responses,
apiVersions.update(node, nodeVersionInfo);
this.connectionStates.ready(node);
log.debug("Recorded API versions for node {}: {}", node, nodeVersionInfo);
Review comment:
How about merging this message with new one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #9552: KAFKA-10656: Log the feature flags received by the client
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #9552:
URL: https://github.com/apache/kafka/pull/9552#discussion_r543003347
##########
File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
##########
@@ -917,7 +917,10 @@ private void handleApiVersionsResponse(List<ClientResponse> responses,
NodeApiVersions nodeVersionInfo = new NodeApiVersions(apiVersionsResponse.data.apiKeys());
apiVersions.update(node, nodeVersionInfo);
this.connectionStates.ready(node);
- log.debug("Recorded API versions for node {}: {}", node, nodeVersionInfo);
+ log.debug("Node {} has finalized features epoch: {}, finalized features: {}, supported features: {}, API versions: {}.",
+ node,
Review comment:
It is just a style issue. Could we merge line#921 and line#922?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tombentley commented on pull request #9552: KAFKA-10656: Log the feature flags received by the client
Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #9552:
URL: https://github.com/apache/kafka/pull/9552#issuecomment-744306313
@chia7712 thanks for taking a look, merged the two lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 merged pull request #9552: KAFKA-10656: Log the feature flags received by the client
Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #9552:
URL: https://github.com/apache/kafka/pull/9552
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tombentley commented on pull request #9552: KAFKA-10656: Log the feature flags received by the client
Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #9552:
URL: https://github.com/apache/kafka/pull/9552#issuecomment-746347168
https://github.com/apache/kafka/pull/9759
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9552: KAFKA-10656: Log the feature flags received by the client
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9552:
URL: https://github.com/apache/kafka/pull/9552#issuecomment-746336775
@tombentley https://github.com/apache/kafka/commit/1a10c3445e157da1d2fd670c043f19c385465eb0 changes the access modifier of "data" so this PR breaks the build. Could you file a hot fix for it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tombentley commented on pull request #9552: KAFKA-10656: Log the feature flags received by the client
Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #9552:
URL: https://github.com/apache/kafka/pull/9552#issuecomment-746338918
@chia7712 I'll get right on it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tombentley commented on pull request #9552: KAFKA-10656: Log the feature flags received by the client
Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #9552:
URL: https://github.com/apache/kafka/pull/9552#issuecomment-721283218
@cmccabe could you review this, since you opened the JIRA? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9552: KAFKA-10656: Log the feature flags received by the client
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9552:
URL: https://github.com/apache/kafka/pull/9552#issuecomment-745297828
@cmccabe I will merge it tomorrow and it would be helpful if you could give a review :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org