You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2020/10/21 14:18:14 UTC
[GitHub] [fluo-muchos] karthick-rn opened a new pull request #379: Bump Grafana & Influxdb versions
karthick-rn opened a new pull request #379:
URL: https://github.com/apache/fluo-muchos/pull/379
Addresses #378
* Modify Influxdb & Grafana RPM URLs
* Retain existing configurations in grafana.ini & influxdb.conf files along with other defaults
* Enable GPG check for Influxdb install on CentOS 8
For the record, I have tested the changes against CentOS 7 & 8 with Java 8 & 11, the setup ran successfully for all the combinations & able to see the dashboards on Grafana.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] karthick-rn commented on a change in pull request #379: Bump Grafana & Influxdb versions
Posted by GitBox <gi...@apache.org>.
karthick-rn commented on a change in pull request #379:
URL: https://github.com/apache/fluo-muchos/pull/379#discussion_r509554209
##########
File path: ansible/roles/grafana/handlers/main.yml
##########
@@ -21,11 +21,11 @@
method: POST
body: "{{ item }}"
body_format: json
- status_code: 200,500
+ status_code: 200,500,409
Review comment:
Added 409 to avoid task failing when the datasource already exist in Grafana.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] karthick-rn commented on a change in pull request #379: Bump Grafana & Influxdb versions
Posted by GitBox <gi...@apache.org>.
karthick-rn commented on a change in pull request #379:
URL: https://github.com/apache/fluo-muchos/pull/379#discussion_r509543662
##########
File path: ansible/roles/grafana/files/grafana-default.ini
##########
@@ -0,0 +1,816 @@
+##################### Grafana Configuration Example #####################
Review comment:
Yes, I added `grafana-default.ini` to adopt the style used in the existing `influxdb` roles that had the default config file under `influxdb/files` directory. I'll go-ahead and remove the `files` directory from both `grafana` & `influxdb`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] karthick-rn commented on a change in pull request #379: Bump Grafana & Influxdb versions
Posted by GitBox <gi...@apache.org>.
karthick-rn commented on a change in pull request #379:
URL: https://github.com/apache/fluo-muchos/pull/379#discussion_r509556481
##########
File path: ansible/roles/influxdb/defaults/main.yml
##########
@@ -15,5 +15,5 @@
# limitations under the License.
#
-influxdb_rpm: influxdb-0.9.4.2-1.x86_64.rpm
-influxdb_checksum: "sha256:9a2b6cfdf70e0050a46d07cc0f4135a7538eaac1a3c1745d860d454179f771fb"
+influxdb_rpm: influxdb-1.8.3.x86_64.rpm
+influxdb_checksum: "sha256:74c606e2da6d33b193bc6224afb552b09567c7e1a31fee4e51ff48550f59a7cc"
Review comment:
I checked just now and they do have SHA-512. I'll run a quick test with the new hash and update the PR. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] karthick-rn merged pull request #379: Bump Grafana & Influxdb versions
Posted by GitBox <gi...@apache.org>.
karthick-rn merged pull request #379:
URL: https://github.com/apache/fluo-muchos/pull/379
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] karthick-rn commented on a change in pull request #379: Bump Grafana & Influxdb versions
Posted by GitBox <gi...@apache.org>.
karthick-rn commented on a change in pull request #379:
URL: https://github.com/apache/fluo-muchos/pull/379#discussion_r509589636
##########
File path: ansible/roles/grafana/files/grafana-default.ini
##########
@@ -0,0 +1,816 @@
+##################### Grafana Configuration Example #####################
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on a change in pull request #379: Bump Grafana & Influxdb versions
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on a change in pull request #379:
URL: https://github.com/apache/fluo-muchos/pull/379#discussion_r509495227
##########
File path: ansible/roles/grafana/handlers/main.yml
##########
@@ -21,11 +21,11 @@
method: POST
body: "{{ item }}"
body_format: json
- status_code: 200,500
+ status_code: 200,500,409
Review comment:
Curious - why is this needed? HTTP 409 seems to be something to do with conflicts; it would be good to have an understanding of why you added this.
##########
File path: ansible/roles/influxdb/defaults/main.yml
##########
@@ -15,5 +15,5 @@
# limitations under the License.
#
-influxdb_rpm: influxdb-0.9.4.2-1.x86_64.rpm
-influxdb_checksum: "sha256:9a2b6cfdf70e0050a46d07cc0f4135a7538eaac1a3c1745d860d454179f771fb"
+influxdb_rpm: influxdb-1.8.3.x86_64.rpm
+influxdb_checksum: "sha256:74c606e2da6d33b193bc6224afb552b09567c7e1a31fee4e51ff48550f59a7cc"
Review comment:
Do they have SHA-512 hashes published? If so, we should use those.
##########
File path: ansible/roles/grafana/files/grafana-default.ini
##########
@@ -0,0 +1,816 @@
+##################### Grafana Configuration Example #####################
Review comment:
Can we eliminate any "reference-only" files like this one `grafana-default.ini` - it seems to be unused by any actual task?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] karthick-rn commented on a change in pull request #379: Bump Grafana & Influxdb versions
Posted by GitBox <gi...@apache.org>.
karthick-rn commented on a change in pull request #379:
URL: https://github.com/apache/fluo-muchos/pull/379#discussion_r509589971
##########
File path: ansible/roles/influxdb/defaults/main.yml
##########
@@ -15,5 +15,5 @@
# limitations under the License.
#
-influxdb_rpm: influxdb-0.9.4.2-1.x86_64.rpm
-influxdb_checksum: "sha256:9a2b6cfdf70e0050a46d07cc0f4135a7538eaac1a3c1745d860d454179f771fb"
+influxdb_rpm: influxdb-1.8.3.x86_64.rpm
+influxdb_checksum: "sha256:74c606e2da6d33b193bc6224afb552b09567c7e1a31fee4e51ff48550f59a7cc"
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] karthick-rn commented on a change in pull request #379: Bump Grafana & Influxdb versions
Posted by GitBox <gi...@apache.org>.
karthick-rn commented on a change in pull request #379:
URL: https://github.com/apache/fluo-muchos/pull/379#discussion_r509543662
##########
File path: ansible/roles/grafana/files/grafana-default.ini
##########
@@ -0,0 +1,816 @@
+##################### Grafana Configuration Example #####################
Review comment:
Yes, I added `grafana-default.ini` to adopt the style used in the existing `influxdb` roles that had the default config file under `influxdb/files` directory. I'll go-ahead and remove `grafana-default.ini` & also `influxdb/files/influxdb-1.8.3-defaults.conf` - both not used in any tasks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org