You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jing Ge (Jira)" <ji...@apache.org> on 2022/02/16 10:49:00 UTC
[jira] [Updated] (FLINK-26186) update the API_ANNOTATIONS rule

     [ https://issues.apache.org/jira/browse/FLINK-26186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jing Ge updated FLINK-26186:
----------------------------
    Description: 
It seems that the excluding shaded classes filter does not work in this case since the check is against a valid class whose return type is a shaded external class which somehow was not handled by the filter.  For example, please refer to FLINK-26174.

Since there is no way to add Flink API annotation to the 3rd party classes, the rule should be updated.

 

the main ideas is to extend the rule allow external classes without Flink API annotation, like:

 

.or(

        {_}resideInAnyPackage{_}(

                "org.apache.flink.(*)..shaded.(**)"))

  was:
It seems that the excluding shaded classes filter does not work in this case since the check is against a valid class whose return type is a shaded external class which somehow was not handled by the filter. 

Since there is no way to add Flink API annotation to the 3rd party classes, the rule should be updated.

 

the main ideas is to extend the rule allow external classes without Flink API annotation, like:

 

.or(

        {_}resideInAnyPackage{_}(

                "org.apache.flink.(*)..shaded.(**)"))


> update the API_ANNOTATIONS rule
> -------------------------------
>
>                 Key: FLINK-26186
>                 URL: https://issues.apache.org/jira/browse/FLINK-26186
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Jing Ge
>            Assignee: Jing Ge
>            Priority: Major
>
> It seems that the excluding shaded classes filter does not work in this case since the check is against a valid class whose return type is a shaded external class which somehow was not handled by the filter.  For example, please refer to FLINK-26174.
> Since there is no way to add Flink API annotation to the 3rd party classes, the rule should be updated.
>  
> the main ideas is to extend the rule allow external classes without Flink API annotation, like:
>  
> .or(
>         {_}resideInAnyPackage{_}(
>                 "org.apache.flink.(*)..shaded.(**)"))



--
This message was sent by Atlassian Jira
(v8.20.1#820001)