[GitHub] gigasquid opened a new issue #13453: [Clojure] - Add Spec Validations to the Optimizer namespace

[GitBox <gi...@apache.org>]

gigasquid opened a new issue #13453: [Clojure] - Add Spec Validations to the Optimizer namespace
URL: https://github.com/apache/incubator-mxnet/issues/13453
 
 
   It would be nice to add some spec validations to the optimizer namespace https://github.com/apache/incubator-mxnet/blob/master/contrib/clojure-package/src/org/apache/clojure_mxnet/optimizer.clj
   
   So that if a user calls a function with the incorrect arguments, it will guide them to the correct form.
   
   Using the util/validate function as in https://github.com/apache/incubator-mxnet/blob/master/contrib/clojure-package/src/org/apache/clojure_mxnet/module.clj#L186 and the correct specs would be a great addition to the project.
   
   Addition of unit tests to test a failing case of the spec that an exception is thrown would be great too :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services