You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "nitheesh-daram (via GitHub)" <gi...@apache.org> on 2023/05/21 17:12:48 UTC

[GitHub] [eventmesh] nitheesh-daram opened a new pull request, #3993: [ISSUE #3958 ]

nitheesh-daram opened a new pull request, #3993:
URL: https://github.com/apache/eventmesh/pull/3993

   This PR Resolves #3958
   
   ### Documentation
   
   - Does this pull request introduce a new feature? (yes / no)
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   - If a feature is not applicable for documentation, explain why?
   - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [eventmesh] nitheesh-daram commented on pull request #3993: [ISSUE #3958 ] Code optimization.[HTTPClientHandler]

Posted by "nitheesh-daram (via GitHub)" <gi...@apache.org>.
nitheesh-daram commented on PR #3993:
URL: https://github.com/apache/eventmesh/pull/3993#issuecomment-1558628403

   > ![image](https://user-images.githubusercontent.com/91315508/240148411-a0266f68-9ed6-49e1-9629-768219f71d3a.png) please check checkstyle.
   
   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] Alonexc commented on pull request #3993: [ISSUE #3958 ] Code optimization.[HTTPClientHandler]

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #3993:
URL: https://github.com/apache/eventmesh/pull/3993#issuecomment-1558584740

   ![image](https://github.com/apache/eventmesh/assets/91315508/a0266f68-9ed6-49e1-9629-768219f71d3a)
   please check checkstyle.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] codecov[bot] commented on pull request #3993: [ISSUE #3958 ] Code optimization.[HTTPClientHandler]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3993:
URL: https://github.com/apache/eventmesh/pull/3993#issuecomment-1560675807

   ## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3993?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#3993](https://app.codecov.io/gh/apache/eventmesh/pull/3993?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3ec08ec) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/1798e1f9b5cc212ec75425325bdfb3d1502a4ab5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1798e1f) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0.00%`.
   
   > :exclamation: Current head 3ec08ec differs from pull request most recent head 07dfa9f. Consider uploading reports for the commit 07dfa9f to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3993      +/-   ##
   ============================================
   - Coverage     14.24%   14.24%   -0.01%     
   - Complexity     1320     1321       +1     
   ============================================
     Files           579      579              
     Lines         28958    28953       -5     
     Branches       2815     2799      -16     
   ============================================
   - Hits           4125     4123       -2     
   + Misses        24441    24440       -1     
   + Partials        392      390       -2     
   ```
   
   
   | [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3993?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...tmesh/runtime/admin/handler/HTTPClientHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3993?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvSFRUUENsaWVudEhhbmRsZXIuamF2YQ==) | `4.87% <0.00%> (-0.13%)` | :arrow_down: |
   | [...ventmesh/runtime/constants/EventMeshConstants.java](https://app.codecov.io/gh/apache/eventmesh/pull/3993?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvbnN0YW50cy9FdmVudE1lc2hDb25zdGFudHMuamF2YQ==) | `0.00% <ø> (ø)` | |
   
   ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3993/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] xwm1992 commented on pull request #3993: [ISSUE #3958 ] Code optimization.[HTTPClientHandler]

Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on PR #3993:
URL: https://github.com/apache/eventmesh/pull/3993#issuecomment-1561106130

   @nitheesh-daram please solve the conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] nitheesh-daram commented on pull request #3993: [ISSUE #3958 ] Code optimization.[HTTPClientHandler]

Posted by "nitheesh-daram (via GitHub)" <gi...@apache.org>.
nitheesh-daram commented on PR #3993:
URL: https://github.com/apache/eventmesh/pull/3993#issuecomment-1561117076

   > @nitheesh-daram please solve the conflicts.
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] xwm1992 merged pull request #3993: [ISSUE #3958 ] Code optimization.[HTTPClientHandler]

Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3993:
URL: https://github.com/apache/eventmesh/pull/3993


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org