[GitHub] [kylin] zhangayqian commented on a change in pull request #1704: KYLIN-5053 Update the website to link to TravisCI and Github Actions instead of Jenkins

[GitBox <gi...@apache.org>]

zhangayqian commented on a change in pull request #1704:
URL: https://github.com/apache/kylin/pull/1704#discussion_r679029625



##########
File path: website/README.md
##########
@@ -55,10 +56,10 @@ Before opening a pull request or push to git repo, you can preview changes from
 
 ## Pushing to site (for committer only)  
 1. `cd website/_site`
-2. `svn status`
-3. You'll need to `svn add` any new files
-4. `svn commit -m 'UPDATE MESSAGE'`
+2. `git status`
+3. You'll need to `git add` any new files
+4. `git commit -m 'UPDATE MESSAGE'`
 
-Within a few minutes, svnpubsub should kick in and you'll be able to
+Within a few minutes, gitpubsub should kick in and you'll be able to
 see the results at
-[http://kylin.apache.org](http://kylin.apache.org/).
\ No newline at end of file
+[https://kylin.apache.org](https://kylin.apache.org/).

Review comment:
       Hi @martin-g. The apache kylin official website protocol is indeed `http` rather than `https`.

##########
File path: website/README.md
##########
@@ -55,10 +56,10 @@ Before opening a pull request or push to git repo, you can preview changes from
 
 ## Pushing to site (for committer only)  
 1. `cd website/_site`
-2. `svn status`
-3. You'll need to `svn add` any new files
-4. `svn commit -m 'UPDATE MESSAGE'`
+2. `git status`
+3. You'll need to `git add` any new files
+4. `git commit -m 'UPDATE MESSAGE'`
 
-Within a few minutes, svnpubsub should kick in and you'll be able to
+Within a few minutes, gitpubsub should kick in and you'll be able to

Review comment:
       Hi @martin-g , If you only use `git` to update the website content to the `https://github.com/apache/kylin`, you cannot directly update the kylin website. Because the code of kylin website is actually placed in SVN, and GitHub repo is just a transit station, it still needs to be updated to SVN in order to really update the `http://kylin.apache.org/`, so I don't think this part of the document content needs to be changed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org