You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Matthew Jacobs (Code Review)" <ge...@cloudera.org> on 2017/04/04 20:40:24 UTC
[Impala-ASF-CR] IMPALA-5156: Drop VLOG level passed into Kudu client
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6549
Change subject: IMPALA-5156: Drop VLOG level passed into Kudu client
......................................................................
IMPALA-5156: Drop VLOG level passed into Kudu client
The Kudu logging is very verbose and all of the logging may
affect performance. This change reduces the Kudu client log
level to v-1, since Impala is typically run at v=1 and isn't
too noisy.
In some simple concurrency testing, Todd found that reducing
the vlog level resulted in an increase in throughput from
~17 qps to 60qps.
Change-Id: I6f160e20de37ac13887ccfebc5fb1d595fd05db1
---
M be/src/exec/kudu-util.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/6549/1
--
To view, visit http://gerrit.cloudera.org:8080/6549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f160e20de37ac13887ccfebc5fb1d595fd05db1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-5156: Drop VLOG level passed into Kudu client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5156: Drop VLOG level passed into Kudu client
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/437/
--
To view, visit http://gerrit.cloudera.org:8080/6549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f160e20de37ac13887ccfebc5fb1d595fd05db1
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5156: Drop VLOG level passed into Kudu client
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5156: Drop VLOG level passed into Kudu client
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f160e20de37ac13887ccfebc5fb1d595fd05db1
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5156: Drop VLOG level passed into Kudu client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5156: Drop VLOG level passed into Kudu client
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f160e20de37ac13887ccfebc5fb1d595fd05db1
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5156: Drop VLOG level passed into Kudu client
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6549
to look at the new patch set (#2).
Change subject: IMPALA-5156: Drop VLOG level passed into Kudu client
......................................................................
IMPALA-5156: Drop VLOG level passed into Kudu client
The Kudu logging is very verbose and all of the logging may
affect performance. This change reduces the Kudu client log
level to v-1, since Impala is typically run at v=1 and isn't
too noisy.
In some simple concurrency testing, Todd found that reducing
the vlog level resulted in an increase in throughput from
~17 qps to 60qps.
Change-Id: I6f160e20de37ac13887ccfebc5fb1d595fd05db1
---
M be/src/exec/kudu-util.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/6549/2
--
To view, visit http://gerrit.cloudera.org:8080/6549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f160e20de37ac13887ccfebc5fb1d595fd05db1
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-5156: Drop VLOG level passed into Kudu client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5156: Drop VLOG level passed into Kudu client
......................................................................
IMPALA-5156: Drop VLOG level passed into Kudu client
The Kudu logging is very verbose and all of the logging may
affect performance. This change reduces the Kudu client log
level to v-1, since Impala is typically run at v=1 and isn't
too noisy.
In some simple concurrency testing, Todd found that reducing
the vlog level resulted in an increase in throughput from
~17 qps to 60qps.
Change-Id: I6f160e20de37ac13887ccfebc5fb1d595fd05db1
Reviewed-on: http://gerrit.cloudera.org:8080/6549
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exec/kudu-util.cc
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Matthew Jacobs: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f160e20de37ac13887ccfebc5fb1d595fd05db1
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-5156: Drop VLOG level passed into Kudu client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5156: Drop VLOG level passed into Kudu client
......................................................................
Patch Set 3:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/438/
--
To view, visit http://gerrit.cloudera.org:8080/6549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f160e20de37ac13887ccfebc5fb1d595fd05db1
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5156: Drop VLOG level passed into Kudu client
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5156: Drop VLOG level passed into Kudu client
......................................................................
Patch Set 3: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/6549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f160e20de37ac13887ccfebc5fb1d595fd05db1
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5156: Drop VLOG level passed into Kudu client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5156: Drop VLOG level passed into Kudu client
......................................................................
Patch Set 2: Verified-1
Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/437/
--
To view, visit http://gerrit.cloudera.org:8080/6549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f160e20de37ac13887ccfebc5fb1d595fd05db1
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5156: Drop VLOG level passed into Kudu client
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5156: Drop VLOG level passed into Kudu client
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6549/1/be/src/exec/kudu-util.cc
File be/src/exec/kudu-util.cc:
PS1, Line 105: std::max
#include <algorithm>. Add a comment?
--
To view, visit http://gerrit.cloudera.org:8080/6549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f160e20de37ac13887ccfebc5fb1d595fd05db1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes