You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Dave Brondsema <da...@brondsema.net> on 2018/03/08 19:24:25 UTC
[allura:tickets] #8194 Persist the list of commits on Merge requests
---
** [tickets:#8194] Persist the list of commits on Merge requests**
**Status:** in-progress
**Milestone:** unreleased
**Created:** Thu Mar 08, 2018 07:24 PM UTC by Dave Brondsema
**Last Updated:** Thu Mar 08, 2018 07:24 PM UTC
**Owner:** Dave Brondsema
This will provide a performance improvement over running `merge_request_commits` every time the page is viewed. It will also allow a merge request to continue to show its list of commits after it has been merged. (Currently they will show no commits, since the downstream fork has nothing new relative to the upstream primary)
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8194 Persist the list of commits on Merge requests
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: in-progress --> review
- **Comment**:
db/8194
* make sure to restart taskd, so it gets the code changes
* test as a project admin, which as a one-click merge button, and thus more code runs to check mergability
* the cached list of commits won't update if there are new commits upstream (origin) e.g. if a single commit was cherry-picked, or if there was some branch with shared commits that got merged. I think that is ok though, since it keeps thing simpler, and is not really a big problem if it does happen. Moreover, if we did update the list of commits, it would go to 0 after the merge request got merged, which is what we're trying to avoid :)
---
** [tickets:#8194] Persist the list of commits on Merge requests**
**Status:** review
**Milestone:** unreleased
**Created:** Thu Mar 08, 2018 07:24 PM UTC by Dave Brondsema
**Last Updated:** Thu Mar 08, 2018 07:24 PM UTC
**Owner:** Dave Brondsema
This will provide a performance improvement over running `merge_request_commits` every time the page is viewed. It will also allow a merge request to continue to show its list of commits after it has been merged. (Currently they will show no commits, since the downstream fork has nothing new relative to the upstream primary)
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8194 Persist the list of commits on Merge requests
Posted by Kenton Taylor <kt...@slashdotmedia.com>.
- **status**: review --> closed
- **Comment**:
Merged.
---
** [tickets:#8194] Persist the list of commits on Merge requests**
**Status:** closed
**Milestone:** unreleased
**Created:** Thu Mar 08, 2018 07:24 PM UTC by Dave Brondsema
**Last Updated:** Fri Mar 09, 2018 05:33 PM UTC
**Owner:** Dave Brondsema
This will provide a performance improvement over running `merge_request_commits` every time the page is viewed. It will also allow a merge request to continue to show its list of commits after it has been merged. (Currently they will show no commits, since the downstream fork has nothing new relative to the upstream primary)
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.