You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/19 09:29:19 UTC

[GitHub] [shardingsphere] tuichenchuxin opened a new issue #13138: support parsing SHOW REPLICA STATUS for mysql

tuichenchuxin opened a new issue #13138:
URL: https://github.com/apache/shardingsphere/issues/13138


   Hi community,
   
   This issue can be a good first try.
   
   ## Aim
   support parse mysql administration statements sql `SHOW REPLICA STATUS`
   
   ## Basic Qualifications
   - java
   - maven
   - antlr4
   
   ## Detail
   Add antlr rule in DALStatement.g4. refer to https://dev.mysql.com/doc/refman/8.0/en/show-replicas.html
   Implement the visit method in `shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/impl/MySQLDALStatementSQLVisitor.java`
   To complete this issue, I think we should complete these steps:
   - Create anltr rule in DALStatement.g4
   - Create `MySQLShowReplicaStatusStatement` class in this package `org.apache.shardingsphere.sql.parser.sql.dialect.statement.mysql.dal`
   - Add rule in `shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/database/visitor/SQLVisitorRule.java`
   - Implement the visit method in `shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/impl/MySQLDALStatementSQLVisitor.java`. 
   - Finally, add test for parse clone statement in `shardingsphere-test` module
   ## Example FYI
   - Refer to this merged pr:https://github.com/apache/shardingsphere/pull/12979/files


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tuichenchuxin commented on issue #13138: support parsing SHOW REPLICA STATUS for mysql

Posted by GitBox <gi...@apache.org>.
tuichenchuxin commented on issue #13138:
URL: https://github.com/apache/shardingsphere/issues/13138#issuecomment-966743888


   @flycash I saw this in document 
   https://dev.mysql.com/doc/refman/8.0/en/show-slave-status.html
   I think we should support both.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] flycash commented on issue #13138: support parsing SHOW REPLICA STATUS for mysql

Posted by GitBox <gi...@apache.org>.
flycash commented on issue #13138:
URL: https://github.com/apache/shardingsphere/issues/13138#issuecomment-966325985


   Only support `SHOW REPLICA STATUS`?
   MySQL 5.7 has no `SHOW REPLICA STATUS` but have `SHOW SLAVE STATUS`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] strongduanmu closed issue #13138: support parsing SHOW REPLICA STATUS for mysql

Posted by GitBox <gi...@apache.org>.
strongduanmu closed issue #13138:
URL: https://github.com/apache/shardingsphere/issues/13138


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] flycash commented on issue #13138: support parsing SHOW REPLICA STATUS for mysql

Posted by GitBox <gi...@apache.org>.
flycash commented on issue #13138:
URL: https://github.com/apache/shardingsphere/issues/13138#issuecomment-967095810


   ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org