You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/31 08:47:10 UTC

[GitHub] [pulsar] gaozhangmin removed a comment on pull request #14949: [fix][broker] Fix creating system namespace topic failure.

gaozhangmin removed a comment on pull request #14949:
URL: https://github.com/apache/pulsar/pull/14949#issuecomment-1084275271


   > https://github.com/apache/pulsar/blob/ca436a96f0ab1ba7c9af4e613d2bf844a2c315e6/pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionLogImpl.java#L61
   > 
   > https://github.com/apache/pulsar/blob/ca436a96f0ab1ba7c9af4e613d2bf844a2c315e6/pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStore.java#L64
   > 
   > https://github.com/apache/pulsar/blob/ca436a96f0ab1ba7c9af4e613d2bf844a2c315e6/pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java#L66
   > 
   > 
   > these three topic can't be created to persistent topic, so I think we don't use `isSystemTopic()` directly
   
   @congbobo184  We should update `isSystemTopic`  method then.  `PENDING_ACK_STORE_SUFFIX ` is supported now, I think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org