You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2018/08/16 23:18:18 UTC
Review Request 68396: Updated the ::pipe() system calls to pipe2 in
posix subprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68396/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin Mahler, Jie Yu, James Peach, and Qian Zhang.
Bugs: MESOS-9151
https://issues.apache.org/jira/browse/MESOS-9151
Repository: mesos
Description
-------
Updated the ::pipe() system calls to pipe2 in posix subprocess.
Diffs
-----
3rdparty/libprocess/src/posix/subprocess.cpp 01e3272fccda6ff66e1629fb10d22d8c4967b22a
Diff: https://reviews.apache.org/r/68396/diff/1/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 68396: Updated the ::pipe() system calls to pipe2
in posix subprocess.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68396/
-----------------------------------------------------------
(Updated Aug. 20, 2018, 2:37 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin Mahler, Jie Yu, James Peach, and Qian Zhang.
Changes
-------
Rebased.
Repository: mesos
Description
-------
Updated the ::pipe() system calls to pipe2 in posix subprocess.
Diffs (updated)
-----
3rdparty/libprocess/src/posix/subprocess.cpp 01e3272fccda6ff66e1629fb10d22d8c4967b22a
Diff: https://reviews.apache.org/r/68396/diff/2/
Changes: https://reviews.apache.org/r/68396/diff/1-2/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 68396: Updated the ::pipe() system calls to pipe2
in posix subprocess.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68396/#review207629
-----------------------------------------------------------
3rdparty/libprocess/src/posix/subprocess.cpp
Line 66 (original), 68 (patched)
<https://reviews.apache.org/r/68396/#comment291075>
Oh that's a lot cleaner than `.get()[0]`... gotta go fix Windows now. Though you can replace the declaration + assignments with just:
`return OutputFileDescriptors{pipefd->at(0), pipefd->at(1)};` and then (after I use `at`) it'll look just like windows/subprocess.cpp!
Actually... it would end up identical save for the arguments sent to `os::pipe`. Time for some consolidation?
- Andrew Schwartzmeyer
On Aug. 17, 2018, 3:36 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68396/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 3:36 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin Mahler, Jie Yu, James Peach, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the ::pipe() system calls to pipe2 in posix subprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/posix/subprocess.cpp 01e3272fccda6ff66e1629fb10d22d8c4967b22a
>
>
> Diff: https://reviews.apache.org/r/68396/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 68396: Updated the ::pipe() system calls to pipe2
in posix subprocess.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68396/
-----------------------------------------------------------
(Updated Aug. 17, 2018, 3:36 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin Mahler, Jie Yu, James Peach, and Qian Zhang.
Repository: mesos
Description
-------
Updated the ::pipe() system calls to pipe2 in posix subprocess.
Diffs
-----
3rdparty/libprocess/src/posix/subprocess.cpp 01e3272fccda6ff66e1629fb10d22d8c4967b22a
Diff: https://reviews.apache.org/r/68396/diff/1/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 68396: Updated the ::pipe() system calls to pipe2
in posix subprocess.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68396/#review207453
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 16, 2018, 11:18 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68396/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2018, 11:18 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin Mahler, Jie Yu, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9151
> https://issues.apache.org/jira/browse/MESOS-9151
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the ::pipe() system calls to pipe2 in posix subprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/posix/subprocess.cpp 01e3272fccda6ff66e1629fb10d22d8c4967b22a
>
>
> Diff: https://reviews.apache.org/r/68396/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 68396: Updated the ::pipe() system calls to pipe2
in posix subprocess.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68396/#review207523
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On Aug. 16, 2018, 11:18 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68396/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2018, 11:18 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin Mahler, Jie Yu, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9151
> https://issues.apache.org/jira/browse/MESOS-9151
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated the ::pipe() system calls to pipe2 in posix subprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/posix/subprocess.cpp 01e3272fccda6ff66e1629fb10d22d8c4967b22a
>
>
> Diff: https://reviews.apache.org/r/68396/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>