[PATCH-REVIEW] shm.c

[Guenter Knauf <fu...@apache.org>]

Hi Jeff,
Jeff Trawick schrieb:
> IMO we should just let it be; users/developers can set CFLAGS to
> suppress it if desired.  
personally I dislike to globaly suppress warnings since at some point we
might hide also real problems - and if we can fix it then I think we
should do ...; as I showed with my sample gcc warns too if the related
warning is enabled - its just that we usually compile without ...

> (Perhaps non-suppressing Sun Studio users among the developers will
> notice when a new one crops up and evaluate whether or not it is a real
> problem; perhaps other compilers will warn in scenarios where it is more
> likely?)
can you perhaps review and verify if this patch fixes the Sun Studio
warnings in shm.c?
http://people.apache.org/~fuankg/diffs/shm.c.diff
whole file apr/shmem/unix/shm.c:
http://people.apache.org/~fuankg/diffs/shm.c
Maybe I did something wrong, but at least it compiled for me on Linux,
and all tests passed ...

Gün.

RE: [PATCH-REVIEW] shm.c

["Plüm, Rüdiger, VF-Group" <ru...@vodafone.com>]

 

> -----Original Message-----
> From: Guenter Knauf 
> Sent: Dienstag, 29. September 2009 13:10
> To: dev@httpd.apache.org; APR Developer List
> Subject: Re: [PATCH-REVIEW] shm.c
> 
> Hi,
> Guenter Knauf schrieb:
> > can you perhaps review and verify if this patch fixes the Sun Studio
> > warnings in shm.c?
> > http://people.apache.org/~fuankg/diffs/shm.c.diff
> > whole file apr/shmem/unix/shm.c:
> > http://people.apache.org/~fuankg/diffs/shm.c
> > Maybe I did something wrong, but at least it compiled for 
> me on Linux,
> > and all tests passed ...
> Jie reported already that Sun Studio is calm with it ...
> perhaps a critival review from someone (Ruediger?) before I commit?

Looks fine to me. Passes the tests.

Regards

Rüdiger

RE: [PATCH-REVIEW] shm.c

["Plüm, Rüdiger, VF-Group" <ru...@vodafone.com>]

 

> -----Original Message-----
> From: Guenter Knauf 
> Sent: Dienstag, 29. September 2009 13:10
> To: dev@httpd.apache.org; APR Developer List
> Subject: Re: [PATCH-REVIEW] shm.c
> 
> Hi,
> Guenter Knauf schrieb:
> > can you perhaps review and verify if this patch fixes the Sun Studio
> > warnings in shm.c?
> > http://people.apache.org/~fuankg/diffs/shm.c.diff
> > whole file apr/shmem/unix/shm.c:
> > http://people.apache.org/~fuankg/diffs/shm.c
> > Maybe I did something wrong, but at least it compiled for 
> me on Linux,
> > and all tests passed ...
> Jie reported already that Sun Studio is calm with it ...
> perhaps a critival review from someone (Ruediger?) before I commit?

Looks fine to me. Passes the tests.

Regards

Rüdiger

Re: [PATCH-REVIEW] shm.c

[Guenter Knauf <fu...@apache.org>]

Hi,
Guenter Knauf schrieb:
> can you perhaps review and verify if this patch fixes the Sun Studio
> warnings in shm.c?
> http://people.apache.org/~fuankg/diffs/shm.c.diff
> whole file apr/shmem/unix/shm.c:
> http://people.apache.org/~fuankg/diffs/shm.c
> Maybe I did something wrong, but at least it compiled for me on Linux,
> and all tests passed ...
Jie reported already that Sun Studio is calm with it ...
perhaps a critival review from someone (Ruediger?) before I commit?

Gün.

Re: [PATCH-REVIEW] shm.c

[Guenter Knauf <fu...@apache.org>]

Hi,
Guenter Knauf schrieb:
> can you perhaps review and verify if this patch fixes the Sun Studio
> warnings in shm.c?
> http://people.apache.org/~fuankg/diffs/shm.c.diff
> whole file apr/shmem/unix/shm.c:
> http://people.apache.org/~fuankg/diffs/shm.c
> Maybe I did something wrong, but at least it compiled for me on Linux,
> and all tests passed ...
Jie reported already that Sun Studio is calm with it ...
perhaps a critival review from someone (Ruediger?) before I commit?

Gün.