You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morrySnow (via GitHub)" <gi...@apache.org> on 2023/04/23 13:28:57 UTC
[GitHub] [doris] morrySnow opened a new pull request, #18975: [opt](Nereids) simplify decimalv3 comparison predicate
morrySnow opened a new pull request, #18975:
URL: https://github.com/apache/doris/pull/18975
# Proposed changes
Issue Number: close #xxx
1. fix constant folding failed on decimalv3 type
2. support reduce decimalv3 literal precision in comparison predicate
3. support fe config enable_decimal_conversion
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #18975: [opt](Nereids) simplify decimalv3 comparison predicate
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #18975:
URL: https://github.com/apache/doris/pull/18975#issuecomment-1522942834
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #18975: [opt](Nereids) simplify decimalv3 comparison predicate
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #18975:
URL: https://github.com/apache/doris/pull/18975#issuecomment-1519069409
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #18975: [opt](Nereids) simplify decimalv3 comparison predicate
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #18975:
URL: https://github.com/apache/doris/pull/18975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #18975: [opt](Nereids) simplify decimalv3 comparison predicate
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #18975:
URL: https://github.com/apache/doris/pull/18975#issuecomment-1519547316
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #18975: [opt](Nereids) simplify decimalv3 comparison predicate
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #18975:
URL: https://github.com/apache/doris/pull/18975#issuecomment-1519072780
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.19 seconds
stream load tsv: 428 seconds loaded 74807831229 Bytes, about 166 MB/s
stream load json: 23 seconds loaded 2358488459 Bytes, about 97 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230423135148_clickbench_pr_133489.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18975: [opt](Nereids) simplify decimalv3 comparison predicate
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18975:
URL: https://github.com/apache/doris/pull/18975#issuecomment-1523546424
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #18975: [opt](Nereids) simplify decimalv3 comparison predicate
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #18975:
URL: https://github.com/apache/doris/pull/18975#discussion_r1177384207
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/SimplifyDecimalV3Comparison.java:
##########
@@ -0,0 +1,77 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.expression.rules;
+
+import org.apache.doris.nereids.rules.expression.AbstractExpressionRewriteRule;
+import org.apache.doris.nereids.rules.expression.ExpressionRewriteContext;
+import org.apache.doris.nereids.trees.expressions.Cast;
+import org.apache.doris.nereids.trees.expressions.ComparisonPredicate;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.literal.DecimalV3Literal;
+import org.apache.doris.nereids.types.DecimalV3Type;
+
+import com.google.common.base.Preconditions;
+
+import java.math.BigDecimal;
+
+/**
+ * if we have a column with decimalv3 type and set enable_decimal_conversion = false.
+ * we have a column named col1 with type decimalv3(15, 2)
+ * and we have a comparison like col1 > 0.5 + 0.1
+ * then the result type of 0.5 + 0.1 is decimalv2(27, 9)
+ * and the col1 need to convert to decimalv3(27, 9) to match the precision of right hand
+ * this rule simplify it from cast(col1 as decimalv3(27, 9)) > 0.6 to col1 > 0.6
+ */
+public class SimplifyDecimalV3Comparison extends AbstractExpressionRewriteRule {
+
+ public static SimplifyDecimalV3Comparison INSTANCE = new SimplifyDecimalV3Comparison();
+
+ @Override
+ public Expression visitComparisonPredicate(ComparisonPredicate cp, ExpressionRewriteContext context) {
+ Expression left = rewrite(cp.left(), context);
+ Expression right = rewrite(cp.right(), context);
+
+ if (left.getDataType() instanceof DecimalV3Type
+ && left instanceof Cast
+ && ((Cast) left).child().getDataType() instanceof DecimalV3Type
+ && right instanceof DecimalV3Literal) {
+ return doProcess(cp, (Cast) left, (DecimalV3Literal) right);
+ }
+
+ if (left != cp.left() || right != cp.right()) {
+ return cp.withChildren(left, right);
+ } else {
+ return cp;
+ }
+ }
+
+ private Expression doProcess(ComparisonPredicate cp, Cast left, DecimalV3Literal right) {
+ BigDecimal trailingZerosValue = right.getValue().stripTrailingZeros();
+ int scale = trailingZerosValue.scale();
+ int precision = Math.max(scale, trailingZerosValue.precision());
+ Expression castChild = left.child();
+ Preconditions.checkState(castChild.getDataType() instanceof DecimalV3Type);
+ DecimalV3Type leftType = (DecimalV3Type) castChild.getDataType();
+ if (leftType.getPrecision() < precision || leftType.getScale() < scale) {
+ return cp.withChildren(left, right);
Review Comment:
good idea~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #18975: [opt](Nereids) simplify decimalv3 comparison predicate
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #18975:
URL: https://github.com/apache/doris/pull/18975#discussion_r1177477267
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/SimplifyDecimalV3Comparison.java:
##########
@@ -0,0 +1,77 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.expression.rules;
+
+import org.apache.doris.nereids.rules.expression.AbstractExpressionRewriteRule;
+import org.apache.doris.nereids.rules.expression.ExpressionRewriteContext;
+import org.apache.doris.nereids.trees.expressions.Cast;
+import org.apache.doris.nereids.trees.expressions.ComparisonPredicate;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.literal.DecimalV3Literal;
+import org.apache.doris.nereids.types.DecimalV3Type;
+
+import com.google.common.base.Preconditions;
+
+import java.math.BigDecimal;
+
+/**
+ * if we have a column with decimalv3 type and set enable_decimal_conversion = false.
+ * we have a column named col1 with type decimalv3(15, 2)
+ * and we have a comparison like col1 > 0.5 + 0.1
+ * then the result type of 0.5 + 0.1 is decimalv2(27, 9)
+ * and the col1 need to convert to decimalv3(27, 9) to match the precision of right hand
+ * this rule simplify it from cast(col1 as decimalv3(27, 9)) > 0.6 to col1 > 0.6
+ */
+public class SimplifyDecimalV3Comparison extends AbstractExpressionRewriteRule {
+
+ public static SimplifyDecimalV3Comparison INSTANCE = new SimplifyDecimalV3Comparison();
+
+ @Override
+ public Expression visitComparisonPredicate(ComparisonPredicate cp, ExpressionRewriteContext context) {
+ Expression left = rewrite(cp.left(), context);
+ Expression right = rewrite(cp.right(), context);
+
+ if (left.getDataType() instanceof DecimalV3Type
+ && left instanceof Cast
+ && ((Cast) left).child().getDataType() instanceof DecimalV3Type
+ && right instanceof DecimalV3Literal) {
+ return doProcess(cp, (Cast) left, (DecimalV3Literal) right);
+ }
+
+ if (left != cp.left() || right != cp.right()) {
+ return cp.withChildren(left, right);
+ } else {
+ return cp;
+ }
+ }
+
+ private Expression doProcess(ComparisonPredicate cp, Cast left, DecimalV3Literal right) {
+ BigDecimal trailingZerosValue = right.getValue().stripTrailingZeros();
+ int scale = trailingZerosValue.scale();
+ int precision = Math.max(scale, trailingZerosValue.precision());
+ Expression castChild = left.child();
+ Preconditions.checkState(castChild.getDataType() instanceof DecimalV3Type);
+ DecimalV3Type leftType = (DecimalV3Type) castChild.getDataType();
+ if (leftType.getPrecision() < precision || leftType.getScale() < scale) {
+ return cp.withChildren(left, right);
Review Comment:
i found that right's scale and precision cannot greater than lefts, so i add a check here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #18975: [opt](Nereids) simplify decimalv3 comparison predicate
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on code in PR #18975:
URL: https://github.com/apache/doris/pull/18975#discussion_r1175037823
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/SimplifyDecimalV3Comparison.java:
##########
@@ -0,0 +1,77 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.expression.rules;
+
+import org.apache.doris.nereids.rules.expression.AbstractExpressionRewriteRule;
+import org.apache.doris.nereids.rules.expression.ExpressionRewriteContext;
+import org.apache.doris.nereids.trees.expressions.Cast;
+import org.apache.doris.nereids.trees.expressions.ComparisonPredicate;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.literal.DecimalV3Literal;
+import org.apache.doris.nereids.types.DecimalV3Type;
+
+import com.google.common.base.Preconditions;
+
+import java.math.BigDecimal;
+
+/**
+ * if we have a column with decimalv3 type and set enable_decimal_conversion = false.
+ * we have a column named col1 with type decimalv3(15, 2)
+ * and we have a comparison like col1 > 0.5 + 0.1
+ * then the result type of 0.5 + 0.1 is decimalv2(27, 9)
+ * and the col1 need to convert to decimalv3(27, 9) to match the precision of right hand
+ * this rule simplify it from cast(col1 as decimalv3(27, 9)) > 0.6 to col1 > 0.6
+ */
+public class SimplifyDecimalV3Comparison extends AbstractExpressionRewriteRule {
+
+ public static SimplifyDecimalV3Comparison INSTANCE = new SimplifyDecimalV3Comparison();
+
+ @Override
+ public Expression visitComparisonPredicate(ComparisonPredicate cp, ExpressionRewriteContext context) {
+ Expression left = rewrite(cp.left(), context);
+ Expression right = rewrite(cp.right(), context);
+
+ if (left.getDataType() instanceof DecimalV3Type
+ && left instanceof Cast
+ && ((Cast) left).child().getDataType() instanceof DecimalV3Type
+ && right instanceof DecimalV3Literal) {
+ return doProcess(cp, (Cast) left, (DecimalV3Literal) right);
+ }
+
+ if (left != cp.left() || right != cp.right()) {
+ return cp.withChildren(left, right);
+ } else {
+ return cp;
+ }
+ }
+
+ private Expression doProcess(ComparisonPredicate cp, Cast left, DecimalV3Literal right) {
+ BigDecimal trailingZerosValue = right.getValue().stripTrailingZeros();
+ int scale = trailingZerosValue.scale();
+ int precision = Math.max(scale, trailingZerosValue.precision());
+ Expression castChild = left.child();
+ Preconditions.checkState(castChild.getDataType() instanceof DecimalV3Type);
+ DecimalV3Type leftType = (DecimalV3Type) castChild.getDataType();
+ if (leftType.getPrecision() < precision || leftType.getScale() < scale) {
+ return cp.withChildren(left, right);
Review Comment:
we could optimize this branch.
if this comparison is equalTo, this comparison will return false.
if it is > or <, we could cut the right literal, and let the left column unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #18975: [opt](Nereids) simplify decimalv3 comparison predicate
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #18975:
URL: https://github.com/apache/doris/pull/18975#issuecomment-1519068370
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #18975: [opt](Nereids) simplify decimalv3 comparison predicate
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on code in PR #18975:
URL: https://github.com/apache/doris/pull/18975#discussion_r1175037823
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/SimplifyDecimalV3Comparison.java:
##########
@@ -0,0 +1,77 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.expression.rules;
+
+import org.apache.doris.nereids.rules.expression.AbstractExpressionRewriteRule;
+import org.apache.doris.nereids.rules.expression.ExpressionRewriteContext;
+import org.apache.doris.nereids.trees.expressions.Cast;
+import org.apache.doris.nereids.trees.expressions.ComparisonPredicate;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.literal.DecimalV3Literal;
+import org.apache.doris.nereids.types.DecimalV3Type;
+
+import com.google.common.base.Preconditions;
+
+import java.math.BigDecimal;
+
+/**
+ * if we have a column with decimalv3 type and set enable_decimal_conversion = false.
+ * we have a column named col1 with type decimalv3(15, 2)
+ * and we have a comparison like col1 > 0.5 + 0.1
+ * then the result type of 0.5 + 0.1 is decimalv2(27, 9)
+ * and the col1 need to convert to decimalv3(27, 9) to match the precision of right hand
+ * this rule simplify it from cast(col1 as decimalv3(27, 9)) > 0.6 to col1 > 0.6
+ */
+public class SimplifyDecimalV3Comparison extends AbstractExpressionRewriteRule {
+
+ public static SimplifyDecimalV3Comparison INSTANCE = new SimplifyDecimalV3Comparison();
+
+ @Override
+ public Expression visitComparisonPredicate(ComparisonPredicate cp, ExpressionRewriteContext context) {
+ Expression left = rewrite(cp.left(), context);
+ Expression right = rewrite(cp.right(), context);
+
+ if (left.getDataType() instanceof DecimalV3Type
+ && left instanceof Cast
+ && ((Cast) left).child().getDataType() instanceof DecimalV3Type
+ && right instanceof DecimalV3Literal) {
+ return doProcess(cp, (Cast) left, (DecimalV3Literal) right);
+ }
+
+ if (left != cp.left() || right != cp.right()) {
+ return cp.withChildren(left, right);
+ } else {
+ return cp;
+ }
+ }
+
+ private Expression doProcess(ComparisonPredicate cp, Cast left, DecimalV3Literal right) {
+ BigDecimal trailingZerosValue = right.getValue().stripTrailingZeros();
+ int scale = trailingZerosValue.scale();
+ int precision = Math.max(scale, trailingZerosValue.precision());
+ Expression castChild = left.child();
+ Preconditions.checkState(castChild.getDataType() instanceof DecimalV3Type);
+ DecimalV3Type leftType = (DecimalV3Type) castChild.getDataType();
+ if (leftType.getPrecision() < precision || leftType.getScale() < scale) {
+ return cp.withChildren(left, right);
Review Comment:
we could optimize this branch. (leftType.getPrecision() < precision || leftType.getScale() < scale)
if this comparison is equalTo, this comparison will return false.
if it is > or <, we could cut the right literal, and let the left column unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #18975: [opt](Nereids) simplify decimalv3 comparison predicate
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #18975:
URL: https://github.com/apache/doris/pull/18975#issuecomment-1523015214
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18975: [opt](Nereids) simplify decimalv3 comparison predicate
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18975:
URL: https://github.com/apache/doris/pull/18975#issuecomment-1523546477
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org