You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by md...@apache.org on 2018/04/12 21:36:25 UTC
[1/3] hbase git commit: HBASE-20338 WALProcedureStore#recoverLease()
should have fixed sleeps for retrying rollWriter()
Repository: hbase
Updated Branches:
refs/heads/branch-2 a50d9f435 -> b1901c9a1
refs/heads/branch-2.0 263cc8d14 -> 0eacb3ea0
refs/heads/master 70d23214f -> 17a29ac23
HBASE-20338 WALProcedureStore#recoverLease() should have fixed sleeps for retrying rollWriter()
Signed-off-by: Mike Drob <md...@apache.org>
Signed-off-by: Umesh Agashe <ua...@cloudera.com>
Signed-off-by: Chia-Ping Tsai <ch...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/17a29ac2
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/17a29ac2
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/17a29ac2
Branch: refs/heads/master
Commit: 17a29ac2313774850f0cce116ee33ef79d007a34
Parents: 70d2321
Author: Wei-Chiu Chuang <we...@cloudera.com>
Authored: Thu Apr 5 14:11:29 2018 -0700
Committer: Mike Drob <md...@apache.org>
Committed: Thu Apr 12 16:33:55 2018 -0500
----------------------------------------------------------------------
.../hbase/procedure2/store/wal/WALProcedureStore.java | 9 +++++++++
1 file changed, 9 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/17a29ac2/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
----------------------------------------------------------------------
diff --git a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
index c5680cf..f2931fc 100644
--- a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
+++ b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
@@ -359,7 +359,16 @@ public class WALProcedureStore extends ProcedureStoreBase {
lock.lock();
try {
LOG.trace("Starting WAL Procedure Store lease recovery");
+ boolean afterFirstAttempt = false;
while (isRunning()) {
+ // Don't sleep before first attempt
+ if (afterFirstAttempt) {
+ LOG.trace("Sleep {} ms after first lease recovery attempt.",
+ waitBeforeRoll);
+ Threads.sleepWithoutInterrupt(waitBeforeRoll);
+ } else {
+ afterFirstAttempt = true;
+ }
FileStatus[] oldLogs = getLogFiles();
// Get Log-MaxID and recover lease on old logs
try {
[3/3] hbase git commit: HBASE-20338 WALProcedureStore#recoverLease()
should have fixed sleeps for retrying rollWriter()
Posted by md...@apache.org.
HBASE-20338 WALProcedureStore#recoverLease() should have fixed sleeps for retrying rollWriter()
Signed-off-by: Mike Drob <md...@apache.org>
Signed-off-by: Umesh Agashe <ua...@cloudera.com>
Signed-off-by: Chia-Ping Tsai <ch...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/0eacb3ea
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/0eacb3ea
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/0eacb3ea
Branch: refs/heads/branch-2.0
Commit: 0eacb3ea0a202b09265030ddba5b408da597dc9a
Parents: 263cc8d
Author: Wei-Chiu Chuang <we...@cloudera.com>
Authored: Thu Apr 5 14:11:29 2018 -0700
Committer: Mike Drob <md...@apache.org>
Committed: Thu Apr 12 16:35:30 2018 -0500
----------------------------------------------------------------------
.../hbase/procedure2/store/wal/WALProcedureStore.java | 9 +++++++++
1 file changed, 9 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/0eacb3ea/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
----------------------------------------------------------------------
diff --git a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
index d14e1bf..0c8cfd2 100644
--- a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
+++ b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
@@ -359,7 +359,16 @@ public class WALProcedureStore extends ProcedureStoreBase {
lock.lock();
try {
LOG.trace("Starting WAL Procedure Store lease recovery");
+ boolean afterFirstAttempt = false;
while (isRunning()) {
+ // Don't sleep before first attempt
+ if (afterFirstAttempt) {
+ LOG.trace("Sleep {} ms after first lease recovery attempt.",
+ waitBeforeRoll);
+ Threads.sleepWithoutInterrupt(waitBeforeRoll);
+ } else {
+ afterFirstAttempt = true;
+ }
FileStatus[] oldLogs = getLogFiles();
// Get Log-MaxID and recover lease on old logs
try {
[2/3] hbase git commit: HBASE-20338 WALProcedureStore#recoverLease()
should have fixed sleeps for retrying rollWriter()
Posted by md...@apache.org.
HBASE-20338 WALProcedureStore#recoverLease() should have fixed sleeps for retrying rollWriter()
Signed-off-by: Mike Drob <md...@apache.org>
Signed-off-by: Umesh Agashe <ua...@cloudera.com>
Signed-off-by: Chia-Ping Tsai <ch...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/b1901c9a
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/b1901c9a
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/b1901c9a
Branch: refs/heads/branch-2
Commit: b1901c9a15fccba94f1750021d7d7c84dd60cc8b
Parents: a50d9f4
Author: Wei-Chiu Chuang <we...@cloudera.com>
Authored: Thu Apr 5 14:11:29 2018 -0700
Committer: Mike Drob <md...@apache.org>
Committed: Thu Apr 12 16:35:11 2018 -0500
----------------------------------------------------------------------
.../hbase/procedure2/store/wal/WALProcedureStore.java | 9 +++++++++
1 file changed, 9 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/b1901c9a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
----------------------------------------------------------------------
diff --git a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
index d14e1bf..0c8cfd2 100644
--- a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
+++ b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
@@ -359,7 +359,16 @@ public class WALProcedureStore extends ProcedureStoreBase {
lock.lock();
try {
LOG.trace("Starting WAL Procedure Store lease recovery");
+ boolean afterFirstAttempt = false;
while (isRunning()) {
+ // Don't sleep before first attempt
+ if (afterFirstAttempt) {
+ LOG.trace("Sleep {} ms after first lease recovery attempt.",
+ waitBeforeRoll);
+ Threads.sleepWithoutInterrupt(waitBeforeRoll);
+ } else {
+ afterFirstAttempt = true;
+ }
FileStatus[] oldLogs = getLogFiles();
// Get Log-MaxID and recover lease on old logs
try {