You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cordova.apache.org by Shazron <sh...@gmail.com> on 2014/04/26 01:02:47 UTC

[osx, cli] pull request, need another set of eyes

Seems trivial (a few lines), but CLI is not my forté so I would appreciate
another set looking at this:
https://github.com/apache/cordova-cli/pull/170

Re: [osx, cli] pull request, need another set of eyes

Posted by Braden Shepherdson <br...@chromium.org>.

LGTM. There might be some reason we can't use identical flows for OSX and
iOS, but there's no point in having duplicate branches to the code if
they're the same right now. They can be split later if they diverge.

Braden

On Fri, Apr 25, 2014 at 7:17 PM, Jesse <pu...@gmail.com> wrote:

> I think the osx repo should have a tag, to some known state, and that
> can/should be used in platforms.js
>
> @purplecabbage
> risingj.com
>
>
> On Fri, Apr 25, 2014 at 4:02 PM, Shazron <sh...@gmail.com> wrote:
>
> > Seems trivial (a few lines), but CLI is not my forté so I would
> appreciate
> > another set looking at this:
> > https://github.com/apache/cordova-cli/pull/170
> >
>

Re: [osx, cli] pull request, need another set of eyes

Posted by Jesse <pu...@gmail.com>.

I think the osx repo should have a tag, to some known state, and that
can/should be used in platforms.js

@purplecabbage
risingj.com


On Fri, Apr 25, 2014 at 4:02 PM, Shazron <sh...@gmail.com> wrote:

> Seems trivial (a few lines), but CLI is not my forté so I would appreciate
> another set looking at this:
> https://github.com/apache/cordova-cli/pull/170
>