You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@datasketches.apache.org by "proost (via GitHub)" <gi...@apache.org> on 2026/10/14 15:24:48 UTC

Re: [PR] test: count min sketch serialization test [datasketches-go]

proost commented on PR #163:
URL: https://github.com/apache/datasketches-go/pull/163#issuecomment-6171855634

   @leerho 
   Thanks for review.
   
   1. I prefer that test doesn't stop even if some cases failed. Because seeing all failures is preferred. But your review makes sense to me, so i added assertion is passed or not.
   2. Exporting default seed isn't good. So i added new constructors and deserialization method without what is seed needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org