[jira] [Commented] (TS-2220) Rename proxy.config.http.anonymize_insert_client_ip to proxy.config.http.insert_client_ip

["Bryan Call (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422893#comment-15422893 ] 

Bryan Call commented on TS-2220:
--------------------------------

The only thing that needs to be done is rename the setting and update the docs.

> Rename proxy.config.http.anonymize_insert_client_ip to proxy.config.http.insert_client_ip
> -----------------------------------------------------------------------------------------
>
>                 Key: TS-2220
>                 URL: https://issues.apache.org/jira/browse/TS-2220
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: HTTP
>    Affects Versions: 4.0.1
>            Reporter: Zhao Yongming
>            Assignee: Bryan Call
>              Labels: incompatible
>             Fix For: 7.0.0
>
>
> this is for V4 branch changes, add the new proxy.config.http.insert_client_ip.
> we should name proxy.config.http.anonymize_insert_client_ip as 'proxy.config.http.insert_request_client_ip' or just 'proxy.config.http.insert_client_ip'
> and the current implement of the insert client ip works only if the client request do not have a 'Client-ip' header, but sometimes we need to replace it even if someone send us a fake 'Client-ip':
> proxy.config.http.insert_client_ip
> INT
> 1
> When disabled(0), do nothing.
> When enabled (1), Traffic Server inserts Client-IP headers to retain the client IP address, if there is no such headers. 
> When forced (2), Traffic Server inserts Client-IP, or replace the origin Client-IP header if it is already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)