[jira] [Resolved] (IMPALA-8157) Log exceptions from the front end

["Paul Rogers (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-8157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Rogers resolved IMPALA-8157.
---------------------------------
    Resolution: Won't Fix

Turns out the back end does log exceptions. Perhaps when I filed this I could not find them. Closing this bug for now unless I verify that the exceptions are not, in fact, getting logged.

> Log exceptions from the front end
> ---------------------------------
>
>                 Key: IMPALA-8157
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8157
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Frontend
>    Affects Versions: Impala 3.1.0
>            Reporter: Paul Rogers
>            Priority: Minor
>
> The BE calls into the FE for a variety of operations. Each of these may fail in expected ways (invalid query, say) or unexpected ways (a code change introduces a null pointer exception.)
> At present, the BE logs only the exception, and only at the INFO level. This ticket asks to log all unexpected exceptions at the ERROR level. The basic idea is to extend all FE entry points to do:
> {code:java}
> try {
>   // Do the operation
> } catch (ExpectedException e) {
>   // Don't log expected exceptions
>   throw e;
> } catch (Throwable e) {
>   LOG.error("Something went wrong", e);
>   throw e;
> }
> {code}
> The above code logs all exceptions except for those that are considered expected. The job of this ticket is to:
> * Find all the entry points
> * Identify which, if any, exceptions are expected
> * Add logging code with an error message that identifies the operation
> This pattern was tested ad-hoc to find a bug during development and seems to work fine. As. a result, the change is mostly a matter of the above three steps.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)