You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "zoudan (via GitHub)" <gi...@apache.org> on 2023/05/25 06:31:03 UTC

[GitHub] [calcite] zoudan commented on a diff in pull request #3224: [CALCITE-5722] Fix RangeSets.isPoint to use Comparable equality

zoudan commented on code in PR #3224:
URL: https://github.com/apache/calcite/pull/3224#discussion_r1205051820


##########
core/src/test/java/org/apache/calcite/util/RangeSetTest.java:
##########
@@ -155,6 +155,9 @@ class RangeSetTest {
     assertThat(RangeSets.isPoint(Range.atMost(0)), is(false));
     assertThat(RangeSets.isPoint(Range.greaterThan(0)), is(false));
     assertThat(RangeSets.isPoint(Range.atLeast(0)), is(false));
+
+    // Test situation where endpoints of closed range are equal under `Comparable.compareTo` but not `T.equals`

Review Comment:
   line too long, please check the code style



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org