You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/03/25 23:31:51 UTC
[GitHub] [incubator-druid] leventov opened a new issue #7340: Facilitate
testing AggregatorFactory (e. g. its makeAggregateCombiner() method) and
AggregateCombiner
leventov opened a new issue #7340: Facilitate testing AggregatorFactory (e. g. its makeAggregateCombiner() method) and AggregateCombiner
URL: https://github.com/apache/incubator-druid/issues/7340
`AggregateCombiner` is currently hard to test because it accepts works with `ColumnValueSelector` containers rather than with simple object values. At very least, a "singleton" implementation of `ColumnValueSelector` should be provided. Better, there should be something like a mini-framework for testing different cases about aggregator factories. This framework should pay off well because there are so many AggregatorFactories in the codebase.
Related to #7329.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org