You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by "rootvector2 (via GitHub)" <gi...@apache.org> on 2026/07/01 09:31:19 UTC
[PR] use a per-call DecimalFormat in OggAudioParser duration output [tika]
rootvector2 opened a new pull request, #2920:
URL: https://github.com/apache/tika/pull/2920
the static `DURATION_FORMAT` is shared across the ogg parser singletons but `DecimalFormat` is not thread-safe, so concurrent parses race on its mutable internal state; create it per call inside `extractDuration` like `MP4Parser` already does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] use a per-call DecimalFormat in OggAudioParser duration output [tika]
Posted by "rootvector2 (via GitHub)" <gi...@apache.org>.
rootvector2 commented on PR #2920:
URL: https://github.com/apache/tika/pull/2920#issuecomment-4873826507
good call. added `OggAudioParserDurationTest` that drives `extractDuration` from 32 threads over a set of rounding-heavy duration shapes and asserts `XMPDM.DURATION` matches the single-threaded value every time. it stays green now and would fail if a shared static formatter ever came back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] use a per-call DecimalFormat in OggAudioParser duration output [tika]
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison merged PR #2920:
URL: https://github.com/apache/tika/pull/2920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] use a per-call DecimalFormat in OggAudioParser duration output [tika]
Posted by "rootvector2 (via GitHub)" <gi...@apache.org>.
rootvector2 commented on PR #2920:
URL: https://github.com/apache/tika/pull/2920#issuecomment-4956236911
thanks for landing this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org