You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/03/12 13:20:39 UTC
[GitHub] [submarine] yuanzac opened a new pull request #227: SUBMARINE-428.
Add job table in db to store job status.
yuanzac opened a new pull request #227: SUBMARINE-428. Add job table in db to store job status.
URL: https://github.com/apache/submarine/pull/227
### What is this PR for?
We have to store job status in db. So that we don't need to get job status by k8s/yarn API every time.
### What type of PR is it?
Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-428
### How should this be tested?
https://travis-ci.org/github/yuanzac/hadoop-submarine/builds/661526991?utm_source=github_status&utm_medium=notification
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #227: SUBMARINE-428. Add job
table in db to store job status.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #227: SUBMARINE-428. Add job table in db to store job status.
URL: https://github.com/apache/submarine/pull/227
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] liuxunorg commented on a change in pull request #227:
SUBMARINE-428. Add job table in db to store job status.
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on a change in pull request #227: SUBMARINE-428. Add job table in db to store job status.
URL: https://github.com/apache/submarine/pull/227#discussion_r392551812
##########
File path: .editorconfig
##########
@@ -14,7 +14,7 @@ trim_trailing_whitespace = true
indent_style = tab
# 2 space indentation
-[*.{java,sh,json,xml}]
+[*.{sh,json,xml}]
Review comment:
Why deleted `java`?
`java` uses 2 spaces for indentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] tangzhankun commented on issue #227: SUBMARINE-428. Add
job table in db to store job status.
Posted by GitBox <gi...@apache.org>.
tangzhankun commented on issue #227: SUBMARINE-428. Add job table in db to store job status.
URL: https://github.com/apache/submarine/pull/227#issuecomment-599899560
+1. Thanks @yuanzac . One minor question, can the jobService used by the submarine REST server directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] liuxunorg commented on issue #227: SUBMARINE-428. Add
job table in db to store job status.
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #227: SUBMARINE-428. Add job table in db to store job status.
URL: https://github.com/apache/submarine/pull/227#issuecomment-598695196
@yuanzac Travis failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] yuanzac commented on a change in pull request #227:
SUBMARINE-428. Add job table in db to store job status.
Posted by GitBox <gi...@apache.org>.
yuanzac commented on a change in pull request #227: SUBMARINE-428. Add job table in db to store job status.
URL: https://github.com/apache/submarine/pull/227#discussion_r392656943
##########
File path: .editorconfig
##########
@@ -14,7 +14,7 @@ trim_trailing_whitespace = true
indent_style = tab
# 2 space indentation
-[*.{java,sh,json,xml}]
+[*.{sh,json,xml}]
Review comment:
When a new line is added in an expression or a method defination, we need to use 4 spaces for indentation. But this configuration will use 2 spaces. This will lead an error for style checking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] yuanzac commented on a change in pull request #227:
SUBMARINE-428. Add job table in db to store job status.
Posted by GitBox <gi...@apache.org>.
yuanzac commented on a change in pull request #227: SUBMARINE-428. Add job table in db to store job status.
URL: https://github.com/apache/submarine/pull/227#discussion_r392657195
##########
File path: submarine-server/server-core/src/main/java/org/apache/submarine/server/workbench/database/entity/Job.java
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.submarine.server.workbench.database.entity;
+
+public class Job extends BaseEntity {
+
+ // (Todo) Add dict configuration.
Review comment:
Thanks @liuxunorg, Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [submarine] liuxunorg commented on a change in pull request #227:
SUBMARINE-428. Add job table in db to store job status.
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on a change in pull request #227: SUBMARINE-428. Add job table in db to store job status.
URL: https://github.com/apache/submarine/pull/227#discussion_r392552037
##########
File path: submarine-server/server-core/src/main/java/org/apache/submarine/server/workbench/database/entity/Job.java
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.submarine.server.workbench.database.entity;
+
+public class Job extends BaseEntity {
+
+ // (Todo) Add dict configuration.
Review comment:
```
// (Todo) Add dict configuration.
```
Is this an invalid comment, or will this feature need to be added later?
If you need to add this function in the future, you need to change it to `TODO (you name) Add dict configuration.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services