You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "Glen Mazza (JIRA)" <ji...@apache.org> on 2013/01/11 14:10:13 UTC

[jira] [Commented] (MTOMCAT-189) additionalClassesDirs parameter handling expanded to include run and run-war goals

    [ https://issues.apache.org/jira/browse/MTOMCAT-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551102#comment-13551102 ] 

Glen Mazza commented on MTOMCAT-189:
------------------------------------

Nick, to avoid duplication of functionality, would it be possible (and sufficiently convenient) to rely on the META-INF/context.xml file for this configuration?  Both the run and run-war goals will read this file if available.  It has configuration capabilities for a Loader object (http://tomcat.apache.org/tomcat-7.0-doc/config/context.html#Nested_Components) also a "virtual webapp" (http://tomcat.apache.org/tomcat-7.0-doc/config/context.html#Virtual_webapp) both of which allow classpath modification.  

Also, I'm not sure if your intended patch is to allow you to just to set classpath directories (where the "single configuration file holding any environment-specific configuration data" you mention above already exists on the user's local machine) or send along additional dependencies (i.e., store that config file in the project and make sure it's sent to embedded Tomcat when it runs the patch)--which is your intention here?

Also, you appear to have forgotten to attach the patch...do you still have it?  Thanks!
                
> additionalClassesDirs parameter handling expanded to include run and run-war goals
> ----------------------------------------------------------------------------------
>
>                 Key: MTOMCAT-189
>                 URL: https://issues.apache.org/jira/browse/MTOMCAT-189
>             Project: Apache Tomcat Maven Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1
>            Reporter: Nick Lloyd
>            Priority: Minor
>             Fix For: 2.1
>
>
> I contributed the original patch to add the functionality to add additional directories to the classpath for the run goal.  This patch expands on that, adding the functionality to both run and run-war goals in the tomcat6 and tomcat7 plugin artifacts.
> Please review and incorporate as you see fit.  My organization is using this internally.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org