You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/12/29 22:39:44 UTC
Review Request 41778: Proposal: simplify test BUILD files to one
target per directory.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/
-----------------------------------------------------------
Review request for Aurora, John Sirois and Zameer Manji.
Repository: aurora
Description
-------
I'm using this file as a proposed convention for test targets in `BUILD` files. In addition to being less redundant, i find the resulting file much easier to understand. In the past when refactoring, i can find it nightmarish to go back and bring all the build targets back into line (often repeating myself with imports changed in code).
If this proposal is accepted, i would like to further propose we collapse our `BUILD` files into one target for all python tests.
Note that this patch is related to https://issues.apache.org/jira/browse/AURORA-959
Diffs
-----
src/test/python/apache/aurora/client/api/BUILD 2a55cec51324c18debf10a1da93a74043f288a93
Diff: https://reviews.apache.org/r/41778/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 41778: Simplify test BUILD files to one target per
directory.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/#review112275
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Dec. 29, 2015, 10:32 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2015, 10:32 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I'm using this file as a proposed convention for test targets in `BUILD` files. In addition to being less redundant, i find the resulting file much easier to understand. In the past when refactoring, i can find it nightmarish to go back and bring all the build targets back into line (often repeating myself with imports changed in code).
>
> If this proposal is accepted, i would like to further propose we collapse our `BUILD` files into one target for all python tests.
>
> Note that this patch is related to https://issues.apache.org/jira/browse/AURORA-959
>
>
> Diffs
> -----
>
> src/test/python/BUILD a607f32314896213e60bdb062c31caf0056f073d
> src/test/python/apache/aurora/BUILD 82e944ad61708038bcc0fb9ddf7b4e9b5e2a49c5
> src/test/python/apache/aurora/admin/BUILD ca05c3f893b3e039d47e3dac6bf63035fd9dcd10
> src/test/python/apache/aurora/client/BUILD c9d7616d3d64e75e9ea3a66661064f6cb5e4e659
> src/test/python/apache/aurora/client/api/BUILD 2a55cec51324c18debf10a1da93a74043f288a93
> src/test/python/apache/aurora/client/cli/BUILD 6d4d5e9c40c9b3efd9d2b50fed687642c5833673
> src/test/python/apache/aurora/client/hooks/BUILD 8d43e433d825eb53b1f0154dfe5bf065f1cc2601
> src/test/python/apache/aurora/common/BUILD 7909ab5aadc9515e75a40bae169cd92365ea39b9
> src/test/python/apache/aurora/common/health_check/BUILD 98a24810bf24d9048c6d1d6ea0d166ac7f33710a
> src/test/python/apache/aurora/config/BUILD 2072422a68519c1a5304d77603c82e6b6d65cde0
> src/test/python/apache/aurora/executor/BUILD d50948a2488180ccae07e515c4cd837897f088ac
> src/test/python/apache/aurora/executor/bin/BUILD ca8b5f7d4d1bb854902ce2c39e0e207074f1eb3d
> src/test/python/apache/aurora/executor/common/BUILD 025947ee18d3bcef0da946466a107a2c89bf51a9
> src/test/python/apache/aurora/tools/BUILD c6014df89ff59352f12762cc535727acf0d065f7
> src/test/python/apache/thermos/BUILD 206fc05f8df74daff388ca6eecdfd4342e6f38aa
> src/test/python/apache/thermos/cli/BUILD e6284e38721bdf946e2a5f484accb11e9062fdf4
> src/test/python/apache/thermos/common/BUILD 460c82e7dc8f1eb0b78842434ead7081bdec55c2
> src/test/python/apache/thermos/config/BUILD f11b9eea93942ce6a934b51a9d10d46d387d0596
> src/test/python/apache/thermos/core/BUILD 93c6e107fbea9e85b1757c152ebc7616ccd96b36
> src/test/python/apache/thermos/monitoring/BUILD 514dd6c57c6113800569e1064847fff73d289f76
> src/test/python/apache/thermos/observer/BUILD aec3feb7b0f9ce92445d2c08abd9e4d101f5da20
> src/test/python/apache/thermos/observer/http/BUILD 8dc30973997a19c91f04350c8bcc479159b7eeb9
>
> Diff: https://reviews.apache.org/r/41778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41778: Simplify test BUILD files to one target per
directory.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/#review112241
-----------------------------------------------------------
Ship it!
Master (80ae5e8) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 29, 2015, 10:32 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2015, 10:32 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I'm using this file as a proposed convention for test targets in `BUILD` files. In addition to being less redundant, i find the resulting file much easier to understand. In the past when refactoring, i can find it nightmarish to go back and bring all the build targets back into line (often repeating myself with imports changed in code).
>
> If this proposal is accepted, i would like to further propose we collapse our `BUILD` files into one target for all python tests.
>
> Note that this patch is related to https://issues.apache.org/jira/browse/AURORA-959
>
>
> Diffs
> -----
>
> src/test/python/BUILD a607f32314896213e60bdb062c31caf0056f073d
> src/test/python/apache/aurora/BUILD 82e944ad61708038bcc0fb9ddf7b4e9b5e2a49c5
> src/test/python/apache/aurora/admin/BUILD ca05c3f893b3e039d47e3dac6bf63035fd9dcd10
> src/test/python/apache/aurora/client/BUILD c9d7616d3d64e75e9ea3a66661064f6cb5e4e659
> src/test/python/apache/aurora/client/api/BUILD 2a55cec51324c18debf10a1da93a74043f288a93
> src/test/python/apache/aurora/client/cli/BUILD 6d4d5e9c40c9b3efd9d2b50fed687642c5833673
> src/test/python/apache/aurora/client/hooks/BUILD 8d43e433d825eb53b1f0154dfe5bf065f1cc2601
> src/test/python/apache/aurora/common/BUILD 7909ab5aadc9515e75a40bae169cd92365ea39b9
> src/test/python/apache/aurora/common/health_check/BUILD 98a24810bf24d9048c6d1d6ea0d166ac7f33710a
> src/test/python/apache/aurora/config/BUILD 2072422a68519c1a5304d77603c82e6b6d65cde0
> src/test/python/apache/aurora/executor/BUILD d50948a2488180ccae07e515c4cd837897f088ac
> src/test/python/apache/aurora/executor/bin/BUILD ca8b5f7d4d1bb854902ce2c39e0e207074f1eb3d
> src/test/python/apache/aurora/executor/common/BUILD 025947ee18d3bcef0da946466a107a2c89bf51a9
> src/test/python/apache/aurora/tools/BUILD c6014df89ff59352f12762cc535727acf0d065f7
> src/test/python/apache/thermos/BUILD 206fc05f8df74daff388ca6eecdfd4342e6f38aa
> src/test/python/apache/thermos/cli/BUILD e6284e38721bdf946e2a5f484accb11e9062fdf4
> src/test/python/apache/thermos/common/BUILD 460c82e7dc8f1eb0b78842434ead7081bdec55c2
> src/test/python/apache/thermos/config/BUILD f11b9eea93942ce6a934b51a9d10d46d387d0596
> src/test/python/apache/thermos/core/BUILD 93c6e107fbea9e85b1757c152ebc7616ccd96b36
> src/test/python/apache/thermos/monitoring/BUILD 514dd6c57c6113800569e1064847fff73d289f76
> src/test/python/apache/thermos/observer/BUILD aec3feb7b0f9ce92445d2c08abd9e4d101f5da20
> src/test/python/apache/thermos/observer/http/BUILD 8dc30973997a19c91f04350c8bcc479159b7eeb9
>
> Diff: https://reviews.apache.org/r/41778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41778: Simplify test BUILD files to one target per
directory.
Posted by Stephan Erb <st...@dev.static-void.de>.
> On Dec. 29, 2015, 11:44 p.m., Stephan Erb wrote:
> > Would be awesome if you could document the druid knowledge of how to properly execute tests (single test, all tests, ...).
> >
> > There is already this https://github.com/apache/aurora/blob/f56ea265c1dcf4de5f67d31442eaee724870b0bd/docs/developing-aurora-client.md#building-and-testing-the-client so probably only a few more sentances or examples are needed to get new contributors up to speed.
>
> John Sirois wrote:
> Specific docs might be good, but also note general tools docs are decent: http://pantsbuild.github.io/target_addresses.html
Yes, even having that link in the right place of the Aurora documentation would be really helpful.
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/#review112238
-----------------------------------------------------------
On Dec. 29, 2015, 11:32 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2015, 11:32 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I'm using this file as a proposed convention for test targets in `BUILD` files. In addition to being less redundant, i find the resulting file much easier to understand. In the past when refactoring, i can find it nightmarish to go back and bring all the build targets back into line (often repeating myself with imports changed in code).
>
> If this proposal is accepted, i would like to further propose we collapse our `BUILD` files into one target for all python tests.
>
> Note that this patch is related to https://issues.apache.org/jira/browse/AURORA-959
>
>
> Diffs
> -----
>
> src/test/python/BUILD a607f32314896213e60bdb062c31caf0056f073d
> src/test/python/apache/aurora/BUILD 82e944ad61708038bcc0fb9ddf7b4e9b5e2a49c5
> src/test/python/apache/aurora/admin/BUILD ca05c3f893b3e039d47e3dac6bf63035fd9dcd10
> src/test/python/apache/aurora/client/BUILD c9d7616d3d64e75e9ea3a66661064f6cb5e4e659
> src/test/python/apache/aurora/client/api/BUILD 2a55cec51324c18debf10a1da93a74043f288a93
> src/test/python/apache/aurora/client/cli/BUILD 6d4d5e9c40c9b3efd9d2b50fed687642c5833673
> src/test/python/apache/aurora/client/hooks/BUILD 8d43e433d825eb53b1f0154dfe5bf065f1cc2601
> src/test/python/apache/aurora/common/BUILD 7909ab5aadc9515e75a40bae169cd92365ea39b9
> src/test/python/apache/aurora/common/health_check/BUILD 98a24810bf24d9048c6d1d6ea0d166ac7f33710a
> src/test/python/apache/aurora/config/BUILD 2072422a68519c1a5304d77603c82e6b6d65cde0
> src/test/python/apache/aurora/executor/BUILD d50948a2488180ccae07e515c4cd837897f088ac
> src/test/python/apache/aurora/executor/bin/BUILD ca8b5f7d4d1bb854902ce2c39e0e207074f1eb3d
> src/test/python/apache/aurora/executor/common/BUILD 025947ee18d3bcef0da946466a107a2c89bf51a9
> src/test/python/apache/aurora/tools/BUILD c6014df89ff59352f12762cc535727acf0d065f7
> src/test/python/apache/thermos/BUILD 206fc05f8df74daff388ca6eecdfd4342e6f38aa
> src/test/python/apache/thermos/cli/BUILD e6284e38721bdf946e2a5f484accb11e9062fdf4
> src/test/python/apache/thermos/common/BUILD 460c82e7dc8f1eb0b78842434ead7081bdec55c2
> src/test/python/apache/thermos/config/BUILD f11b9eea93942ce6a934b51a9d10d46d387d0596
> src/test/python/apache/thermos/core/BUILD 93c6e107fbea9e85b1757c152ebc7616ccd96b36
> src/test/python/apache/thermos/monitoring/BUILD 514dd6c57c6113800569e1064847fff73d289f76
> src/test/python/apache/thermos/observer/BUILD aec3feb7b0f9ce92445d2c08abd9e4d101f5da20
> src/test/python/apache/thermos/observer/http/BUILD 8dc30973997a19c91f04350c8bcc479159b7eeb9
>
> Diff: https://reviews.apache.org/r/41778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41778: Simplify test BUILD files to one target per
directory.
Posted by John Sirois <jo...@gmail.com>.
> On Dec. 29, 2015, 3:44 p.m., Stephan Erb wrote:
> > Would be awesome if you could document the druid knowledge of how to properly execute tests (single test, all tests, ...).
> >
> > There is already this https://github.com/apache/aurora/blob/f56ea265c1dcf4de5f67d31442eaee724870b0bd/docs/developing-aurora-client.md#building-and-testing-the-client so probably only a few more sentances or examples are needed to get new contributors up to speed.
Specific docs might be good, but also note general tools docs are decent: http://pantsbuild.github.io/target_addresses.html
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/#review112238
-----------------------------------------------------------
On Dec. 29, 2015, 3:32 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2015, 3:32 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I'm using this file as a proposed convention for test targets in `BUILD` files. In addition to being less redundant, i find the resulting file much easier to understand. In the past when refactoring, i can find it nightmarish to go back and bring all the build targets back into line (often repeating myself with imports changed in code).
>
> If this proposal is accepted, i would like to further propose we collapse our `BUILD` files into one target for all python tests.
>
> Note that this patch is related to https://issues.apache.org/jira/browse/AURORA-959
>
>
> Diffs
> -----
>
> src/test/python/BUILD a607f32314896213e60bdb062c31caf0056f073d
> src/test/python/apache/aurora/BUILD 82e944ad61708038bcc0fb9ddf7b4e9b5e2a49c5
> src/test/python/apache/aurora/admin/BUILD ca05c3f893b3e039d47e3dac6bf63035fd9dcd10
> src/test/python/apache/aurora/client/BUILD c9d7616d3d64e75e9ea3a66661064f6cb5e4e659
> src/test/python/apache/aurora/client/api/BUILD 2a55cec51324c18debf10a1da93a74043f288a93
> src/test/python/apache/aurora/client/cli/BUILD 6d4d5e9c40c9b3efd9d2b50fed687642c5833673
> src/test/python/apache/aurora/client/hooks/BUILD 8d43e433d825eb53b1f0154dfe5bf065f1cc2601
> src/test/python/apache/aurora/common/BUILD 7909ab5aadc9515e75a40bae169cd92365ea39b9
> src/test/python/apache/aurora/common/health_check/BUILD 98a24810bf24d9048c6d1d6ea0d166ac7f33710a
> src/test/python/apache/aurora/config/BUILD 2072422a68519c1a5304d77603c82e6b6d65cde0
> src/test/python/apache/aurora/executor/BUILD d50948a2488180ccae07e515c4cd837897f088ac
> src/test/python/apache/aurora/executor/bin/BUILD ca8b5f7d4d1bb854902ce2c39e0e207074f1eb3d
> src/test/python/apache/aurora/executor/common/BUILD 025947ee18d3bcef0da946466a107a2c89bf51a9
> src/test/python/apache/aurora/tools/BUILD c6014df89ff59352f12762cc535727acf0d065f7
> src/test/python/apache/thermos/BUILD 206fc05f8df74daff388ca6eecdfd4342e6f38aa
> src/test/python/apache/thermos/cli/BUILD e6284e38721bdf946e2a5f484accb11e9062fdf4
> src/test/python/apache/thermos/common/BUILD 460c82e7dc8f1eb0b78842434ead7081bdec55c2
> src/test/python/apache/thermos/config/BUILD f11b9eea93942ce6a934b51a9d10d46d387d0596
> src/test/python/apache/thermos/core/BUILD 93c6e107fbea9e85b1757c152ebc7616ccd96b36
> src/test/python/apache/thermos/monitoring/BUILD 514dd6c57c6113800569e1064847fff73d289f76
> src/test/python/apache/thermos/observer/BUILD aec3feb7b0f9ce92445d2c08abd9e4d101f5da20
> src/test/python/apache/thermos/observer/http/BUILD 8dc30973997a19c91f04350c8bcc479159b7eeb9
>
> Diff: https://reviews.apache.org/r/41778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41778: Simplify test BUILD files to one target per
directory.
Posted by Stephan Erb <st...@dev.static-void.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/#review112238
-----------------------------------------------------------
Would be awesome if you could document the druid knowledge of how to properly execute tests (single test, all tests, ...).
There is already this https://github.com/apache/aurora/blob/f56ea265c1dcf4de5f67d31442eaee724870b0bd/docs/developing-aurora-client.md#building-and-testing-the-client so probably only a few more sentances or examples are needed to get new contributors up to speed.
- Stephan Erb
On Dec. 29, 2015, 11:32 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2015, 11:32 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I'm using this file as a proposed convention for test targets in `BUILD` files. In addition to being less redundant, i find the resulting file much easier to understand. In the past when refactoring, i can find it nightmarish to go back and bring all the build targets back into line (often repeating myself with imports changed in code).
>
> If this proposal is accepted, i would like to further propose we collapse our `BUILD` files into one target for all python tests.
>
> Note that this patch is related to https://issues.apache.org/jira/browse/AURORA-959
>
>
> Diffs
> -----
>
> src/test/python/BUILD a607f32314896213e60bdb062c31caf0056f073d
> src/test/python/apache/aurora/BUILD 82e944ad61708038bcc0fb9ddf7b4e9b5e2a49c5
> src/test/python/apache/aurora/admin/BUILD ca05c3f893b3e039d47e3dac6bf63035fd9dcd10
> src/test/python/apache/aurora/client/BUILD c9d7616d3d64e75e9ea3a66661064f6cb5e4e659
> src/test/python/apache/aurora/client/api/BUILD 2a55cec51324c18debf10a1da93a74043f288a93
> src/test/python/apache/aurora/client/cli/BUILD 6d4d5e9c40c9b3efd9d2b50fed687642c5833673
> src/test/python/apache/aurora/client/hooks/BUILD 8d43e433d825eb53b1f0154dfe5bf065f1cc2601
> src/test/python/apache/aurora/common/BUILD 7909ab5aadc9515e75a40bae169cd92365ea39b9
> src/test/python/apache/aurora/common/health_check/BUILD 98a24810bf24d9048c6d1d6ea0d166ac7f33710a
> src/test/python/apache/aurora/config/BUILD 2072422a68519c1a5304d77603c82e6b6d65cde0
> src/test/python/apache/aurora/executor/BUILD d50948a2488180ccae07e515c4cd837897f088ac
> src/test/python/apache/aurora/executor/bin/BUILD ca8b5f7d4d1bb854902ce2c39e0e207074f1eb3d
> src/test/python/apache/aurora/executor/common/BUILD 025947ee18d3bcef0da946466a107a2c89bf51a9
> src/test/python/apache/aurora/tools/BUILD c6014df89ff59352f12762cc535727acf0d065f7
> src/test/python/apache/thermos/BUILD 206fc05f8df74daff388ca6eecdfd4342e6f38aa
> src/test/python/apache/thermos/cli/BUILD e6284e38721bdf946e2a5f484accb11e9062fdf4
> src/test/python/apache/thermos/common/BUILD 460c82e7dc8f1eb0b78842434ead7081bdec55c2
> src/test/python/apache/thermos/config/BUILD f11b9eea93942ce6a934b51a9d10d46d387d0596
> src/test/python/apache/thermos/core/BUILD 93c6e107fbea9e85b1757c152ebc7616ccd96b36
> src/test/python/apache/thermos/monitoring/BUILD 514dd6c57c6113800569e1064847fff73d289f76
> src/test/python/apache/thermos/observer/BUILD aec3feb7b0f9ce92445d2c08abd9e4d101f5da20
> src/test/python/apache/thermos/observer/http/BUILD 8dc30973997a19c91f04350c8bcc479159b7eeb9
>
> Diff: https://reviews.apache.org/r/41778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41778: Simplify test BUILD files to one target per
directory.
Posted by Bill Farner <wf...@apache.org>.
> On Dec. 29, 2015, 2:38 p.m., John Sirois wrote:
> > src/test/python/apache/aurora/BUILD, line 28
> > <https://reviews.apache.org/r/41778/diff/2/?file=1177608#file1177608line28>
> >
> > Strongly consider 'aurora' to make test target discoverability trivial.
Done.
> On Dec. 29, 2015, 2:38 p.m., John Sirois wrote:
> > src/test/python/apache/thermos/cli/BUILD, line 25
> > <https://reviews.apache.org/r/41778/diff/2/?file=1177622#file1177622line25>
> >
> > s/all/cli/ for nicer ergonomics - easy guessability.
Done.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/#review112232
-----------------------------------------------------------
On Dec. 29, 2015, 5:36 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2015, 5:36 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and John Sirois.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I'm using this file as a proposed convention for test targets in `BUILD` files. In addition to being less redundant, i find the resulting file much easier to understand. In the past when refactoring, i can find it nightmarish to go back and bring all the build targets back into line (often repeating myself with imports changed in code).
>
> If this proposal is accepted, i would like to further propose we collapse our `BUILD` files into one target for all python tests.
>
> Note that this patch is related to https://issues.apache.org/jira/browse/AURORA-959
>
>
> Diffs
> -----
>
> src/test/python/BUILD a607f32314896213e60bdb062c31caf0056f073d
> src/test/python/apache/aurora/BUILD 82e944ad61708038bcc0fb9ddf7b4e9b5e2a49c5
> src/test/python/apache/aurora/admin/BUILD ca05c3f893b3e039d47e3dac6bf63035fd9dcd10
> src/test/python/apache/aurora/client/BUILD c9d7616d3d64e75e9ea3a66661064f6cb5e4e659
> src/test/python/apache/aurora/client/api/BUILD 2a55cec51324c18debf10a1da93a74043f288a93
> src/test/python/apache/aurora/client/cli/BUILD 6d4d5e9c40c9b3efd9d2b50fed687642c5833673
> src/test/python/apache/aurora/client/hooks/BUILD 8d43e433d825eb53b1f0154dfe5bf065f1cc2601
> src/test/python/apache/aurora/common/BUILD 7909ab5aadc9515e75a40bae169cd92365ea39b9
> src/test/python/apache/aurora/common/health_check/BUILD 98a24810bf24d9048c6d1d6ea0d166ac7f33710a
> src/test/python/apache/aurora/config/BUILD 2072422a68519c1a5304d77603c82e6b6d65cde0
> src/test/python/apache/aurora/executor/BUILD d50948a2488180ccae07e515c4cd837897f088ac
> src/test/python/apache/aurora/executor/bin/BUILD ca8b5f7d4d1bb854902ce2c39e0e207074f1eb3d
> src/test/python/apache/aurora/executor/common/BUILD 025947ee18d3bcef0da946466a107a2c89bf51a9
> src/test/python/apache/aurora/tools/BUILD c6014df89ff59352f12762cc535727acf0d065f7
> src/test/python/apache/thermos/BUILD 206fc05f8df74daff388ca6eecdfd4342e6f38aa
> src/test/python/apache/thermos/cli/BUILD e6284e38721bdf946e2a5f484accb11e9062fdf4
> src/test/python/apache/thermos/common/BUILD 460c82e7dc8f1eb0b78842434ead7081bdec55c2
> src/test/python/apache/thermos/config/BUILD f11b9eea93942ce6a934b51a9d10d46d387d0596
> src/test/python/apache/thermos/core/BUILD 93c6e107fbea9e85b1757c152ebc7616ccd96b36
> src/test/python/apache/thermos/monitoring/BUILD 514dd6c57c6113800569e1064847fff73d289f76
> src/test/python/apache/thermos/observer/BUILD aec3feb7b0f9ce92445d2c08abd9e4d101f5da20
> src/test/python/apache/thermos/observer/http/BUILD 8dc30973997a19c91f04350c8bcc479159b7eeb9
>
> Diff: https://reviews.apache.org/r/41778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41778: Simplify test BUILD files to one target per
directory.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/#review112232
-----------------------------------------------------------
Ship it!
I did not find/grep imports to check your deps.
src/test/python/apache/aurora/BUILD (line 16)
<https://reviews.apache.org/r/41778/#comment172591>
Strongly consider 'aurora' to make test target discoverability trivial.
src/test/python/apache/thermos/cli/BUILD (line 16)
<https://reviews.apache.org/r/41778/#comment172590>
s/all/cli/ for nicer ergonomics - easy guessability.
- John Sirois
On Dec. 29, 2015, 3:32 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2015, 3:32 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I'm using this file as a proposed convention for test targets in `BUILD` files. In addition to being less redundant, i find the resulting file much easier to understand. In the past when refactoring, i can find it nightmarish to go back and bring all the build targets back into line (often repeating myself with imports changed in code).
>
> If this proposal is accepted, i would like to further propose we collapse our `BUILD` files into one target for all python tests.
>
> Note that this patch is related to https://issues.apache.org/jira/browse/AURORA-959
>
>
> Diffs
> -----
>
> src/test/python/BUILD a607f32314896213e60bdb062c31caf0056f073d
> src/test/python/apache/aurora/BUILD 82e944ad61708038bcc0fb9ddf7b4e9b5e2a49c5
> src/test/python/apache/aurora/admin/BUILD ca05c3f893b3e039d47e3dac6bf63035fd9dcd10
> src/test/python/apache/aurora/client/BUILD c9d7616d3d64e75e9ea3a66661064f6cb5e4e659
> src/test/python/apache/aurora/client/api/BUILD 2a55cec51324c18debf10a1da93a74043f288a93
> src/test/python/apache/aurora/client/cli/BUILD 6d4d5e9c40c9b3efd9d2b50fed687642c5833673
> src/test/python/apache/aurora/client/hooks/BUILD 8d43e433d825eb53b1f0154dfe5bf065f1cc2601
> src/test/python/apache/aurora/common/BUILD 7909ab5aadc9515e75a40bae169cd92365ea39b9
> src/test/python/apache/aurora/common/health_check/BUILD 98a24810bf24d9048c6d1d6ea0d166ac7f33710a
> src/test/python/apache/aurora/config/BUILD 2072422a68519c1a5304d77603c82e6b6d65cde0
> src/test/python/apache/aurora/executor/BUILD d50948a2488180ccae07e515c4cd837897f088ac
> src/test/python/apache/aurora/executor/bin/BUILD ca8b5f7d4d1bb854902ce2c39e0e207074f1eb3d
> src/test/python/apache/aurora/executor/common/BUILD 025947ee18d3bcef0da946466a107a2c89bf51a9
> src/test/python/apache/aurora/tools/BUILD c6014df89ff59352f12762cc535727acf0d065f7
> src/test/python/apache/thermos/BUILD 206fc05f8df74daff388ca6eecdfd4342e6f38aa
> src/test/python/apache/thermos/cli/BUILD e6284e38721bdf946e2a5f484accb11e9062fdf4
> src/test/python/apache/thermos/common/BUILD 460c82e7dc8f1eb0b78842434ead7081bdec55c2
> src/test/python/apache/thermos/config/BUILD f11b9eea93942ce6a934b51a9d10d46d387d0596
> src/test/python/apache/thermos/core/BUILD 93c6e107fbea9e85b1757c152ebc7616ccd96b36
> src/test/python/apache/thermos/monitoring/BUILD 514dd6c57c6113800569e1064847fff73d289f76
> src/test/python/apache/thermos/observer/BUILD aec3feb7b0f9ce92445d2c08abd9e4d101f5da20
> src/test/python/apache/thermos/observer/http/BUILD 8dc30973997a19c91f04350c8bcc479159b7eeb9
>
> Diff: https://reviews.apache.org/r/41778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41778: Simplify test BUILD files to one target per
directory.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/
-----------------------------------------------------------
(Updated Dec. 29, 2015, 2:32 p.m.)
Review request for Aurora, John Sirois and Zameer Manji.
Changes
-------
Applied this treatment to all BUILD files under src/test.
```
$ find src/test/ -name BUILD | wc -l
21
$ find src/test -name BUILD | xargs grep python_tests | wc -l
20
```
Summary (updated)
-----------------
Simplify test BUILD files to one target per directory.
Repository: aurora
Description
-------
I'm using this file as a proposed convention for test targets in `BUILD` files. In addition to being less redundant, i find the resulting file much easier to understand. In the past when refactoring, i can find it nightmarish to go back and bring all the build targets back into line (often repeating myself with imports changed in code).
If this proposal is accepted, i would like to further propose we collapse our `BUILD` files into one target for all python tests.
Note that this patch is related to https://issues.apache.org/jira/browse/AURORA-959
Diffs (updated)
-----
src/test/python/BUILD a607f32314896213e60bdb062c31caf0056f073d
src/test/python/apache/aurora/BUILD 82e944ad61708038bcc0fb9ddf7b4e9b5e2a49c5
src/test/python/apache/aurora/admin/BUILD ca05c3f893b3e039d47e3dac6bf63035fd9dcd10
src/test/python/apache/aurora/client/BUILD c9d7616d3d64e75e9ea3a66661064f6cb5e4e659
src/test/python/apache/aurora/client/api/BUILD 2a55cec51324c18debf10a1da93a74043f288a93
src/test/python/apache/aurora/client/cli/BUILD 6d4d5e9c40c9b3efd9d2b50fed687642c5833673
src/test/python/apache/aurora/client/hooks/BUILD 8d43e433d825eb53b1f0154dfe5bf065f1cc2601
src/test/python/apache/aurora/common/BUILD 7909ab5aadc9515e75a40bae169cd92365ea39b9
src/test/python/apache/aurora/common/health_check/BUILD 98a24810bf24d9048c6d1d6ea0d166ac7f33710a
src/test/python/apache/aurora/config/BUILD 2072422a68519c1a5304d77603c82e6b6d65cde0
src/test/python/apache/aurora/executor/BUILD d50948a2488180ccae07e515c4cd837897f088ac
src/test/python/apache/aurora/executor/bin/BUILD ca8b5f7d4d1bb854902ce2c39e0e207074f1eb3d
src/test/python/apache/aurora/executor/common/BUILD 025947ee18d3bcef0da946466a107a2c89bf51a9
src/test/python/apache/aurora/tools/BUILD c6014df89ff59352f12762cc535727acf0d065f7
src/test/python/apache/thermos/BUILD 206fc05f8df74daff388ca6eecdfd4342e6f38aa
src/test/python/apache/thermos/cli/BUILD e6284e38721bdf946e2a5f484accb11e9062fdf4
src/test/python/apache/thermos/common/BUILD 460c82e7dc8f1eb0b78842434ead7081bdec55c2
src/test/python/apache/thermos/config/BUILD f11b9eea93942ce6a934b51a9d10d46d387d0596
src/test/python/apache/thermos/core/BUILD 93c6e107fbea9e85b1757c152ebc7616ccd96b36
src/test/python/apache/thermos/monitoring/BUILD 514dd6c57c6113800569e1064847fff73d289f76
src/test/python/apache/thermos/observer/BUILD aec3feb7b0f9ce92445d2c08abd9e4d101f5da20
src/test/python/apache/thermos/observer/http/BUILD 8dc30973997a19c91f04350c8bcc479159b7eeb9
Diff: https://reviews.apache.org/r/41778/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 41778: Proposal: simplify test BUILD files to one
target per directory.
Posted by Bill Farner <wf...@apache.org>.
> On Dec. 29, 2015, 1:46 p.m., Bill Farner wrote:
> > src/test/python/apache/aurora/client/api/BUILD, line 81
> > <https://reviews.apache.org/r/41778/diff/1/?file=1177596#file1177596line81>
> >
> > Thinking out loud - i'm guessing this doesn't do what i want and roll up the tests within the other target. I suppose this means i would need one `python_tests` target for the directory and one `target` to roll up the others?
>
> Bill Farner wrote:
> Checked for myself and it actually does work - `python_test` targets within `dependencies` will be executed!
>
> John Sirois wrote:
> Yes, but there is really no need for test meta-targets. We can use `./pants test src/test/python/apache/aurora/client/api:` for all in this dir, `./pants test src/test/python/apache/aurora/client/api::` for everything in this dir and its children recursively, and we can mix in `--tag=-it` for just unit tests (if we add tags={'it'} to integration test targets) or `--tags=+it` for just integration tests.
Ok, since we're already doing that for jenkins (`src/{main,test}/python::`), i will remove the refernces to child targets.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/#review112220
-----------------------------------------------------------
On Dec. 29, 2015, 1:39 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2015, 1:39 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I'm using this file as a proposed convention for test targets in `BUILD` files. In addition to being less redundant, i find the resulting file much easier to understand. In the past when refactoring, i can find it nightmarish to go back and bring all the build targets back into line (often repeating myself with imports changed in code).
>
> If this proposal is accepted, i would like to further propose we collapse our `BUILD` files into one target for all python tests.
>
> Note that this patch is related to https://issues.apache.org/jira/browse/AURORA-959
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/client/api/BUILD 2a55cec51324c18debf10a1da93a74043f288a93
>
> Diff: https://reviews.apache.org/r/41778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41778: Proposal: simplify test BUILD files to one
target per directory.
Posted by Bill Farner <wf...@apache.org>.
> On Dec. 29, 2015, 1:46 p.m., Bill Farner wrote:
> > src/test/python/apache/aurora/client/api/BUILD, line 81
> > <https://reviews.apache.org/r/41778/diff/1/?file=1177596#file1177596line81>
> >
> > Thinking out loud - i'm guessing this doesn't do what i want and roll up the tests within the other target. I suppose this means i would need one `python_tests` target for the directory and one `target` to roll up the others?
Checked for myself and it actually does work - `python_test` targets within `dependencies` will be executed!
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/#review112220
-----------------------------------------------------------
On Dec. 29, 2015, 1:39 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2015, 1:39 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I'm using this file as a proposed convention for test targets in `BUILD` files. In addition to being less redundant, i find the resulting file much easier to understand. In the past when refactoring, i can find it nightmarish to go back and bring all the build targets back into line (often repeating myself with imports changed in code).
>
> If this proposal is accepted, i would like to further propose we collapse our `BUILD` files into one target for all python tests.
>
> Note that this patch is related to https://issues.apache.org/jira/browse/AURORA-959
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/client/api/BUILD 2a55cec51324c18debf10a1da93a74043f288a93
>
> Diff: https://reviews.apache.org/r/41778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41778: Proposal: simplify test BUILD files to one
target per directory.
Posted by John Sirois <jo...@gmail.com>.
> On Dec. 29, 2015, 2:46 p.m., Bill Farner wrote:
> > src/test/python/apache/aurora/client/api/BUILD, line 81
> > <https://reviews.apache.org/r/41778/diff/1/?file=1177596#file1177596line81>
> >
> > Thinking out loud - i'm guessing this doesn't do what i want and roll up the tests within the other target. I suppose this means i would need one `python_tests` target for the directory and one `target` to roll up the others?
>
> Bill Farner wrote:
> Checked for myself and it actually does work - `python_test` targets within `dependencies` will be executed!
Yes, but there is really no need for test meta-targets. We can use `./pants test src/test/python/apache/aurora/client/api:` for all in this dir, `./pants test src/test/python/apache/aurora/client/api::` for everything in this dir and its children recursively, and we can mix in `--tag=-it` for just unit tests (if we add tags={'it'} to integration test targets) or `--tags=+it` for just integration tests.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/#review112220
-----------------------------------------------------------
On Dec. 29, 2015, 2:39 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2015, 2:39 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I'm using this file as a proposed convention for test targets in `BUILD` files. In addition to being less redundant, i find the resulting file much easier to understand. In the past when refactoring, i can find it nightmarish to go back and bring all the build targets back into line (often repeating myself with imports changed in code).
>
> If this proposal is accepted, i would like to further propose we collapse our `BUILD` files into one target for all python tests.
>
> Note that this patch is related to https://issues.apache.org/jira/browse/AURORA-959
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/client/api/BUILD 2a55cec51324c18debf10a1da93a74043f288a93
>
> Diff: https://reviews.apache.org/r/41778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41778: Proposal: simplify test BUILD files to one
target per directory.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/#review112220
-----------------------------------------------------------
src/test/python/apache/aurora/client/api/BUILD (line 24)
<https://reviews.apache.org/r/41778/#comment172574>
Thinking out loud - i'm guessing this doesn't do what i want and roll up the tests within the other target. I suppose this means i would need one `python_tests` target for the directory and one `target` to roll up the others?
- Bill Farner
On Dec. 29, 2015, 1:39 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2015, 1:39 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I'm using this file as a proposed convention for test targets in `BUILD` files. In addition to being less redundant, i find the resulting file much easier to understand. In the past when refactoring, i can find it nightmarish to go back and bring all the build targets back into line (often repeating myself with imports changed in code).
>
> If this proposal is accepted, i would like to further propose we collapse our `BUILD` files into one target for all python tests.
>
> Note that this patch is related to https://issues.apache.org/jira/browse/AURORA-959
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/client/api/BUILD 2a55cec51324c18debf10a1da93a74043f288a93
>
> Diff: https://reviews.apache.org/r/41778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41778: Proposal: simplify test BUILD files to one
target per directory.
Posted by Bill Farner <wf...@apache.org>.
> On Dec. 29, 2015, 1:54 p.m., Joshua Cohen wrote:
> > src/test/python/apache/aurora/client/api/BUILD, line 16
> > <https://reviews.apache.org/r/41778/diff/1/?file=1177596#file1177596line16>
> >
> > While we're at it, can we name the test targets to match the directory (so `api` in this case)? That way we can use pants target shorthand of `./pants test src/test/python/apache/aurora/client/api` rather than having to do, e.g., `api:all`
| The main benefit of smaller target groups is faster test runs
In case it's any consolation, individual tests from PyCharm works great.
| can we name the test targets to match the directory
Absolutely.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/#review112223
-----------------------------------------------------------
On Dec. 29, 2015, 1:39 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2015, 1:39 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I'm using this file as a proposed convention for test targets in `BUILD` files. In addition to being less redundant, i find the resulting file much easier to understand. In the past when refactoring, i can find it nightmarish to go back and bring all the build targets back into line (often repeating myself with imports changed in code).
>
> If this proposal is accepted, i would like to further propose we collapse our `BUILD` files into one target for all python tests.
>
> Note that this patch is related to https://issues.apache.org/jira/browse/AURORA-959
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/client/api/BUILD 2a55cec51324c18debf10a1da93a74043f288a93
>
> Diff: https://reviews.apache.org/r/41778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41778: Proposal: simplify test BUILD files to one
target per directory.
Posted by John Sirois <jo...@gmail.com>.
> On Dec. 29, 2015, 2:54 p.m., Joshua Cohen wrote:
> > I'm generally ok with this this. The main benefit of smaller target groups is faster test runs, but tbh, I've probably spent more time looking up which smaller target has the tests I want to run than I've saved ;).
And - fwiw, the test discovery is pretty fast such that `./pants test :: -- -ktest_module_name` is good enough for a medium sized python project like this since chroots are now cached.
... except for aurora's current need to --no-fast (sealed in in pants.ini), so this is really `./pants test.pytest --fast :: -- -ktest_non_hooked_api` and there are more oddities - dup module names + pytest ... but - FWIW.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/#review112223
-----------------------------------------------------------
On Dec. 29, 2015, 2:39 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2015, 2:39 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I'm using this file as a proposed convention for test targets in `BUILD` files. In addition to being less redundant, i find the resulting file much easier to understand. In the past when refactoring, i can find it nightmarish to go back and bring all the build targets back into line (often repeating myself with imports changed in code).
>
> If this proposal is accepted, i would like to further propose we collapse our `BUILD` files into one target for all python tests.
>
> Note that this patch is related to https://issues.apache.org/jira/browse/AURORA-959
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/client/api/BUILD 2a55cec51324c18debf10a1da93a74043f288a93
>
> Diff: https://reviews.apache.org/r/41778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41778: Proposal: simplify test BUILD files to one
target per directory.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/#review112223
-----------------------------------------------------------
I'm generally ok with this this. The main benefit of smaller target groups is faster test runs, but tbh, I've probably spent more time looking up which smaller target has the tests I want to run than I've saved ;).
src/test/python/apache/aurora/client/api/BUILD (line 16)
<https://reviews.apache.org/r/41778/#comment172578>
While we're at it, can we name the test targets to match the directory (so `api` in this case)? That way we can use pants target shorthand of `./pants test src/test/python/apache/aurora/client/api` rather than having to do, e.g., `api:all`
- Joshua Cohen
On Dec. 29, 2015, 9:39 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2015, 9:39 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I'm using this file as a proposed convention for test targets in `BUILD` files. In addition to being less redundant, i find the resulting file much easier to understand. In the past when refactoring, i can find it nightmarish to go back and bring all the build targets back into line (often repeating myself with imports changed in code).
>
> If this proposal is accepted, i would like to further propose we collapse our `BUILD` files into one target for all python tests.
>
> Note that this patch is related to https://issues.apache.org/jira/browse/AURORA-959
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/client/api/BUILD 2a55cec51324c18debf10a1da93a74043f288a93
>
> Diff: https://reviews.apache.org/r/41778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41778: Proposal: simplify test BUILD files to one
target per directory.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/#review112226
-----------------------------------------------------------
Thanks for the quick feedback. Sounds like there's enough momentum for me to flesh out the patch more. Please hold ship-its until i have a more substantial version of the patch.
- Bill Farner
On Dec. 29, 2015, 1:39 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2015, 1:39 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I'm using this file as a proposed convention for test targets in `BUILD` files. In addition to being less redundant, i find the resulting file much easier to understand. In the past when refactoring, i can find it nightmarish to go back and bring all the build targets back into line (often repeating myself with imports changed in code).
>
> If this proposal is accepted, i would like to further propose we collapse our `BUILD` files into one target for all python tests.
>
> Note that this patch is related to https://issues.apache.org/jira/browse/AURORA-959
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/client/api/BUILD 2a55cec51324c18debf10a1da93a74043f288a93
>
> Diff: https://reviews.apache.org/r/41778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>