[GitHub] [skywalking] wu-sheng commented on a change in pull request #6763: fix: Receiver_zipkin missing ServiceInstanceID bug #6749

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #6763:
URL: https://github.com/apache/skywalking/pull/6763#discussion_r614026929



##########
File path: oap-server/server-receiver-plugin/zipkin-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/zipkin/trace/SpanForward.java
##########
@@ -29,15 +30,18 @@
 import org.apache.skywalking.oap.server.core.source.ServiceMeta;
 import org.apache.skywalking.oap.server.core.source.SourceReceiver;
 import org.apache.skywalking.oap.server.library.util.BooleanUtils;
+import org.apache.skywalking.oap.server.receiver.zipkin.ZipkinReceiverConfig;
 import org.apache.skywalking.oap.server.receiver.zipkin.handler.SpanEncode;
 import org.apache.skywalking.oap.server.storage.plugin.zipkin.ZipkinSpan;
 import zipkin2.Span;
 import zipkin2.codec.SpanBytesEncoder;
 
 @RequiredArgsConstructor
 public class SpanForward {
+    private static final String DEFAULT_SERVICE_INSTANCE_NAME = "Unknown_instance";

Review comment:
       ```suggestion
       private static final String DEFAULT_SERVICE_INSTANCE_NAME = " unknown_instance";
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org