You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2021/09/02 13:01:54 UTC
[GitHub] [ratis] JacksonYao287 opened a new pull request #496: RATIS-1399. should notify all the log senders Asynchronously
JacksonYao287 opened a new pull request #496:
URL: https://github.com/apache/ratis/pull/496
## What changes were proposed in this pull request?
```
//LeaderStateImpl.java
void notifySenders() {
senders.forEach(LogAppender::notifyLogAppender);
}
```
if raft , one slow log sender should not block others sender
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1399
## How was this patch tested?
no need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on pull request #496: RATIS-1399. should notify all the log senders Asynchronously
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #496:
URL: https://github.com/apache/ratis/pull/496#issuecomment-916996207
> @szetszwo i have tested this patch. i start a scm first(leader), but i find a problem when the second raft peer start(follower) that it will fail to install snapshot. i am investigating this issue. do you have any idea about this? i open a jira for this issue
> https://issues.apache.org/jira/browse/RATIS-1402
Sorry that I don't aware this problem. As you mentioned in RATIS-1402, it probably was caused by RATIS-1399.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] JacksonYao287 edited a comment on pull request #496: RATIS-1399. should notify all the log senders Asynchronously
Posted by GitBox <gi...@apache.org>.
JacksonYao287 edited a comment on pull request #496:
URL: https://github.com/apache/ratis/pull/496#issuecomment-915816721
@szetszwo i have tested this patch. i start a scm first(leader), but i find a problem when the second raft peer start(follower) that it will fail to install snapshot. i am investigating this issue. do you have any idea about this? i open a jira for this issue
https://issues.apache.org/jira/browse/RATIS-1402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] JacksonYao287 edited a comment on pull request #496: RATIS-1399. should notify all the log senders Asynchronously
Posted by GitBox <gi...@apache.org>.
JacksonYao287 edited a comment on pull request #496:
URL: https://github.com/apache/ratis/pull/496#issuecomment-912184334
@szetszwo thanks for the review, i think the logic here is correct, and i will test it in my cluster to confirm it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] JacksonYao287 commented on pull request #496: RATIS-1399. should notify all the log senders Asynchronously
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #496:
URL: https://github.com/apache/ratis/pull/496#issuecomment-911660728
@szetszwo @bshashikant @guihecheng PTAL!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] guihecheng commented on pull request #496: RATIS-1399. should notify all the log senders Asynchronously
Posted by GitBox <gi...@apache.org>.
guihecheng commented on pull request #496:
URL: https://github.com/apache/ratis/pull/496#issuecomment-912418589
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] JacksonYao287 edited a comment on pull request #496: RATIS-1399. should notify all the log senders Asynchronously
Posted by GitBox <gi...@apache.org>.
JacksonYao287 edited a comment on pull request #496:
URL: https://github.com/apache/ratis/pull/496#issuecomment-917259854
> Sorry that I don't aware this problem. As you mentioned in RATIS-1402, it probably was caused by RATIS-1399.
yea , when i test this patch , i revert RATIS-1399. i will try to fix it in RATIS-1402.
thanks @szetszwo for the review and @guihecheng for the great work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo merged pull request #496: RATIS-1399. should notify all the log senders Asynchronously
Posted by GitBox <gi...@apache.org>.
szetszwo merged pull request #496:
URL: https://github.com/apache/ratis/pull/496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] JacksonYao287 commented on pull request #496: RATIS-1399. should notify all the log senders Asynchronously
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #496:
URL: https://github.com/apache/ratis/pull/496#issuecomment-916713471
@szetszwo hi, we have tested this patch and it works as expected, the performance does not downgrade again when a follower crashes. seems we can merge this patch now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] JacksonYao287 commented on pull request #496: RATIS-1399. should notify all the log senders Asynchronously
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #496:
URL: https://github.com/apache/ratis/pull/496#issuecomment-912184334
@szetszwo thanks for the review, i think the logic here is correct, and i will test is in my cluster to confirm it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] JacksonYao287 edited a comment on pull request #496: RATIS-1399. should notify all the log senders Asynchronously
Posted by GitBox <gi...@apache.org>.
JacksonYao287 edited a comment on pull request #496:
URL: https://github.com/apache/ratis/pull/496#issuecomment-917259854
> Sorry that I don't aware this problem. As you mentioned in RATIS-1402, it probably was caused by RATIS-1399.
no , i think it is caused by RATIS-1390 not RATIS-1399. when i test this patch , i revert RATIS-1390. i will try to fix it in RATIS-1402.
thanks @szetszwo for the review and @guihecheng for the great work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on pull request #496: RATIS-1399. should notify all the log senders Asynchronously
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #496:
URL: https://github.com/apache/ratis/pull/496#issuecomment-915813611
> ..., and i will test it in my cluster to confirm it
@JacksonYao287 , have you got a chance to test it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] JacksonYao287 commented on pull request #496: RATIS-1399. should notify all the log senders Asynchronously
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #496:
URL: https://github.com/apache/ratis/pull/496#issuecomment-915816721
@szetszwo i have tested this patch. i start a scm first(leader), but i find a problem when the second raft peer start(follower) that it will fail to install snapshot. i am investigating this issue. do you have any idea about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] JacksonYao287 commented on pull request #496: RATIS-1399. should notify all the log senders Asynchronously
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #496:
URL: https://github.com/apache/ratis/pull/496#issuecomment-917259854
> Sorry that I don't aware this problem. As you mentioned in RATIS-1402, it probably was caused by RATIS-1399.
yea , when i test this patch , i revert RATIS-1399. i will try to fix it in RATIS-1402.
thanks @szetszwo for the review and @guihecheng for the great work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on pull request #496: RATIS-1399. should notify all the log senders Asynchronously
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #496:
URL: https://github.com/apache/ratis/pull/496#issuecomment-911670361
@JacksonYao287 , the change looks good. Have you tested it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org