You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/04 09:38:48 UTC
[GitHub] [spark] lipzhu opened a new pull request #28726: [SPARK-31906][SQL]Enhance comments in NamedExpression.qualifier
lipzhu opened a new pull request #28726:
URL: https://github.com/apache/spark/pull/28726
### Why are the changes needed?
The qualifier name should contains catalog name.
### Does this PR introduce _any_ user-facing change?
NO.
### How was this patch tested?
UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28726: [SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28726:
URL: https://github.com/apache/spark/pull/28726#issuecomment-641316304
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28726: [SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28726:
URL: https://github.com/apache/spark/pull/28726#discussion_r436195481
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
##########
@@ -85,6 +85,7 @@ trait NamedExpression extends Expression {
* e.g. top level attributes aliased in the SELECT clause, or column from a LocalRelation.
* 2. Seq with a Single element: either the table name or the alias name of the table.
* 3. Seq with 2 elements: database name and table name
+ * 4. Seq with 3 elements: catalog name, database name and table name
Review comment:
namespace instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28726: [SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28726:
URL: https://github.com/apache/spark/pull/28726#issuecomment-639525990
**[Test build #123568 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123568/testReport)** for PR 28726 at commit [`d7b9afe`](https://github.com/apache/spark/commit/d7b9afed6cecbeb89916733039c0d2ee90127b3d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28726: [SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28726:
URL: https://github.com/apache/spark/pull/28726#discussion_r437178386
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
##########
@@ -85,6 +85,7 @@ trait NamedExpression extends Expression {
* e.g. top level attributes aliased in the SELECT clause, or column from a LocalRelation.
* 2. Seq with a Single element: either the table name or the alias name of the table.
* 3. Seq with 2 elements: database name and table name
+ * 4. Seq with 3 elements: catalog name, database name and table name
Review comment:
Yea, it looks fine as it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #28726: [SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28726:
URL: https://github.com/apache/spark/pull/28726
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28726: [SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28726:
URL: https://github.com/apache/spark/pull/28726#issuecomment-639526674
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28726: [SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28726:
URL: https://github.com/apache/spark/pull/28726#issuecomment-639704858
**[Test build #123568 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123568/testReport)** for PR 28726 at commit [`d7b9afe`](https://github.com/apache/spark/commit/d7b9afed6cecbeb89916733039c0d2ee90127b3d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28726: [SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28726:
URL: https://github.com/apache/spark/pull/28726#issuecomment-639525452
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] lipzhu commented on a change in pull request #28726: [SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier
Posted by GitBox <gi...@apache.org>.
lipzhu commented on a change in pull request #28726:
URL: https://github.com/apache/spark/pull/28726#discussion_r437111507
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
##########
@@ -85,6 +85,7 @@ trait NamedExpression extends Expression {
* e.g. top level attributes aliased in the SELECT clause, or column from a LocalRelation.
* 2. Seq with a Single element: either the table name or the alias name of the table.
* 3. Seq with 2 elements: database name and table name
+ * 4. Seq with 3 elements: catalog name, database name and table name
Review comment:
> namespace instead?
Sorry for the late response. You mean `catalog namespace`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28726: [SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28726:
URL: https://github.com/apache/spark/pull/28726#issuecomment-639525990
**[Test build #123568 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123568/testReport)** for PR 28726 at commit [`d7b9afe`](https://github.com/apache/spark/commit/d7b9afed6cecbeb89916733039c0d2ee90127b3d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28726: [SPARK-31906][SQL]Enhance comments in NamedExpression.qualifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28726:
URL: https://github.com/apache/spark/pull/28726#issuecomment-638739503
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28726: [SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28726:
URL: https://github.com/apache/spark/pull/28726#issuecomment-639526674
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28726: [SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28726:
URL: https://github.com/apache/spark/pull/28726#issuecomment-638742571
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28726: [SPARK-31906][SQL]Enhance comments in NamedExpression.qualifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28726:
URL: https://github.com/apache/spark/pull/28726#issuecomment-638739503
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28726: [SPARK-31906][SQL]Enhance comments in NamedExpression.qualifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28726:
URL: https://github.com/apache/spark/pull/28726#issuecomment-638742571
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28726: [SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28726:
URL: https://github.com/apache/spark/pull/28726#issuecomment-639707663
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28726: [SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28726:
URL: https://github.com/apache/spark/pull/28726#issuecomment-639707663
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28726: [SPARK-31906][SQL][DOCS] Enhance comments in NamedExpression.qualifier
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28726:
URL: https://github.com/apache/spark/pull/28726#discussion_r437124960
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
##########
@@ -85,6 +85,7 @@ trait NamedExpression extends Expression {
* e.g. top level attributes aliased in the SELECT clause, or column from a LocalRelation.
* 2. Seq with a Single element: either the table name or the alias name of the table.
* 3. Seq with 2 elements: database name and table name
+ * 4. Seq with 3 elements: catalog name, database name and table name
Review comment:
I think he meant to document the namespace support in catalogV2, which is related but I think can be done separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org