You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/11/18 03:30:01 UTC
[GitHub] [incubator-doris] chaoyli opened a new issue #4918: support clang-format and clang-tidy
chaoyli opened a new issue #4918:
URL: https://github.com/apache/incubator-doris/issues/4918
Doris is short for static code format and check, it's better to add clang-format and clang-tidy.
I will add some clang-format and clang-tidy in the following patch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on issue #4918: support clang-format and clang-tidy
Posted by GitBox <gi...@apache.org>.
yangzhg commented on issue #4918:
URL: https://github.com/apache/incubator-doris/issues/4918#issuecomment-730810419
fe unittest may also be formate and tidy at this time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] sduzh removed a comment on issue #4918: support clang-format and clang-tidy
Posted by GitBox <gi...@apache.org>.
sduzh removed a comment on issue #4918:
URL: https://github.com/apache/incubator-doris/issues/4918#issuecomment-730094898
IMHO, formatting the whole codebase at once would be more friendly for other contributors, since they can just focus on their newly added code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] sduzh commented on issue #4918: support clang-format and clang-tidy
Posted by GitBox <gi...@apache.org>.
sduzh commented on issue #4918:
URL: https://github.com/apache/incubator-doris/issues/4918#issuecomment-730088927
Doris考虑先一次性把整个仓库format一下吗?
@kangkaisen @chaoyli @imay @morningman
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] sduzh commented on issue #4918: support clang-format and clang-tidy
Posted by GitBox <gi...@apache.org>.
sduzh commented on issue #4918:
URL: https://github.com/apache/incubator-doris/issues/4918#issuecomment-730094898
IMHO, formatting the whole codebase at once would be more friendly for other contributors, since they can just focus on their newly added code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] sduzh commented on issue #4918: support clang-format and clang-tidy
Posted by GitBox <gi...@apache.org>.
sduzh commented on issue #4918:
URL: https://github.com/apache/incubator-doris/issues/4918#issuecomment-730095048
> > Doris考虑先一次性把整个仓库format一下吗?
> > @kangkaisen @chaoyli @imay @morningman
>
> I think we can do it step by step.
> Format the entire code base in one time it not easy for review and code rebase.
IMHO, formatting the whole codebase at once would be more friendly for other contributors, since they can just focus on their newly added code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on issue #4918: support clang-format and clang-tidy
Posted by GitBox <gi...@apache.org>.
morningman commented on issue #4918:
URL: https://github.com/apache/incubator-doris/issues/4918#issuecomment-730090110
> Doris考虑先一次性把整个仓库format一下吗?
> @kangkaisen @chaoyli @imay @morningman
I think we can do it step by step.
Format the entire code base in one time it not easy for review and code rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org