You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/08/23 14:53:46 UTC

Re: Review Request 60594: Added a`network/ports` isolator nested container test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60594/#review183605
-----------------------------------------------------------



This patch seems out of date?

- Qian Zhang


On July 3, 2017, 6:32 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60594/
> -----------------------------------------------------------
> 
> (Updated July 3, 2017, 6:32 p.m.)
> 
> 
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7675
>     https://issues.apache.org/jira/browse/MESOS-7675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test to verify that the `network/ports` isolator works
> correctly with nested containers.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/network_ports_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60594/diff/6/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Re: Review Request 60594: Added a`network/ports` isolator nested container test.

Posted by James Peach <jp...@apache.org>.

> On Aug. 23, 2017, 2:53 p.m., Qian Zhang wrote:
> > This patch seems out of date?

Yeh, this got folded into an earlier patch during one of the patch series refactor. Dropping.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60594/#review183605
-----------------------------------------------------------


On July 3, 2017, 10:32 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60594/
> -----------------------------------------------------------
> 
> (Updated July 3, 2017, 10:32 a.m.)
> 
> 
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7675
>     https://issues.apache.org/jira/browse/MESOS-7675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test to verify that the `network/ports` isolator works
> correctly with nested containers.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/network_ports_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60594/diff/6/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>