You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by f7753 <gi...@git.apache.org> on 2016/06/20 02:03:24 UTC
[GitHub] flink pull request #2132: [FLINK-4090] Close of OutputStream should be in fi...
GitHub user f7753 opened a pull request:
https://github.com/apache/flink/pull/2132
[FLINK-4090] Close of OutputStream should be in finally clause in Fli\u2026
`try {
OutputStream out = new FileOutputStream(propertiesFile);
properties.store(out, "Generated YARN properties file");
out.close();
} catch (IOException e) {`
Move the close of out in finally clause.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/f7753/flink flink4090
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2132.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2132
----
commit 0484760557dc31dfe117dd639ffe724169eefe2b
Author: MaBiao <ma...@gmail.com>
Date: 2016-06-20T02:00:02Z
[FLINK-4090] Close of OutputStream should be in finally clause in FlinkYarnSesionCli#writeYarnProperties()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2132: [FLINK-4090] Close of OutputStream should be in finally c...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2132
Thank you for the pull request!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2132: [FLINK-4090] Close of OutputStream should be in finally c...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2132
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2132: [FLINK-4090] Close of OutputStream should be in fi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2132: [FLINK-4090] Close of OutputStream should be in finally c...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2132
Merging with a slight change to use the `Closeable` feature:
```java
try (final OutputStream out = new FileOutputStream(propertiesFile)) {
properties.store(out, "Generated YARN properties file");
} catch (IOException e) {
throw new RuntimeException("Error writing the properties file", e);
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---