You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by "zinal (via GitHub)" <gi...@apache.org> on 2023/06/18 14:27:27 UTC
[GitHub] [zeppelin] zinal opened a new pull request, #4620: Fixed minor formatting issues preventing the full build
zinal opened a new pull request, #4620:
URL: https://github.com/apache/zeppelin/pull/4620
### What is this PR for?
Fixed minor issues in Java files formatting to make maven-checkstyle-plugin happy
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
### How should this be tested?
* Regular regressions tests
### Screenshots (if appropriate)
### Questions:
* Does the license files need to update?
* Is there breaking changes for older versions?
* Does this needs documentation?
No license updates, no breaking changes, no need for extra docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer merged pull request #4620: Fixed minor formatting issues preventing the full build
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer merged PR #4620:
URL: https://github.com/apache/zeppelin/pull/4620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zinal commented on pull request #4620: Fixed minor formatting issues preventing the full build
Posted by "zinal (via GitHub)" <gi...@apache.org>.
zinal commented on PR #4620:
URL: https://github.com/apache/zeppelin/pull/4620#issuecomment-1596187342
> I see. Which Maven command did you run?
mvn clean package -DskipTests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4620: Fixed minor formatting issues preventing the full build
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4620:
URL: https://github.com/apache/zeppelin/pull/4620#issuecomment-1596187009
I see. Which Maven command did you run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4620: Fixed minor formatting issues preventing the full build
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4620:
URL: https://github.com/apache/zeppelin/pull/4620#issuecomment-1596181619
I think it would be good if with this fix the checkstyle plugin is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4620: Fixed minor formatting issues preventing the full build
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4620:
URL: https://github.com/apache/zeppelin/pull/4620#issuecomment-1596241260
Thank you, I can reproduce the issue.
Can you change the Goal `package` to `verify` in the following line? Then the CI system should run checkstyle. Unfortunately the phase `package` is not enough.
https://github.com/apache/zeppelin/blob/1e9c7fd0496f13b73c26dc3eef254c90c4a70ee7/.github/workflows/core.yml#L486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zinal commented on pull request #4620: Fixed minor formatting issues preventing the full build
Posted by "zinal (via GitHub)" <gi...@apache.org>.
zinal commented on PR #4620:
URL: https://github.com/apache/zeppelin/pull/4620#issuecomment-1596182691
> I think it would be good if with this fix the checkstyle plugin is enabled.
It seems to be enabled, at least it was complaining without the fixes when I followed the general build instructions from the [docs](https://zeppelin.apache.org/docs/0.10.1/setup/basics/how_to_build.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4620: Fixed minor formatting issues preventing the full build
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4620:
URL: https://github.com/apache/zeppelin/pull/4620#issuecomment-1596191919
I am surprised that there are no errors in the CI.
Do you see errors in the CI system? Maybe we should adjust the default build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org