[GitHub] [pinot] somandal commented on pull request #10408: [multistage] Implement ordering for SortExchange

["somandal (via GitHub)" <gi...@apache.org>]

somandal commented on PR #10408:
URL: https://github.com/apache/pinot/pull/10408#issuecomment-1469357647

   > i have some concerns regarding how the mailbox (1) handles received block; (2) what should be returned when normal block or error block is being received. please kindly take a look
   
   Hey @walterddr can you check if I addressed your comments in this area correctly? We can discuss this some more if required.
   
   Basically made changes to:
   1) Clear the `_priorityQueue` when an error block is received / returned.
   2) Always return a no-op when a block is received and the contents are added to the `_priorityQueue`. Earlier I was waiting for all the mailboxes to get processed in the loop before returning a no-op, now I return a no-op immediately for each mailbox.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org