You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "valepakh (via GitHub)" <gi...@apache.org> on 2025/11/27 13:57:07 UTC
[PR] IGNITE-27199 Support patch versions for deployments [ignite-3]
valepakh opened a new pull request, #7104:
URL: https://github.com/apache/ignite-3/pull/7104
https://issues.apache.org/jira/browse/IGNITE-27199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27199 Support patch versions for deployments [ignite-3]
Posted by "Pochatkin (via GitHub)" <gi...@apache.org>.
Pochatkin merged PR #7104:
URL: https://github.com/apache/ignite-3/pull/7104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27199 Support patch versions for deployments [ignite-3]
Posted by "valepakh (via GitHub)" <gi...@apache.org>.
valepakh commented on code in PR #7104:
URL: https://github.com/apache/ignite-3/pull/7104#discussion_r2571760366
##########
modules/api/src/main/java/org/apache/ignite/lang/SemanticVersion.java:
##########
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.lang;
+
+import java.util.Objects;
+import java.util.StringJoiner;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Class representing a <a href="https://semver.org/spec/v2.0.0.html">semantic version</a>.
+ */
+public class SemanticVersion implements Comparable<SemanticVersion> {
Review Comment:
While ideally yes we need one, it would be a copy of `IgniteProductVersionTest` but more verbose (since there's no parsing method) so I don't want to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-27199 Support patch versions for deployments [ignite-3]
Posted by "nevdmitry (via GitHub)" <gi...@apache.org>.
nevdmitry commented on code in PR #7104:
URL: https://github.com/apache/ignite-3/pull/7104#discussion_r2571663750
##########
modules/core/src/test/java/org/apache/ignite/internal/properties/IgniteProductVersionTest.java:
##########
@@ -108,7 +70,7 @@ void testCompareTo(IgniteProductVersion v1, IgniteProductVersion v2, int expecte
assertThat(Integer.signum(v1.compareTo(v2)), is(expected));
}
- static Stream<Arguments> versionCompareProvider() {
+ private static Stream<Arguments> versionCompareProvider() {
Review Comment:
don't see `patch` comparison
##########
modules/api/src/main/java/org/apache/ignite/lang/SemanticVersion.java:
##########
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.lang;
+
+import java.util.Objects;
+import java.util.StringJoiner;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Class representing a <a href="https://semver.org/spec/v2.0.0.html">semantic version</a>.
+ */
+public class SemanticVersion implements Comparable<SemanticVersion> {
Review Comment:
do we need separate unit for SemanticVersion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org