DO NOT REPLY [Bug 11540] - ProxyTimeout ignored

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=11540>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=11540


maxes@sw.ru changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|2.0.39                      |2.0-HEAD




------- Additional Comments From maxes@sw.ru  2004-11-23 14:18 -------
Timeout for socket in case of proxy request set in modules/proxy/mod_proxy.c    
by function ap_proxy_connect_to_backend():

        /* Set a timeout on the socket */
        if (conf->timeout_set == 1) {
            apr_socket_timeout_set(*newsock, conf->timeout);
        }
        else {
             apr_socket_timeout_set(*newsock, s->timeout);
        }

GDB show, that conf->timeout_set is 0, and timeout get from global config
(from "Timeout" directive).

Note, that other *_set variable never used in mod_proxy* for check
something.

I don't know why conf->timeout_set is zero in ap_proxy_connect_to_backend().

May be need compared 2 functions from
modules/proxy/mod_proxy.c:
create_proxy_config and merge_proxy_config

Check this:
ps->timeout= (overrides->timeout_set == 0) ? base->timeout : overrides->timeout;
If overrides->timeout_set equal 0, than ps->timeout setted, but may be we
need set too :
   ps->timeout_set = 1; 
  /* because timeout set always, timeout_set is always setted */
?

But probably we don't need use *_set variable anywhere in proxy_utils to
check.

next patch work in my environment:
diff -u  modules/proxy/proxy_util.c.save  modules/proxy/proxy_util.c
--- modules/proxy/proxy_util.c.save     Tue Nov 23 14:47:48 2004
+++ modules/proxy/proxy_util.c  Tue Nov 23 14:48:46 2004
@@ -1128,7 +1128,7 @@
 #endif
 
         /* Set a timeout on the socket */
-        if (conf->timeout_set == 1) {
+        if (conf->timeout != 0) {
             apr_socket_timeout_set(*newsock, conf->timeout);
         }
         else {



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org