You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/13 08:32:15 UTC
[GitHub] [apisix-helm-chart] mangoGoForward opened a new pull request, #285: feat: Support auto-generate random `admin/view` key
mangoGoForward opened a new pull request, #285:
URL: https://github.com/apache/apisix-helm-chart/pull/285
Signed-off-by: mango <xu...@foxmail.com>
Fixed: #255
Use helm template string function: [randAlphaNum, randAlpha, randNumeric, and randAscii](https://helm.sh/docs/chart_template_guide/function_list/#randalphanum-randalpha-randnumeric-and-randascii) to generate password/admin-view key, and print it to helm NOTES.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #285: feat: Support auto-generate random `admin/view` key
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #285:
URL: https://github.com/apache/apisix-helm-chart/pull/285#discussion_r872161706
##########
charts/apisix-dashboard/values.yaml:
##########
@@ -76,6 +76,7 @@ config:
authentication:
secert: secert
expireTime: 3600
+ userCreate: true
Review Comment:
Better to update the README. Describe the meaning of this field, what's more, tell users that the Admin API key and APISIX Dashboard username, and password will be generated randomly the first time they install the release.
Also, a guide about how to show the credentials is suggested to write so that users know how can they see the credentials.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #285: feat: Support auto-generate random `admin/view` key
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #285:
URL: https://github.com/apache/apisix-helm-chart/pull/285#discussion_r874276587
##########
charts/apisix-dashboard/values.yaml:
##########
@@ -76,6 +76,7 @@ config:
authentication:
secert: secert
expireTime: 3600
+ userCreate: true
Review Comment:
> I have no good idea how to consistent the admin key between apisix and apisix-ingress-controller, because it is different when quote the variable twice, so we must get it from configmap when apisix installed.
Maybe we can tell users to install apisix-ingress-controller with --set config.apisix.adminKey filed which can execute the command kubectl get cm {{ include "apisix.fullname" . }} -n {{ .Release.Namespace }} -o=jsonpath={.data} | sed -nr '/- name: "admin"/,+2 p' | awk -F": " '/key/{print $2}' to get.
But the case is we install APISIX and Ingress Controller **at the same time**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] mangoGoForward commented on a diff in pull request #285: feat: Support auto-generate random `admin/view` key
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on code in PR #285:
URL: https://github.com/apache/apisix-helm-chart/pull/285#discussion_r872182265
##########
charts/apisix-dashboard/values.yaml:
##########
@@ -76,6 +76,7 @@ config:
authentication:
secert: secert
expireTime: 3600
+ userCreate: true
Review Comment:
Done, and the step two in `NOTES.txt` will be tell users know how to get the credentials or account.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] mangoGoForward commented on a diff in pull request #285: [WIP]feat: Support auto-generate random `admin/view` key
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on code in PR #285:
URL: https://github.com/apache/apisix-helm-chart/pull/285#discussion_r877655860
##########
charts/apisix-dashboard/values.yaml:
##########
@@ -76,6 +76,7 @@ config:
authentication:
secert: secert
expireTime: 3600
+ userCreate: true
Review Comment:
Hi, @tokers @tao12345666333
I've tried some ways to solve he admin key consistent between `APISIX` and `Ingress Controller`, but failed.
each time I execute it and will get a new value, so we must get it from `configmap` when `APISIX` installed, but this way cannot suite the case install APISIX and Ingress Controller at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #285: feat: Support auto-generate random `admin/view` key
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #285:
URL: https://github.com/apache/apisix-helm-chart/pull/285#discussion_r874277643
##########
charts/apisix-dashboard/values.yaml:
##########
@@ -76,6 +76,7 @@ config:
authentication:
secert: secert
expireTime: 3600
+ userCreate: true
Review Comment:
@mangoGoForward It's my understanding that the admin key should be generated automatically on APISIX side, since APISIX is the Admin API provider while APISIX Ingress Controller is just a caller so the latter should refer to the position that the former saves the API key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] Gallardot commented on a diff in pull request #285: feat: Support auto-generate random `admin/view` key
Posted by GitBox <gi...@apache.org>.
Gallardot commented on code in PR #285:
URL: https://github.com/apache/apisix-helm-chart/pull/285#discussion_r873123170
##########
charts/apisix-dashboard/values.yaml:
##########
@@ -76,6 +76,7 @@ config:
authentication:
secert: secert
expireTime: 3600
+ userCreate: true
Review Comment:
If I [install `apisix-ingress-controller`]( https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml#L405) at the same time through subchart, how can I ensure that this [key](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-ingress-controller/values.yaml#L128) is consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] mangoGoForward commented on a diff in pull request #285: feat: Support auto-generate random `admin/view` key
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on code in PR #285:
URL: https://github.com/apache/apisix-helm-chart/pull/285#discussion_r873378272
##########
charts/apisix-dashboard/values.yaml:
##########
@@ -76,6 +76,7 @@ config:
authentication:
secert: secert
expireTime: 3600
+ userCreate: true
Review Comment:
> If I [install `apisix-ingress-controller`](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml#L405) at the same time through subchart, how can I ensure that this [key](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-ingress-controller/values.yaml#L128) is consistent?
I got your meaning and let me fix, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] mangoGoForward commented on a diff in pull request #285: feat: Support auto-generate random `admin/view` key
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on code in PR #285:
URL: https://github.com/apache/apisix-helm-chart/pull/285#discussion_r873549505
##########
charts/apisix-dashboard/values.yaml:
##########
@@ -76,6 +76,7 @@ config:
authentication:
secert: secert
expireTime: 3600
+ userCreate: true
Review Comment:
I have no good idea how to consistent the admin key between `apisix` and `apisix-ingress-controller`, because it is different when quote the variable twice, so we must get it from `configmap` when `apisix` installed.
Maybe we can tell users to install `apisix-ingress-controller` with `--set config.apisix.adminKey` filed which can execute the command `kubectl get cm {{ include "apisix.fullname" . }} -n {{ .Release.Namespace }} -o=jsonpath={.data} | sed -nr '/- name: "admin"/,+2 p' | awk -F": " '/key/{print $2}'` to get.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #285: feat: Support auto-generate random `admin/view` key
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #285:
URL: https://github.com/apache/apisix-helm-chart/pull/285#discussion_r873159975
##########
charts/apisix-dashboard/values.yaml:
##########
@@ -76,6 +76,7 @@ config:
authentication:
secert: secert
expireTime: 3600
+ userCreate: true
Review Comment:
>
I didn't capture the meaning? APISIX Ingress Controller doesn't use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org