[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #440: [ISSUE #374]add test case.

[GitBox <gi...@apache.org>]

ruanwenjun commented on a change in pull request #440:
URL: https://github.com/apache/incubator-eventmesh/pull/440#discussion_r670554133



##########
File path: build.gradle
##########
@@ -123,7 +123,8 @@ subprojects {
     ]
 
     List junit = [
-            "junit:junit:4.12"
+            "junit:junit:4.12",
+            "com.github.stefanbirkner:system-rules:1.16.1"

Review comment:
       This dependency is use [`Common Public License 1.0 `](https://github.com/stefanbirkner/system-rules/blob/master/LICENSE), I think we can use here, but this need PPMC to confirm.
   By the way, I don't see this jar used at your pr, if it is not used, I don't recommend adding this dependency.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org