You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/28 00:22:00 UTC

[GitHub] [beam] lukecwik commented on a change in pull request #11199: [BEAM-9562][WIP] Update Timer encoding with respect of dynamic timers

lukecwik commented on a change in pull request #11199: [BEAM-9562][WIP] Update Timer encoding with respect of dynamic timers
URL: https://github.com/apache/beam/pull/11199#discussion_r399587568
 
 

 ##########
 File path: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/ParDoTranslation.java
 ##########
 @@ -197,7 +199,7 @@ public boolean canTranslate(PTransform<?, ?> pTransform) {
                     ((KvCoder) mainInput.getCoder()).getKeyCoder(),
                     // TODO: Add support for timer payloads to the SDK
                     // We currently assume that all payloads are unspecified.
-                    Timer.Coder.of(VoidCoder.of())));
+                    Timer.Coder.of(StringUtf8Coder.of(), GlobalWindow.Coder.INSTANCE)));
 
 Review comment:
   ```suggestion
                       Timer.Coder.of(((KvCoder) mainInput.getCoder()).getKeyCoder(), GlobalWindow.Coder.INSTANCE)));
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services