You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/22 11:08:48 UTC
[GitHub] [incubator-yunikorn-k8shim] pbacsko commented on a change in pull request #392: [YUNIKORN-1140] Update e2e tests to work with new REST API changes
pbacsko commented on a change in pull request #392:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/392#discussion_r832047633
##########
File path: test/e2e/framework/helpers/yunikorn/yk_utils.go
##########
@@ -19,34 +19,26 @@
package yunikorn
import (
- "errors"
"fmt"
- "regexp"
"github.com/apache/incubator-yunikorn-k8shim/test/e2e/framework/configmanager"
)
type ResourceUsage struct {
- memory string
- vCPU string
+ memory int64
+ vCPU int64
Review comment:
Really just a nit... do these have to be `int64`? Can't we just use normal `int`?
##########
File path: test/e2e/framework/helpers/yunikorn/yk_utils.go
##########
@@ -19,34 +19,26 @@
package yunikorn
import (
- "errors"
"fmt"
- "regexp"
"github.com/apache/incubator-yunikorn-k8shim/test/e2e/framework/configmanager"
)
type ResourceUsage struct {
- memory string
- vCPU string
+ memory int64
+ vCPU int64
Review comment:
Really a nit... do these have to be `int64`? Can't we just use normal `int`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org