[GitHub] [sling-org-apache-sling-discovery-oak] stefan-egli commented on a diff in pull request #9: SLING-11355: sling discovery bundles: update to sling 48

[GitBox <gi...@apache.org>]

stefan-egli commented on code in PR #9:
URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/9#discussion_r929048334


##########
src/main/java/org/apache/sling/discovery/oak/SynchronizedClocksHealthCheck.java:
##########
@@ -54,12 +50,12 @@
  * info</li>
  * </ul>
  */
-@Component(immediate = true, metatype = true, label = "Apache Sling Discovery Oak Synchronized Clocks Health Check")
-@Properties({
-        @Property(name = HealthCheck.NAME, value = "Synchronized Clocks", description = "Health Check name", label = "Name"),
-        @Property(name = HealthCheck.TAGS, unbounded = PropertyUnbounded.ARRAY, description = "Health Check tags", label = "Tags"),
-        @Property(name = HealthCheck.MBEAN_NAME, value = "slingDiscoveryOakSynchronizedClocks", description = "Health Check MBean name", label = "MBean name") })
-@Service(value = HealthCheck.class)
+@Component(immediate = true, service = HealthCheck.class,
+        property = {
+                HealthCheck.NAME + "=Synchronized Clocks",
+                HealthCheck.MBEAN_NAME + "=slingDiscoveryOakSynchronizedClocks"
+        })
+        //label = "Apache Sling Discovery Oak Synchronized Clocks Health Check")

Review Comment:
   did the `label`s  get lost in translation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org