You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Himanshu Gahlaut <ga...@gmail.com> on 2015/07/31 13:35:04 UTC
Review Request 36984: LENS-700: Execute Async shall do semantic
validation, rewrite,
select driver and estimate cost before accepting a query for asynchronous
execution
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36984/
-----------------------------------------------------------
Review request for lens.
Repository: lens
Description
-------
LENS-700: Execute Async shall do semantic validation, rewrite, select driver and estimate cost before accepting a query for asynchronous execution
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d6822f6b116f07dd9a204bdf5a7c8ee7671d5
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 28ff92059b0c3040dcb54811c39a59bf684c0f6b
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b5235ad5a799cb54c27bb2449478c4e9ef593bc0
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 80e29ba114dbde97ab932027c7946315cdafb9c6
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java f1461bc2bd2c89836c26fd3445988009b25c6b18
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 4b9962a9cda22002cdc4826ebce3db4c77216223
Diff: https://reviews.apache.org/r/36984/diff/
Testing
-------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [4.881s]
[INFO] Lens .............................................. SUCCESS [4.588s]
[INFO] Lens API .......................................... SUCCESS [44.023s]
[INFO] Lens API for server and extensions ................ SUCCESS [32.745s]
[INFO] Lens Cube ......................................... SUCCESS [7:39.032s]
[INFO] Lens DB storage ................................... SUCCESS [1:41.287s]
[INFO] Lens Query Library ................................ SUCCESS [20.810s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:40.758s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [48.890s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [26.143s]
[INFO] Lens Server ....................................... SUCCESS [13:20.335s]
[INFO] Lens client ....................................... SUCCESS [53.538s]
[INFO] Lens CLI .......................................... SUCCESS [4:31.457s]
[INFO] Lens Examples ..................................... SUCCESS [16.966s]
[INFO] Lens Distribution ................................. SUCCESS [20.166s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:20.115s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [5.550s]
[INFO] Lens Regression ................................... SUCCESS [17.419s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:09.849s
[INFO] Finished at: Fri Jul 31 17:03:15 IST 2015
[INFO] Final Memory: 127M/412M
[INFO] ------------------------------------------------------------------------
Thanks,
Himanshu Gahlaut
Re: Review Request 36984: LENS-700: Execute Async shall do semantic
validation, rewrite,
select driver and estimate cost before accepting a query for asynchronous
execution
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36984/#review94190
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Aug. 4, 2015, 6:04 p.m., Himanshu Gahlaut wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36984/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 6:04 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-700: Addressed code review comments
>
>
> LENS-700: Fixing test cases after addition of failing driver
>
>
> Diffs
> -----
>
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java ea2433636282d0e6fdfabfb34c4421e68a125291
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d6822f6b116f07dd9a204bdf5a7c8ee7671d5
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 28ff92059b0c3040dcb54811c39a59bf684c0f6b
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b5235ad5a799cb54c27bb2449478c4e9ef593bc0
> lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 80e29ba114dbde97ab932027c7946315cdafb9c6
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java f1461bc2bd2c89836c26fd3445988009b25c6b18
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 4b9962a9cda22002cdc4826ebce3db4c77216223
> lens-server/src/test/resources/failing-query-driver-site.xml PRE-CREATION
> lens-server/src/test/resources/lens-site.xml bd9382820d59ecdc075d1f9b7258e31f899ca6d5
>
> Diff: https://reviews.apache.org/r/36984/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [9.078s]
> [INFO] Lens .............................................. SUCCESS [10.947s]
> [INFO] Lens API .......................................... SUCCESS [36.928s]
> [INFO] Lens API for server and extensions ................ SUCCESS [30.843s]
> [INFO] Lens Cube ......................................... SUCCESS [8:08.461s]
> [INFO] Lens DB storage ................................... SUCCESS [44.141s]
> [INFO] Lens Query Library ................................ SUCCESS [35.886s]
> [INFO] Lens Hive Driver .................................. SUCCESS [12:52.309s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [1:05.896s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [20.969s]
> [INFO] Lens Server ....................................... SUCCESS [18:21.693s]
> [INFO] Lens client ....................................... SUCCESS [1:06.921s]
> [INFO] Lens CLI .......................................... SUCCESS [8:41.236s]
> [INFO] Lens Examples ..................................... SUCCESS [14.389s]
> [INFO] Lens Distribution ................................. SUCCESS [15.593s]
> [INFO] Lens ML Lib ....................................... SUCCESS [3:46.342s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.116s]
> [INFO] Lens Regression ................................... SUCCESS [16.175s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 58:05.001s
> [INFO] Finished at: Tue Aug 04 23:26:47 IST 2015
> [INFO] Final Memory: 124M/407M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Himanshu Gahlaut
>
>
Re: Review Request 36984: LENS-700: Execute Async shall do semantic
validation, rewrite,
select driver and estimate cost before accepting a query for asynchronous
execution
Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36984/
-----------------------------------------------------------
(Updated Aug. 5, 2015, 5:47 a.m.)
Review request for lens.
Bugs: LENS-700
https://issues.apache.org/jira/browse/LENS-700
Repository: lens
Description
-------
LENS-700: Addressed code review comments
LENS-700: Fixing test cases after addition of failing driver
Diffs
-----
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java ea2433636282d0e6fdfabfb34c4421e68a125291
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d6822f6b116f07dd9a204bdf5a7c8ee7671d5
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 28ff92059b0c3040dcb54811c39a59bf684c0f6b
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b5235ad5a799cb54c27bb2449478c4e9ef593bc0
lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 80e29ba114dbde97ab932027c7946315cdafb9c6
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java f1461bc2bd2c89836c26fd3445988009b25c6b18
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 4b9962a9cda22002cdc4826ebce3db4c77216223
lens-server/src/test/resources/failing-query-driver-site.xml PRE-CREATION
lens-server/src/test/resources/lens-site.xml bd9382820d59ecdc075d1f9b7258e31f899ca6d5
Diff: https://reviews.apache.org/r/36984/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [9.078s]
[INFO] Lens .............................................. SUCCESS [10.947s]
[INFO] Lens API .......................................... SUCCESS [36.928s]
[INFO] Lens API for server and extensions ................ SUCCESS [30.843s]
[INFO] Lens Cube ......................................... SUCCESS [8:08.461s]
[INFO] Lens DB storage ................................... SUCCESS [44.141s]
[INFO] Lens Query Library ................................ SUCCESS [35.886s]
[INFO] Lens Hive Driver .................................. SUCCESS [12:52.309s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [1:05.896s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [20.969s]
[INFO] Lens Server ....................................... SUCCESS [18:21.693s]
[INFO] Lens client ....................................... SUCCESS [1:06.921s]
[INFO] Lens CLI .......................................... SUCCESS [8:41.236s]
[INFO] Lens Examples ..................................... SUCCESS [14.389s]
[INFO] Lens Distribution ................................. SUCCESS [15.593s]
[INFO] Lens ML Lib ....................................... SUCCESS [3:46.342s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [6.116s]
[INFO] Lens Regression ................................... SUCCESS [16.175s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 58:05.001s
[INFO] Finished at: Tue Aug 04 23:26:47 IST 2015
[INFO] Final Memory: 124M/407M
[INFO] ------------------------------------------------------------------------
Thanks,
Himanshu Gahlaut
Re: Review Request 36984: LENS-700: Execute Async shall do semantic
validation, rewrite,
select driver and estimate cost before accepting a query for asynchronous
execution
Posted by Himanshu Gahlaut <ga...@gmail.com>.
> On Aug. 5, 2015, 4:45 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java, line 97
> > <https://reviews.apache.org/r/36984/diff/3/?file=1028818#file1028818line97>
> >
> > Whats the purpose of this configuration?
https://github.com/apache/incubator-lens/blob/master/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java#L1297
There is an assert here which is trying to ensure that all drivers have their site files loaded.
- Himanshu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36984/#review94182
-----------------------------------------------------------
On Aug. 4, 2015, 6:04 p.m., Himanshu Gahlaut wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36984/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 6:04 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-700: Addressed code review comments
>
>
> LENS-700: Fixing test cases after addition of failing driver
>
>
> Diffs
> -----
>
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java ea2433636282d0e6fdfabfb34c4421e68a125291
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d6822f6b116f07dd9a204bdf5a7c8ee7671d5
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 28ff92059b0c3040dcb54811c39a59bf684c0f6b
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b5235ad5a799cb54c27bb2449478c4e9ef593bc0
> lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 80e29ba114dbde97ab932027c7946315cdafb9c6
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java f1461bc2bd2c89836c26fd3445988009b25c6b18
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 4b9962a9cda22002cdc4826ebce3db4c77216223
> lens-server/src/test/resources/failing-query-driver-site.xml PRE-CREATION
> lens-server/src/test/resources/lens-site.xml bd9382820d59ecdc075d1f9b7258e31f899ca6d5
>
> Diff: https://reviews.apache.org/r/36984/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [9.078s]
> [INFO] Lens .............................................. SUCCESS [10.947s]
> [INFO] Lens API .......................................... SUCCESS [36.928s]
> [INFO] Lens API for server and extensions ................ SUCCESS [30.843s]
> [INFO] Lens Cube ......................................... SUCCESS [8:08.461s]
> [INFO] Lens DB storage ................................... SUCCESS [44.141s]
> [INFO] Lens Query Library ................................ SUCCESS [35.886s]
> [INFO] Lens Hive Driver .................................. SUCCESS [12:52.309s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [1:05.896s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [20.969s]
> [INFO] Lens Server ....................................... SUCCESS [18:21.693s]
> [INFO] Lens client ....................................... SUCCESS [1:06.921s]
> [INFO] Lens CLI .......................................... SUCCESS [8:41.236s]
> [INFO] Lens Examples ..................................... SUCCESS [14.389s]
> [INFO] Lens Distribution ................................. SUCCESS [15.593s]
> [INFO] Lens ML Lib ....................................... SUCCESS [3:46.342s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.116s]
> [INFO] Lens Regression ................................... SUCCESS [16.175s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 58:05.001s
> [INFO] Finished at: Tue Aug 04 23:26:47 IST 2015
> [INFO] Final Memory: 124M/407M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Himanshu Gahlaut
>
>
Re: Review Request 36984: LENS-700: Execute Async shall do semantic
validation, rewrite,
select driver and estimate cost before accepting a query for asynchronous
execution
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36984/#review94182
-----------------------------------------------------------
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java (line 97)
<https://reviews.apache.org/r/36984/#comment148724>
Whats the purpose of this configuration?
Other changes look good.
- Amareshwari Sriramadasu
On Aug. 4, 2015, 6:04 p.m., Himanshu Gahlaut wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36984/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 6:04 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-700: Addressed code review comments
>
>
> LENS-700: Fixing test cases after addition of failing driver
>
>
> Diffs
> -----
>
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java ea2433636282d0e6fdfabfb34c4421e68a125291
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d6822f6b116f07dd9a204bdf5a7c8ee7671d5
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 28ff92059b0c3040dcb54811c39a59bf684c0f6b
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b5235ad5a799cb54c27bb2449478c4e9ef593bc0
> lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 80e29ba114dbde97ab932027c7946315cdafb9c6
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java f1461bc2bd2c89836c26fd3445988009b25c6b18
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 4b9962a9cda22002cdc4826ebce3db4c77216223
> lens-server/src/test/resources/failing-query-driver-site.xml PRE-CREATION
> lens-server/src/test/resources/lens-site.xml bd9382820d59ecdc075d1f9b7258e31f899ca6d5
>
> Diff: https://reviews.apache.org/r/36984/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [9.078s]
> [INFO] Lens .............................................. SUCCESS [10.947s]
> [INFO] Lens API .......................................... SUCCESS [36.928s]
> [INFO] Lens API for server and extensions ................ SUCCESS [30.843s]
> [INFO] Lens Cube ......................................... SUCCESS [8:08.461s]
> [INFO] Lens DB storage ................................... SUCCESS [44.141s]
> [INFO] Lens Query Library ................................ SUCCESS [35.886s]
> [INFO] Lens Hive Driver .................................. SUCCESS [12:52.309s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [1:05.896s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [20.969s]
> [INFO] Lens Server ....................................... SUCCESS [18:21.693s]
> [INFO] Lens client ....................................... SUCCESS [1:06.921s]
> [INFO] Lens CLI .......................................... SUCCESS [8:41.236s]
> [INFO] Lens Examples ..................................... SUCCESS [14.389s]
> [INFO] Lens Distribution ................................. SUCCESS [15.593s]
> [INFO] Lens ML Lib ....................................... SUCCESS [3:46.342s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.116s]
> [INFO] Lens Regression ................................... SUCCESS [16.175s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 58:05.001s
> [INFO] Finished at: Tue Aug 04 23:26:47 IST 2015
> [INFO] Final Memory: 124M/407M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Himanshu Gahlaut
>
>
Re: Review Request 36984: LENS-700: Execute Async shall do semantic
validation, rewrite,
select driver and estimate cost before accepting a query for asynchronous
execution
Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36984/
-----------------------------------------------------------
(Updated Aug. 4, 2015, 6:04 p.m.)
Review request for lens.
Changes
-------
Fixed test cases. Tested again. All test cases passed.
Repository: lens
Description (updated)
-------
LENS-700: Addressed code review comments
LENS-700: Fixing test cases after addition of failing driver
Diffs (updated)
-----
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java ea2433636282d0e6fdfabfb34c4421e68a125291
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d6822f6b116f07dd9a204bdf5a7c8ee7671d5
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 28ff92059b0c3040dcb54811c39a59bf684c0f6b
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b5235ad5a799cb54c27bb2449478c4e9ef593bc0
lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 80e29ba114dbde97ab932027c7946315cdafb9c6
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java f1461bc2bd2c89836c26fd3445988009b25c6b18
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 4b9962a9cda22002cdc4826ebce3db4c77216223
lens-server/src/test/resources/failing-query-driver-site.xml PRE-CREATION
lens-server/src/test/resources/lens-site.xml bd9382820d59ecdc075d1f9b7258e31f899ca6d5
Diff: https://reviews.apache.org/r/36984/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [9.078s]
[INFO] Lens .............................................. SUCCESS [10.947s]
[INFO] Lens API .......................................... SUCCESS [36.928s]
[INFO] Lens API for server and extensions ................ SUCCESS [30.843s]
[INFO] Lens Cube ......................................... SUCCESS [8:08.461s]
[INFO] Lens DB storage ................................... SUCCESS [44.141s]
[INFO] Lens Query Library ................................ SUCCESS [35.886s]
[INFO] Lens Hive Driver .................................. SUCCESS [12:52.309s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [1:05.896s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [20.969s]
[INFO] Lens Server ....................................... SUCCESS [18:21.693s]
[INFO] Lens client ....................................... SUCCESS [1:06.921s]
[INFO] Lens CLI .......................................... SUCCESS [8:41.236s]
[INFO] Lens Examples ..................................... SUCCESS [14.389s]
[INFO] Lens Distribution ................................. SUCCESS [15.593s]
[INFO] Lens ML Lib ....................................... SUCCESS [3:46.342s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [6.116s]
[INFO] Lens Regression ................................... SUCCESS [16.175s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 58:05.001s
[INFO] Finished at: Tue Aug 04 23:26:47 IST 2015
[INFO] Final Memory: 124M/407M
[INFO] ------------------------------------------------------------------------
Thanks,
Himanshu Gahlaut
Re: Review Request 36984: LENS-700: Execute Async shall do semantic
validation, rewrite,
select driver and estimate cost before accepting a query for asynchronous
execution
Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36984/
-----------------------------------------------------------
(Updated Aug. 3, 2015, 9:34 p.m.)
Review request for lens.
Repository: lens
Description
-------
LENS-700: Addressed code review comments
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d6822f6b116f07dd9a204bdf5a7c8ee7671d5
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 28ff92059b0c3040dcb54811c39a59bf684c0f6b
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b5235ad5a799cb54c27bb2449478c4e9ef593bc0
lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 80e29ba114dbde97ab932027c7946315cdafb9c6
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java f1461bc2bd2c89836c26fd3445988009b25c6b18
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 4b9962a9cda22002cdc4826ebce3db4c77216223
lens-server/src/test/resources/lens-site.xml bd9382820d59ecdc075d1f9b7258e31f899ca6d5
Diff: https://reviews.apache.org/r/36984/diff/
Testing (updated)
-------
Will test again after rebasing with master branch.
Thanks,
Himanshu Gahlaut
Re: Review Request 36984: LENS-700: Execute Async shall do semantic
validation, rewrite,
select driver and estimate cost before accepting a query for asynchronous
execution
Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36984/
-----------------------------------------------------------
(Updated Aug. 3, 2015, 9:30 p.m.)
Review request for lens.
Repository: lens
Description (updated)
-------
LENS-700: Addressed code review comments
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d6822f6b116f07dd9a204bdf5a7c8ee7671d5
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 28ff92059b0c3040dcb54811c39a59bf684c0f6b
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b5235ad5a799cb54c27bb2449478c4e9ef593bc0
lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 80e29ba114dbde97ab932027c7946315cdafb9c6
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java f1461bc2bd2c89836c26fd3445988009b25c6b18
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 4b9962a9cda22002cdc4826ebce3db4c77216223
lens-server/src/test/resources/lens-site.xml bd9382820d59ecdc075d1f9b7258e31f899ca6d5
Diff: https://reviews.apache.org/r/36984/diff/
Testing
-------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [4.881s]
[INFO] Lens .............................................. SUCCESS [4.588s]
[INFO] Lens API .......................................... SUCCESS [44.023s]
[INFO] Lens API for server and extensions ................ SUCCESS [32.745s]
[INFO] Lens Cube ......................................... SUCCESS [7:39.032s]
[INFO] Lens DB storage ................................... SUCCESS [1:41.287s]
[INFO] Lens Query Library ................................ SUCCESS [20.810s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:40.758s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [48.890s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [26.143s]
[INFO] Lens Server ....................................... SUCCESS [13:20.335s]
[INFO] Lens client ....................................... SUCCESS [53.538s]
[INFO] Lens CLI .......................................... SUCCESS [4:31.457s]
[INFO] Lens Examples ..................................... SUCCESS [16.966s]
[INFO] Lens Distribution ................................. SUCCESS [20.166s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:20.115s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [5.550s]
[INFO] Lens Regression ................................... SUCCESS [17.419s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:09.849s
[INFO] Finished at: Fri Jul 31 17:03:15 IST 2015
[INFO] Final Memory: 127M/412M
[INFO] ------------------------------------------------------------------------
Thanks,
Himanshu Gahlaut
Re: Review Request 36984: LENS-700: Execute Async shall do semantic
validation, rewrite,
select driver and estimate cost before accepting a query for asynchronous
execution
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36984/#review93868
-----------------------------------------------------------
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
<https://reviews.apache.org/r/36984/#comment148284>
Query failure for launching can happen even now - though rewrite and select does not happen. Earlier test was depending on non existing table to trigger launch failure. Now we can have launch failures because underlying driver is down.
Can we try putting the test back with launch failures?
Here is an approach I could think :
FailingDriver {
estimate () {
if (query.contains("failing")) {
// accept by returning 0 cost.
} else {
// throw exception
}
executeAsync() {
// throw exception
}
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (line 220)
<https://reviews.apache.org/r/36984/#comment148285>
Can we add testLaunchFail() with launch failures?
- Amareshwari Sriramadasu
On July 31, 2015, 11:35 a.m., Himanshu Gahlaut wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36984/
> -----------------------------------------------------------
>
> (Updated July 31, 2015, 11:35 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-700: Execute Async shall do semantic validation, rewrite, select driver and estimate cost before accepting a query for asynchronous execution
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d6822f6b116f07dd9a204bdf5a7c8ee7671d5
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 28ff92059b0c3040dcb54811c39a59bf684c0f6b
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b5235ad5a799cb54c27bb2449478c4e9ef593bc0
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 80e29ba114dbde97ab932027c7946315cdafb9c6
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java f1461bc2bd2c89836c26fd3445988009b25c6b18
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 4b9962a9cda22002cdc4826ebce3db4c77216223
>
> Diff: https://reviews.apache.org/r/36984/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [4.881s]
> [INFO] Lens .............................................. SUCCESS [4.588s]
> [INFO] Lens API .......................................... SUCCESS [44.023s]
> [INFO] Lens API for server and extensions ................ SUCCESS [32.745s]
> [INFO] Lens Cube ......................................... SUCCESS [7:39.032s]
> [INFO] Lens DB storage ................................... SUCCESS [1:41.287s]
> [INFO] Lens Query Library ................................ SUCCESS [20.810s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:40.758s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.890s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [26.143s]
> [INFO] Lens Server ....................................... SUCCESS [13:20.335s]
> [INFO] Lens client ....................................... SUCCESS [53.538s]
> [INFO] Lens CLI .......................................... SUCCESS [4:31.457s]
> [INFO] Lens Examples ..................................... SUCCESS [16.966s]
> [INFO] Lens Distribution ................................. SUCCESS [20.166s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:20.115s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [5.550s]
> [INFO] Lens Regression ................................... SUCCESS [17.419s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:09.849s
> [INFO] Finished at: Fri Jul 31 17:03:15 IST 2015
> [INFO] Final Memory: 127M/412M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Himanshu Gahlaut
>
>
Re: Review Request 36984: LENS-700: Execute Async shall do semantic
validation, rewrite,
select driver and estimate cost before accepting a query for asynchronous
execution
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Aug. 3, 2015, 1:34 p.m., Rajat Khandelwal wrote:
> > lens-server/src/test/java/org/apache/lens/server/TestServerMode.java, line 178
> > <https://reviews.apache.org/r/36984/diff/1/?file=1026086#file1026086line178>
> >
> > Is this change needed?
>
> Himanshu Gahlaut wrote:
> Yes
Why?
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36984/#review93874
-----------------------------------------------------------
On Aug. 4, 2015, 3:04 a.m., Himanshu Gahlaut wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36984/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 3:04 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-700: Addressed code review comments
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d6822f6b116f07dd9a204bdf5a7c8ee7671d5
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 28ff92059b0c3040dcb54811c39a59bf684c0f6b
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b5235ad5a799cb54c27bb2449478c4e9ef593bc0
> lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 80e29ba114dbde97ab932027c7946315cdafb9c6
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java f1461bc2bd2c89836c26fd3445988009b25c6b18
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 4b9962a9cda22002cdc4826ebce3db4c77216223
> lens-server/src/test/resources/lens-site.xml bd9382820d59ecdc075d1f9b7258e31f899ca6d5
>
> Diff: https://reviews.apache.org/r/36984/diff/
>
>
> Testing
> -------
>
> Will test again after rebasing with master branch.
>
>
> Thanks,
>
> Himanshu Gahlaut
>
>
Re: Review Request 36984: LENS-700: Execute Async shall do semantic
validation, rewrite,
select driver and estimate cost before accepting a query for asynchronous
execution
Posted by Himanshu Gahlaut <ga...@gmail.com>.
> On Aug. 3, 2015, 8:04 a.m., Rajat Khandelwal wrote:
> > lens-server/src/test/java/org/apache/lens/server/TestServerMode.java, line 178
> > <https://reviews.apache.org/r/36984/diff/1/?file=1026086#file1026086line178>
> >
> > Is this change needed?
>
> Himanshu Gahlaut wrote:
> Yes
>
> Rajat Khandelwal wrote:
> Why?
There is no table named as "table". Posting "select name from table" will result in rewrite failure. This test needs the query to be accepted and an handle to be returned for it. Earlier a handle was returned as there was no early rewrite and select. Going forward a handle will only be returned if rewrite and select is successful, hence the query has to be modified such that it can be successfully rewritten.
- Himanshu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36984/#review93874
-----------------------------------------------------------
On Aug. 4, 2015, 6:04 p.m., Himanshu Gahlaut wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36984/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 6:04 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-700: Addressed code review comments
>
>
> LENS-700: Fixing test cases after addition of failing driver
>
>
> Diffs
> -----
>
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java ea2433636282d0e6fdfabfb34c4421e68a125291
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d6822f6b116f07dd9a204bdf5a7c8ee7671d5
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 28ff92059b0c3040dcb54811c39a59bf684c0f6b
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b5235ad5a799cb54c27bb2449478c4e9ef593bc0
> lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 80e29ba114dbde97ab932027c7946315cdafb9c6
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java f1461bc2bd2c89836c26fd3445988009b25c6b18
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 4b9962a9cda22002cdc4826ebce3db4c77216223
> lens-server/src/test/resources/failing-query-driver-site.xml PRE-CREATION
> lens-server/src/test/resources/lens-site.xml bd9382820d59ecdc075d1f9b7258e31f899ca6d5
>
> Diff: https://reviews.apache.org/r/36984/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [9.078s]
> [INFO] Lens .............................................. SUCCESS [10.947s]
> [INFO] Lens API .......................................... SUCCESS [36.928s]
> [INFO] Lens API for server and extensions ................ SUCCESS [30.843s]
> [INFO] Lens Cube ......................................... SUCCESS [8:08.461s]
> [INFO] Lens DB storage ................................... SUCCESS [44.141s]
> [INFO] Lens Query Library ................................ SUCCESS [35.886s]
> [INFO] Lens Hive Driver .................................. SUCCESS [12:52.309s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [1:05.896s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [20.969s]
> [INFO] Lens Server ....................................... SUCCESS [18:21.693s]
> [INFO] Lens client ....................................... SUCCESS [1:06.921s]
> [INFO] Lens CLI .......................................... SUCCESS [8:41.236s]
> [INFO] Lens Examples ..................................... SUCCESS [14.389s]
> [INFO] Lens Distribution ................................. SUCCESS [15.593s]
> [INFO] Lens ML Lib ....................................... SUCCESS [3:46.342s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [6.116s]
> [INFO] Lens Regression ................................... SUCCESS [16.175s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 58:05.001s
> [INFO] Finished at: Tue Aug 04 23:26:47 IST 2015
> [INFO] Final Memory: 124M/407M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Himanshu Gahlaut
>
>
Re: Review Request 36984: LENS-700: Execute Async shall do semantic
validation, rewrite,
select driver and estimate cost before accepting a query for asynchronous
execution
Posted by Himanshu Gahlaut <ga...@gmail.com>.
> On Aug. 3, 2015, 8:04 a.m., Rajat Khandelwal wrote:
> > lens-server/src/test/java/org/apache/lens/server/TestServerMode.java, line 178
> > <https://reviews.apache.org/r/36984/diff/1/?file=1026086#file1026086line178>
> >
> > Is this change needed?
Yes
> On Aug. 3, 2015, 8:04 a.m., Rajat Khandelwal wrote:
> > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java, line 235
> > <https://reviews.apache.org/r/36984/diff/1/?file=1026091#file1026091line235>
> >
> > Shouldn't wrong query be client error instead of server error?
Yes it should be client error instead of server error. Multiple drivers are returning different error messages for the query, hence it fails with LensMultiCauseException which results in internal server error. There are already separate tickets raised for error response improvements.
> On Aug. 3, 2015, 8:04 a.m., Rajat Khandelwal wrote:
> > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java, lines 331-341
> > <https://reviews.apache.org/r/36984/diff/1/?file=1026091#file1026091line331>
> >
> > Commenting this might cause us to forget about the issue. Let's leave it uncommented.
Not commenting it is resulting in intermittent build failures. Since build time is significant, an intermittent failure results in higher development cost.
- Himanshu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36984/#review93874
-----------------------------------------------------------
On July 31, 2015, 11:35 a.m., Himanshu Gahlaut wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36984/
> -----------------------------------------------------------
>
> (Updated July 31, 2015, 11:35 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-700: Execute Async shall do semantic validation, rewrite, select driver and estimate cost before accepting a query for asynchronous execution
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d6822f6b116f07dd9a204bdf5a7c8ee7671d5
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 28ff92059b0c3040dcb54811c39a59bf684c0f6b
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b5235ad5a799cb54c27bb2449478c4e9ef593bc0
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 80e29ba114dbde97ab932027c7946315cdafb9c6
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java f1461bc2bd2c89836c26fd3445988009b25c6b18
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 4b9962a9cda22002cdc4826ebce3db4c77216223
>
> Diff: https://reviews.apache.org/r/36984/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [4.881s]
> [INFO] Lens .............................................. SUCCESS [4.588s]
> [INFO] Lens API .......................................... SUCCESS [44.023s]
> [INFO] Lens API for server and extensions ................ SUCCESS [32.745s]
> [INFO] Lens Cube ......................................... SUCCESS [7:39.032s]
> [INFO] Lens DB storage ................................... SUCCESS [1:41.287s]
> [INFO] Lens Query Library ................................ SUCCESS [20.810s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:40.758s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.890s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [26.143s]
> [INFO] Lens Server ....................................... SUCCESS [13:20.335s]
> [INFO] Lens client ....................................... SUCCESS [53.538s]
> [INFO] Lens CLI .......................................... SUCCESS [4:31.457s]
> [INFO] Lens Examples ..................................... SUCCESS [16.966s]
> [INFO] Lens Distribution ................................. SUCCESS [20.166s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:20.115s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [5.550s]
> [INFO] Lens Regression ................................... SUCCESS [17.419s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:09.849s
> [INFO] Finished at: Fri Jul 31 17:03:15 IST 2015
> [INFO] Final Memory: 127M/412M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Himanshu Gahlaut
>
>
Re: Review Request 36984: LENS-700: Execute Async shall do semantic
validation, rewrite,
select driver and estimate cost before accepting a query for asynchronous
execution
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36984/#review93874
-----------------------------------------------------------
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java (line 178)
<https://reviews.apache.org/r/36984/#comment148288>
Is this change needed?
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (line 232)
<https://reviews.apache.org/r/36984/#comment148290>
Shouldn't wrong query be client error instead of server error?
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java
<https://reviews.apache.org/r/36984/#comment148291>
Query Failure can still be emulated using a dummy driver which fails in execute call.
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (lines 291 - 301)
<https://reviews.apache.org/r/36984/#comment148292>
Commenting this might cause us to forget about the issue. Let's leave it uncommented.
- Rajat Khandelwal
On July 31, 2015, 5:05 p.m., Himanshu Gahlaut wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36984/
> -----------------------------------------------------------
>
> (Updated July 31, 2015, 5:05 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> LENS-700: Execute Async shall do semantic validation, rewrite, select driver and estimate cost before accepting a query for asynchronous execution
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d6822f6b116f07dd9a204bdf5a7c8ee7671d5
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 28ff92059b0c3040dcb54811c39a59bf684c0f6b
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b5235ad5a799cb54c27bb2449478c4e9ef593bc0
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 80e29ba114dbde97ab932027c7946315cdafb9c6
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 91e908139ca556d8611dff9eb109d9620a513352
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java f1461bc2bd2c89836c26fd3445988009b25c6b18
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 4b9962a9cda22002cdc4826ebce3db4c77216223
>
> Diff: https://reviews.apache.org/r/36984/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [4.881s]
> [INFO] Lens .............................................. SUCCESS [4.588s]
> [INFO] Lens API .......................................... SUCCESS [44.023s]
> [INFO] Lens API for server and extensions ................ SUCCESS [32.745s]
> [INFO] Lens Cube ......................................... SUCCESS [7:39.032s]
> [INFO] Lens DB storage ................................... SUCCESS [1:41.287s]
> [INFO] Lens Query Library ................................ SUCCESS [20.810s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:40.758s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.890s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [26.143s]
> [INFO] Lens Server ....................................... SUCCESS [13:20.335s]
> [INFO] Lens client ....................................... SUCCESS [53.538s]
> [INFO] Lens CLI .......................................... SUCCESS [4:31.457s]
> [INFO] Lens Examples ..................................... SUCCESS [16.966s]
> [INFO] Lens Distribution ................................. SUCCESS [20.166s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:20.115s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [5.550s]
> [INFO] Lens Regression ................................... SUCCESS [17.419s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:09.849s
> [INFO] Finished at: Fri Jul 31 17:03:15 IST 2015
> [INFO] Final Memory: 127M/412M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Himanshu Gahlaut
>
>