You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/08/21 18:36:58 UTC

Review Request 68446: Added 1.7.0 performance improvements to the CHANGELOG.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68446/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Chun-Hung Hsiao, Gastón Kleiman, Jie Yu, and Meng Zhu.


Repository: mesos


Description
-------

This adds some highlighting of important performance improvements
in 1.7.0 to ease human consumption.


Diffs
-----

  CHANGELOG 918e927d70cee3c3a952a7ef19a6273006e3afc9 


Diff: https://reviews.apache.org/r/68446/diff/1/


Testing
-------


Thanks,

Benjamin Mahler


Re: Review Request 68446: Added 1.7.0 performance improvements to the CHANGELOG.

Posted by Meng Zhu <mz...@mesosphere.io>.

> On Aug. 21, 2018, 11:39 a.m., Benjamin Mahler wrote:
> > CHANGELOG
> > Lines 11-14 (patched)
> > <https://reviews.apache.org/r/68446/diff/1/?file=2075713#file2075713line11>
> >
> >     Reference at least MESOS-9087, maybe move some of the other tickets under it?

Yeah, I think mentioning MESOS-9087 should be enough.


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68446/#review207677
-----------------------------------------------------------


On Aug. 21, 2018, 11:48 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68446/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2018, 11:48 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Chun-Hung Hsiao, Gastón Kleiman, Jie Yu, and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds some highlighting of important performance improvements
> in 1.7.0 to ease human consumption.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 918e927d70cee3c3a952a7ef19a6273006e3afc9 
> 
> 
> Diff: https://reviews.apache.org/r/68446/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Re: Review Request 68446: Added 1.7.0 performance improvements to the CHANGELOG.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68446/#review207677
-----------------------------------------------------------




CHANGELOG
Lines 11-14 (patched)
<https://reviews.apache.org/r/68446/#comment291163>

    Reference at least MESOS-9087, maybe move some of the other tickets under it?



CHANGELOG
Lines 18-21 (patched)
<https://reviews.apache.org/r/68446/#comment291162>

    Reference MESOS-9081.


- Benjamin Mahler


On Aug. 21, 2018, 6:36 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68446/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2018, 6:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Chun-Hung Hsiao, Gastón Kleiman, Jie Yu, and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds some highlighting of important performance improvements
> in 1.7.0 to ease human consumption.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 918e927d70cee3c3a952a7ef19a6273006e3afc9 
> 
> 
> Diff: https://reviews.apache.org/r/68446/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Re: Review Request 68446: Added 1.7.0 performance improvements to the CHANGELOG.

Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68446/#review207680
-----------------------------------------------------------


Ship it!




Ship It!

- Gastón Kleiman


On Aug. 21, 2018, 11:48 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68446/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2018, 11:48 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Chun-Hung Hsiao, Gastón Kleiman, Jie Yu, and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds some highlighting of important performance improvements
> in 1.7.0 to ease human consumption.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 918e927d70cee3c3a952a7ef19a6273006e3afc9 
> 
> 
> Diff: https://reviews.apache.org/r/68446/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Re: Review Request 68446: Added 1.7.0 performance improvements to the CHANGELOG.

Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68446/#review207682
-----------------------------------------------------------


Ship it!




Ship It!

- Meng Zhu


On Aug. 21, 2018, 11:48 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68446/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2018, 11:48 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Chun-Hung Hsiao, Gastón Kleiman, Jie Yu, and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds some highlighting of important performance improvements
> in 1.7.0 to ease human consumption.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 918e927d70cee3c3a952a7ef19a6273006e3afc9 
> 
> 
> Diff: https://reviews.apache.org/r/68446/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Re: Review Request 68446: Added 1.7.0 performance improvements to the CHANGELOG.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68446/#review207699
-----------------------------------------------------------



PASS: Mesos patch 68446 was successfully built and tested.

Reviews applied: `['68446']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2207/mesos-review-68446

- Mesos Reviewbot Windows


On Aug. 21, 2018, 12:54 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68446/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2018, 12:54 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Chun-Hung Hsiao, Gastón Kleiman, Jie Yu, and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds some highlighting of important performance improvements
> in 1.7.0 to ease human consumption.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 7c711d62e9a184e1698183fe5ce14edfaccf843d 
> 
> 
> Diff: https://reviews.apache.org/r/68446/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Re: Review Request 68446: Added 1.7.0 performance improvements to the CHANGELOG.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68446/
-----------------------------------------------------------

(Updated Aug. 21, 2018, 7:54 p.m.)


Review request for mesos, Alexander Rukletsov, Chun-Hung Hsiao, Gastón Kleiman, Jie Yu, and Meng Zhu.


Changes
-------

Added whitespace.


Repository: mesos


Description
-------

This adds some highlighting of important performance improvements
in 1.7.0 to ease human consumption.


Diffs (updated)
-----

  CHANGELOG 7c711d62e9a184e1698183fe5ce14edfaccf843d 


Diff: https://reviews.apache.org/r/68446/diff/3/

Changes: https://reviews.apache.org/r/68446/diff/2-3/


Testing
-------


Thanks,

Benjamin Mahler


Re: Review Request 68446: Added 1.7.0 performance improvements to the CHANGELOG.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68446/
-----------------------------------------------------------

(Updated Aug. 21, 2018, 6:48 p.m.)


Review request for mesos, Alexander Rukletsov, Chun-Hung Hsiao, Gastón Kleiman, Jie Yu, and Meng Zhu.


Changes
-------

Added links and removed duplicate highlight of MESOS-9122.


Repository: mesos


Description
-------

This adds some highlighting of important performance improvements
in 1.7.0 to ease human consumption.


Diffs (updated)
-----

  CHANGELOG 918e927d70cee3c3a952a7ef19a6273006e3afc9 


Diff: https://reviews.apache.org/r/68446/diff/2/

Changes: https://reviews.apache.org/r/68446/diff/1-2/


Testing
-------


Thanks,

Benjamin Mahler


Re: Review Request 68446: Added 1.7.0 performance improvements to the CHANGELOG.

Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68446/#review207678
-----------------------------------------------------------


Ship it!




Ship It!

- Chun-Hung Hsiao


On Aug. 21, 2018, 6:36 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68446/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2018, 6:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Chun-Hung Hsiao, Gastón Kleiman, Jie Yu, and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds some highlighting of important performance improvements
> in 1.7.0 to ease human consumption.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 918e927d70cee3c3a952a7ef19a6273006e3afc9 
> 
> 
> Diff: https://reviews.apache.org/r/68446/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>