[jira] [Commented] (FLINK-27056) "pipeline.time-characteristic" should be deprecated and have EVENT_TIME as default value

["Benchao Li (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-27056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786172#comment-17786172 ] 

Benchao Li commented on FLINK-27056:
------------------------------------

[~Zhanghao Chen] I saw in FLINK-33240 you are proposing to also document deprecated options, however, in your PR, you removed the deprecated option's document. Do you think we need to keep it in this issue?

> "pipeline.time-characteristic" should be deprecated and have EVENT_TIME as default value
> ----------------------------------------------------------------------------------------
>
>                 Key: FLINK-27056
>                 URL: https://issues.apache.org/jira/browse/FLINK-27056
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: Runtime / Configuration
>    Affects Versions: 1.12.7, 1.13.6, 1.14.4, 1.15.0
>            Reporter: Zhanghao Chen
>            Priority: Minor
>              Labels: auto-deprioritized-major, pull-request-available
>
> *Background*
>  # pipeline.time-characteristic is the configuration option used to control the time characteristic for all created streams, and has the default value _PROCESSING_TIME_ at the point of writing. However, the configuration option won't take effect unless it is explicitly set by user as we read it into the code by configurtion.getOptional(xx).ifPresent(xx).
>  # The default value of _TIME_CHARACTERISTIC_ has been changed from _PROCESSING_TIME_ to _EVENT_TIME_ in FLINK-19317 Make EventTime the default StreamTimeCharacteristic - ASF JIRA (apache.org)
>  # _TIME_CHARACTERISTIC_ and the relevant operations that set or uses it have been deprecated in FLINK-19318 Deprecate timeWindow() operations in DataStream API - ASF JIRA (apache.org) and FLINK-19319 Deprecate StreamExecutionEnvironment.setStreamTimeCharacteristic() and TimeCharacteristic - ASF JIRA (apache.org)
> *Proposed Change*
>  # {*}{*}pipeline.time-characteristic should be deprecated, just like other _TIME_CHARACTERISTIC_ related operations as we no longer want user to set this.
>  # pipeline.time-characteristic should have the default value of {_}EVENT_TIME{_}, to reflect the actual default value in system, and avoid misleading users.
> Additionally, I think all configuration options which only take effect when it is explicitly set by user (aka those read into the system by configurtion.getOptional(xx).ifPresent(xx)), should have no default values.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)